From: Andreas Schwab <schwab@linux-m68k.org>
To: "Colin Woodbury" <colin@fosskers.ca>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: [PATCH] lisp/files.el: Add `file-name-set-extension`
Date: Wed, 26 May 2021 09:34:11 +0200 [thread overview]
Message-ID: <87czteeyoc.fsf@igel.home> (raw)
In-Reply-To: <6ba4668c-9b39-40e0-a155-f7e583fd33b6@www.fastmail.com> (Colin Woodbury's message of "Tue, 25 May 2021 14:44:30 -0700")
On Mai 25 2021, Colin Woodbury wrote:
> +Returns nil if either of the FILENAME or EXTENSION are nil before
> +dot consolidation, or empty afterwards."
> + (when (and filename extension)
I still don't see any reason to allow nil. A file name is always a
string.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-05-26 7:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 15:50 [PATCH] lisp/files.el: Add `file-name-set-extension` Colin Woodbury
2021-05-25 17:48 ` Andreas Schwab
2021-05-25 19:42 ` Colin Woodbury
2021-05-25 18:00 ` Basil L. Contovounesios
2021-05-25 19:45 ` Colin Woodbury
2021-05-25 20:25 ` Stefan Monnier
2021-05-25 21:21 ` Colin Woodbury
2021-05-25 21:29 ` Stefan Monnier
2021-05-25 21:44 ` Colin Woodbury
2021-05-26 7:34 ` Andreas Schwab [this message]
2021-05-26 16:31 ` Colin Woodbury
2021-05-26 17:39 ` Andreas Schwab
2021-05-31 1:16 ` Colin Woodbury
2021-06-04 13:08 ` Philipp
[not found] ` <26B660D9-AC76-4AFC-9FFD-2F5D4DCA16C1@acm.org>
2021-06-09 20:54 ` Colin Woodbury
2021-06-09 23:05 ` Stefan Monnier
2021-06-10 0:42 ` Colin Woodbury
2021-06-10 2:45 ` Colin Woodbury
2021-06-10 7:46 ` Michael Albinus
2021-06-10 14:40 ` Colin Woodbury
2021-06-16 1:15 ` Colin Woodbury
2021-06-19 9:16 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czteeyoc.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=colin@fosskers.ca \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).