From: Vasilij Schneidermann <mail@vasilij.de>
To: Friedrich Beckmann <friedrich.beckmann@gmx.de>
Cc: PSPP Development Mailing List <pspp-dev@gnu.org>, emacs-devel@gnu.org
Subject: Re: [ELPA] New package: pspp-mode.el for PSPP/SPSS syntax highlighting
Date: Tue, 30 Jun 2020 15:07:44 +0200 [thread overview]
Message-ID: <20200630130744.GC451135@odonien.localdomain> (raw)
In-Reply-To: <136BE842-9BBB-4D69-A994-705993AF58EC@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
Hello Friedrich,
> The file is available here:
>
> http://git.savannah.gnu.org/cgit/pspp.git/tree/pspp-mode.el
>
> Can you integrate that in gnu elpa?
The GNU ELPA Readme [1] explains the necessary steps for this. One
prerequisite is following the coding style, there's a number of things sticking
out in your code:
- Inconsistent paragraph spacing (sometimes the expected newline is missing,
sometimes there's two or three of them, with no clear reason why).
- Lone opening/closing parentheses are something to be avoided, please keep
these together.
- Indentation of comments is inconsistent and doesn't line up with code.
- The major mode definition should use `define-derived-mode`, that way you no
longer need to manipulate major mode name/hooks/local variables/syntax
tables/key maps.
All but the last point are elaborated in further detail in Riastradh's Lisp
Style Rules [2].
Vasilij
[1]: http://git.savannah.gnu.org/cgit/emacs/elpa.git/plain/README
[2]: https://mumble.net/~campbell/scheme/style.txt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-30 13:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 19:53 [ELPA] New package: pspp-mode.el for PSPP/SPSS syntax highlighting Friedrich Beckmann
2020-06-30 13:07 ` Vasilij Schneidermann [this message]
[not found] <jwvr1twzlte.fsf-monnier+emacs@gnu.org>
2020-06-30 21:55 ` Fwd: " Friedrich Beckmann
2020-07-04 13:12 ` Stefan Monnier
2020-07-04 15:15 ` John Darrington
2020-07-05 9:44 ` Friedrich Beckmann
2020-07-05 11:18 ` John Darrington
2020-07-05 16:51 ` Sean Whitton
2020-07-05 17:14 ` Friedrich Beckmann
2020-07-05 18:35 ` John Darrington
2020-07-05 18:50 ` tomas
2020-07-05 20:20 ` Sean Whitton
2020-07-06 5:53 ` Dmitry Alexandrov
2020-07-06 6:01 ` Sean Whitton
2020-07-06 6:38 ` Dmitry Alexandrov
2020-07-07 4:51 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630130744.GC451135@odonien.localdomain \
--to=mail@vasilij.de \
--cc=emacs-devel@gnu.org \
--cc=friedrich.beckmann@gmx.de \
--cc=pspp-dev@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).