From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vasilij Schneidermann Newsgroups: gmane.emacs.devel,gmane.comp.statistics.pspp.devel Subject: Re: [ELPA] New package: pspp-mode.el for PSPP/SPSS syntax highlighting Date: Tue, 30 Jun 2020 15:07:44 +0200 Message-ID: <20200630130744.GC451135@odonien.localdomain> References: <136BE842-9BBB-4D69-A994-705993AF58EC@gmx.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uxuisgdDHaNETlh8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28558"; mail-complaints-to="usenet@ciao.gmane.io" Cc: PSPP Development Mailing List , emacs-devel@gnu.org To: Friedrich Beckmann Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 30 18:44:49 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jqIxB-0008k9-PU for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Jun 2020 18:17:49 +0200 Original-Received: from localhost ([::1]:59276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqG01-0005AH-G5 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Jun 2020 09:08:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqFzQ-0004Jk-Uq; Tue, 30 Jun 2020 09:07:56 -0400 Original-Received: from mout-p-202.mailbox.org ([80.241.56.172]:51274) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1jqFzO-0001bw-VJ; Tue, 30 Jun 2020 09:07:56 -0400 Original-Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 49x4Qs3b4LzQlK0; Tue, 30 Jun 2020 15:07:49 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Original-Received: from smtp1.mailbox.org ([80.241.60.240]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id I9CjNsihbaZN; Tue, 30 Jun 2020 15:07:45 +0200 (CEST) Mail-Followup-To: Friedrich Beckmann , emacs-devel@gnu.org, PSPP Development Mailing List Content-Disposition: inline In-Reply-To: <136BE842-9BBB-4D69-A994-705993AF58EC@gmx.de> X-MBO-SPAM-Probability: 0 X-Rspamd-Score: -5.55 / 15.00 / 15.00 X-Rspamd-Queue-Id: 0091617FE X-Rspamd-UID: f06334 Received-SPF: pass client-ip=80.241.56.172; envelope-from=mail@vasilij.de; helo=mout-p-202.mailbox.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/30 09:07:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252593 gmane.comp.statistics.pspp.devel:7567 Archived-At: --uxuisgdDHaNETlh8 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Friedrich, > The file is available here: >=20 > http://git.savannah.gnu.org/cgit/pspp.git/tree/pspp-mode.el >=20 > Can you integrate that in gnu elpa? The GNU ELPA Readme [1] explains the necessary steps for this. One prerequisite is following the coding style, there's a number of things stic= king out in your code: - Inconsistent paragraph spacing (sometimes the expected newline is missing, sometimes there's two or three of them, with no clear reason why). - Lone opening/closing parentheses are something to be avoided, please keep these together. - Indentation of comments is inconsistent and doesn't line up with code. - The major mode definition should use `define-derived-mode`, that way you = no longer need to manipulate major mode name/hooks/local variables/syntax tables/key maps. All but the last point are elaborated in further detail in Riastradh's Lisp Style Rules [2]. Vasilij [1]: http://git.savannah.gnu.org/cgit/emacs/elpa.git/plain/README [2]: https://mumble.net/~campbell/scheme/style.txt --uxuisgdDHaNETlh8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEE0dAcySl3bqM8O17WFmfJg6zCifoFAl77OSAACgkQFmfJg6zC ifrA7Qf+J6LvhDO83NcdjEkCwNW1OSUVNwiFjgPjWON6UJyQsLznif0ulLUnIiU9 Ri7WMPSBze9kuZAtAkLStyPeJhj7Xw/py41aqtj/LRwzX00HSI4t9Utzm2vtanAS G1zT7IhKXX7c2yqRfiit15Q+uHdpd/gGViD0twHpMDzkeCz/m2OQlriym3iGLM5X c1uZ17tSpEo2vLA5hhjvkw9d+An8LxYT+uKo5vz538C+adoHonEw6zuNbyY+JUEK bbtzUCiJ4sp68eAtXKpDIjCdAjFj/pIV4Nq6a4Ncn4TLq3eLi5SbXb+vtiOS6QCF hsHock8CEs++SYTYAHoKF1r/Av23fA== =Z+5J -----END PGP SIGNATURE----- --uxuisgdDHaNETlh8--