unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: paranda@it.uc3m.es, emacs-devel@gnu.org
Subject: Re: Compiling emacs-27.0.91 on macOS Catalina
Date: Fri, 15 May 2020 07:25:58 +0100	[thread overview]
Message-ID: <20200515062558.GA52382@breton.holly.idiocy.org> (raw)
In-Reply-To: <83d0754tqs.fsf@gnu.org>

On Fri, May 15, 2020 at 09:06:35AM +0300, Eli Zaretskii wrote:
> > Date: Thu, 14 May 2020 20:24:32 +0100
> > From: Alan Third <alan@idiocy.org>
> > Cc: paranda@it.uc3m.es, emacs-devel@gnu.org
> > 
> > > > Please try deleting ~/Library/Colors/Emacs.clr
> > > 
> > > Should we have this in PROBLEMS?
> > 
> > Although it does still seem to be a rare problem, I’m beginning to
> > think that we should.
> > 
> > Does this seem reasonable?
> 
> Yes, thanks.  Please push to the emacs-27 branch.

Alternatively we could check the results from trying to load the file.
There's no way I can see to catch the error, but we can count the
number of colours available. Is this too late for Emacs 27?

modified   src/nsterm.m
@@ -5368,7 +5368,8 @@ Needs to be here because ns_initialize_display_info () uses AppKit classes.
   {
     NSColorList *cl = [NSColorList colorListNamed: @"Emacs"];
 
-    if ( cl == nil )
+    /* There are 752 colors defined in rgb.txt.  */
+    if ( cl == nil || [[cl allKeys] count] < 752)
       {
         Lisp_Object color_file, color_map, color;
         unsigned long c;

-- 
Alan Third



  reply	other threads:[~2020-05-15  6:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12  6:44 Compiling emacs-27.0.91 on macOS Catalina PEDRO ANDRES ARANDA GUTIERREZ
2020-05-12 15:57 ` Eli Zaretskii
2020-05-12 22:19 ` Alan Third
2020-05-13  2:22   ` Eli Zaretskii
2020-05-13  4:52     ` PEDRO ANDRES ARANDA GUTIERREZ
2020-05-14 19:24     ` Alan Third
2020-05-15  5:10       ` PEDRO ANDRES ARANDA GUTIERREZ
2020-05-15  6:06       ` Eli Zaretskii
2020-05-15  6:25         ` Alan Third [this message]
2020-05-15  9:56           ` Eli Zaretskii
2020-05-15 10:46             ` Alan Third
2020-05-15 11:26               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515062558.GA52382@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=paranda@it.uc3m.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).