From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Compiling emacs-27.0.91 on macOS Catalina Date: Fri, 15 May 2020 07:25:58 +0100 Message-ID: <20200515062558.GA52382@breton.holly.idiocy.org> References: <20200512221907.GB50065@breton.holly.idiocy.org> <83sgg47evg.fsf@gnu.org> <20200514192432.GA50681@breton.holly.idiocy.org> <83d0754tqs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="55661"; mail-complaints-to="usenet@ciao.gmane.io" Cc: paranda@it.uc3m.es, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 15 08:28:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZTpn-000ENN-Kt for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 08:28:39 +0200 Original-Received: from localhost ([::1]:51380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZTpm-0002Xy-N3 for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 02:28:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZTpF-0001g5-3A for emacs-devel@gnu.org; Fri, 15 May 2020 02:28:05 -0400 Original-Received: from idiocy.org ([217.169.17.33]:54382 helo=breton.holly.idiocy.org) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZTpC-00005E-OQ; Fri, 15 May 2020 02:28:04 -0400 Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 9B1A92022C86BD; Fri, 15 May 2020 07:25:58 +0100 (BST) Mail-Followup-To: Alan Third , Eli Zaretskii , paranda@it.uc3m.es, emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <83d0754tqs.fsf@gnu.org> Received-SPF: none client-ip=217.169.17.33; envelope-from=alan@breton.holly.idiocy.org; helo=breton.holly.idiocy.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/15 02:25:59 X-ACL-Warn: Detected OS = Mac OS X [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250348 Archived-At: On Fri, May 15, 2020 at 09:06:35AM +0300, Eli Zaretskii wrote: > > Date: Thu, 14 May 2020 20:24:32 +0100 > > From: Alan Third > > Cc: paranda@it.uc3m.es, emacs-devel@gnu.org > > > > > > Please try deleting ~/Library/Colors/Emacs.clr > > > > > > Should we have this in PROBLEMS? > > > > Although it does still seem to be a rare problem, I’m beginning to > > think that we should. > > > > Does this seem reasonable? > > Yes, thanks. Please push to the emacs-27 branch. Alternatively we could check the results from trying to load the file. There's no way I can see to catch the error, but we can count the number of colours available. Is this too late for Emacs 27? modified src/nsterm.m @@ -5368,7 +5368,8 @@ Needs to be here because ns_initialize_display_info () uses AppKit classes. { NSColorList *cl = [NSColorList colorListNamed: @"Emacs"]; - if ( cl == nil ) + /* There are 752 colors defined in rgb.txt. */ + if ( cl == nil || [[cl allKeys] count] < 752) { Lisp_Object color_file, color_map, color; unsigned long c; -- Alan Third