unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: paranda@it.uc3m.es, emacs-devel@gnu.org
Subject: Re: Compiling emacs-27.0.91 on macOS Catalina
Date: Fri, 15 May 2020 11:46:00 +0100	[thread overview]
Message-ID: <20200515104600.GA52992@breton.holly.idiocy.org> (raw)
In-Reply-To: <83lflt34ja.fsf@gnu.org>

On Fri, May 15, 2020 at 12:56:25PM +0300, Eli Zaretskii wrote:
> > Date: Fri, 15 May 2020 07:25:58 +0100
> > From: Alan Third <alan@idiocy.org>
> > Cc: paranda@it.uc3m.es, emacs-devel@gnu.org
> > 
> > Alternatively we could check the results from trying to load the file.
> > There's no way I can see to catch the error, but we can count the
> > number of colours available. Is this too late for Emacs 27?
> 
> I don't think I understand the effect of this change yet, so I cannot
> answer the question.  How will this prevent the problem?

The color file is simply a native version of etc/rgb.txt. It contains
colour values and their names.

I'm not really sure why we save it, to be honest.

On first run Emacs detects there is no color file (cl == nil in the
code) and generates it from rgb.txt.

Since we're unable to detect directly if loading the color file has
thrown an error my change checks whether there are less colors loaded
than there are in rgb.txt. If there are less then it will regenerate
the file.

It's not great, rgb.txt could change, but I assume at this stage that
that's unlikely or rare.
-- 
Alan Third



  reply	other threads:[~2020-05-15 10:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12  6:44 Compiling emacs-27.0.91 on macOS Catalina PEDRO ANDRES ARANDA GUTIERREZ
2020-05-12 15:57 ` Eli Zaretskii
2020-05-12 22:19 ` Alan Third
2020-05-13  2:22   ` Eli Zaretskii
2020-05-13  4:52     ` PEDRO ANDRES ARANDA GUTIERREZ
2020-05-14 19:24     ` Alan Third
2020-05-15  5:10       ` PEDRO ANDRES ARANDA GUTIERREZ
2020-05-15  6:06       ` Eli Zaretskii
2020-05-15  6:25         ` Alan Third
2020-05-15  9:56           ` Eli Zaretskii
2020-05-15 10:46             ` Alan Third [this message]
2020-05-15 11:26               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515104600.GA52992@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=paranda@it.uc3m.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).