From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ofv@wanadoo.es, rcopley@gmail.com, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: Unbalanced change hooks (part 2)
Date: Mon, 8 Aug 2016 14:36:14 +0000 [thread overview]
Message-ID: <20160808143614.GA7208@acm.fritz.box> (raw)
In-Reply-To: <83eg67m3aq.fsf@gnu.org>
Hello, Eli.
On Tue, Aug 02, 2016 at 09:30:37PM +0300, Eli Zaretskii wrote:
> > Date: Tue, 02 Aug 2016 20:17:35 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: ofv@wanadoo.es, rcopley@gmail.com, rms@gnu.org, emacs-devel@gnu.org
> > > Anyhow, it's not just CC Mode. As already discussed, there are 13 other
> > > files which use before-change-functions, and some of these uses are
> > > going to assume it works as documented, just as CC Mode did. Sporadic
> > > failures are going to occur in some of these other places, due to those
> > > hook functions sometimes not being called.
> > I will believe that when I see specific bug reports about those other
> > packages.
> Btw, I'm slowly but surely arriving to the conclusion that the
> problems we are discussing can only happen when insert-file-contents
> is called with VISIT and REPLACE non-nil, i.e. when reverting a
> buffer. Do we have any evidence to the contrary? If we do, can
> someone show or point to such contradicting evidence?
> If my conclusion is correct, then we should probably focus on this
> particular use case and look for a solution for it, as opposed to
> trying to solve some more general problem that seems not to exist. It
> might be much easier and simpler.
Using buffer-undo-list temporarily to reverse a change and run
c-before-change seems to work well when the undo list is enabled. When
it isn't enabled, I run into problems which don't look like being solved
easily.
If you're right in supposing that only insert-file-contents with those
particular parameters can cause the omission of the
before-change-functions call, then a solution would be for CC Mode to
advise those commands which call insert-f-c this way. That advice would
cause the command to test and clear a flag set by CC Mode, and if it was
non-nil, to repeat the command.
Repeating find-file and revert-buffer in these circumstances appears to
work.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2016-08-08 14:36 UTC|newest]
Thread overview: 189+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 12:16 Unbalanced change hooks (part 2) Alan Mackenzie
2016-07-31 13:58 ` Noam Postavsky
2016-07-31 15:21 ` Alan Mackenzie
2016-07-31 15:03 ` Eli Zaretskii
2016-07-31 17:28 ` Alan Mackenzie
2016-07-31 18:11 ` Eli Zaretskii
2016-07-31 18:52 ` Eli Zaretskii
2016-07-31 19:08 ` Eli Zaretskii
2016-07-31 19:20 ` Noam Postavsky
2016-07-31 21:26 ` Alan Mackenzie
2016-08-01 13:01 ` Stefan Monnier
2016-08-01 13:07 ` Eli Zaretskii
2016-08-01 16:53 ` Alan Mackenzie
2016-08-01 17:15 ` Alan Mackenzie
2016-08-01 19:39 ` Eli Zaretskii
2016-08-01 20:52 ` Alan Mackenzie
2016-08-02 14:44 ` Eli Zaretskii
2016-08-02 16:09 ` Alan Mackenzie
2016-08-02 16:42 ` Eli Zaretskii
2016-08-02 17:24 ` Stefan Monnier
2016-08-07 14:49 ` Alan Mackenzie
2016-08-07 15:09 ` Stefan Monnier
2016-08-07 21:48 ` Alan Mackenzie
2016-08-08 0:55 ` Stefan Monnier
2016-08-02 14:46 ` Stefan Monnier
2016-08-01 19:37 ` Eli Zaretskii
2016-08-02 14:39 ` Stefan Monnier
2016-07-31 18:55 ` Stefan Monnier
2016-07-31 19:26 ` Eli Zaretskii
2016-07-31 21:59 ` Stefan Monnier
2016-08-01 13:09 ` Eli Zaretskii
2016-08-01 14:36 ` Stefan Monnier
2016-08-01 14:48 ` Eli Zaretskii
2016-08-01 15:28 ` Stefan Monnier
2016-07-31 19:33 ` Alan Mackenzie
2016-07-31 19:21 ` Eli Zaretskii
2016-08-09 15:01 ` Alan Mackenzie
2016-08-09 15:14 ` Eli Zaretskii
2016-08-19 14:51 ` Phillip Lord
2016-08-30 1:15 ` Stefan Monnier
2016-08-30 14:34 ` Phillip Lord
2016-08-30 15:11 ` Stefan Monnier
2016-08-31 11:00 ` Phillip Lord
2016-08-31 12:24 ` Stefan Monnier
2016-09-01 6:49 ` Phillip Lord
2016-09-01 13:36 ` Stefan Monnier
2016-09-01 6:40 ` Phillip Lord
2016-09-01 13:33 ` Stefan Monnier
2016-09-02 11:34 ` Phillip Lord
2016-08-30 16:08 ` Eli Zaretskii
2016-08-01 16:38 ` Richard Stallman
2016-08-02 10:15 ` Alan Mackenzie
2016-08-02 10:37 ` Richard Copley
2016-08-02 16:11 ` Alan Mackenzie
2016-08-02 14:57 ` Eli Zaretskii
2016-08-02 16:55 ` Alan Mackenzie
2016-08-02 17:17 ` Eli Zaretskii
2016-08-02 18:30 ` Eli Zaretskii
2016-08-02 19:38 ` Alan Mackenzie
2016-08-03 2:36 ` Eli Zaretskii
2016-08-08 14:36 ` Alan Mackenzie [this message]
2016-08-08 15:42 ` Eli Zaretskii
2016-08-08 16:54 ` Alan Mackenzie
2016-08-08 17:17 ` Eli Zaretskii
2016-08-08 18:42 ` Alan Mackenzie
2016-08-08 19:04 ` Eli Zaretskii
2016-08-08 19:54 ` Unbalanced change hooks (part 2) [PATCH] Alan Mackenzie
2016-08-09 15:08 ` Eli Zaretskii
2016-08-09 16:38 ` Unbalanced change hooks (part 2) [Documentation fix still remaining] Alan Mackenzie
2016-08-09 16:42 ` Eli Zaretskii
2016-08-09 18:13 ` Eli Zaretskii
2016-08-09 18:35 ` Alan Mackenzie
2016-08-09 17:14 ` Stefan Monnier
2016-08-09 18:19 ` Eli Zaretskii
2016-08-09 19:09 ` Stefan Monnier
2016-08-10 14:21 ` Eli Zaretskii
2016-08-10 14:56 ` Stefan Monnier
2016-08-10 15:16 ` Alan Mackenzie
2016-08-10 15:44 ` Stefan Monnier
2016-08-10 16:03 ` Eli Zaretskii
2016-08-10 16:11 ` Stefan Monnier
2016-08-18 14:26 ` Eli Zaretskii
2016-08-18 16:56 ` Stefan Monnier
2016-08-19 8:45 ` Alan Mackenzie
2016-08-19 9:12 ` Eli Zaretskii
2016-08-19 9:21 ` Stefan Monnier
2016-08-19 9:39 ` Eli Zaretskii
2016-08-19 9:19 ` Stefan Monnier
2016-08-10 16:18 ` Alan Mackenzie
2016-08-10 16:54 ` Eli Zaretskii
2016-08-10 17:49 ` Alan Mackenzie
2016-08-10 18:10 ` Eli Zaretskii
2016-08-10 18:57 ` Alan Mackenzie
2016-08-10 19:08 ` Eli Zaretskii
2016-08-10 19:50 ` Stefan Monnier
2016-08-11 11:29 ` Alan Mackenzie
2016-08-11 16:43 ` Stefan Monnier
2016-08-28 11:23 ` Daniel Colascione
2016-08-28 15:01 ` Stefan Monnier
2016-08-28 22:16 ` Daniel Colascione
2016-08-28 22:44 ` Stefan Monnier
2016-08-28 23:11 ` Daniel Colascione
2016-08-29 0:09 ` Stefan Monnier
2016-08-29 3:18 ` Daniel Colascione
2016-08-29 13:00 ` Stefan Monnier
2016-08-29 14:51 ` Eli Zaretskii
2016-08-29 15:50 ` Stefan Monnier
2016-08-29 16:22 ` Eli Zaretskii
2016-08-29 15:14 ` Daniel Colascione
2016-08-29 15:44 ` Stefan Monnier
2016-08-30 14:07 ` Phillip Lord
2016-08-30 15:51 ` Eli Zaretskii
2016-08-30 16:22 ` Daniel Colascione
2016-08-30 16:46 ` Eli Zaretskii
2016-08-29 14:50 ` Eli Zaretskii
2016-08-29 15:30 ` Daniel Colascione
2016-08-29 16:20 ` Eli Zaretskii
2016-08-29 16:26 ` Daniel Colascione
2016-08-29 17:01 ` Eli Zaretskii
2016-08-29 17:48 ` Daniel Colascione
2016-08-29 18:04 ` Eli Zaretskii
2016-08-29 18:16 ` Eli Zaretskii
2016-08-30 2:27 ` Daniel Colascione
2016-08-30 2:44 ` Eli Zaretskii
2016-08-30 0:25 ` Stefan Monnier
2016-08-30 2:26 ` Daniel Colascione
2016-08-30 2:38 ` Eli Zaretskii
2016-08-30 2:54 ` Daniel Colascione
2016-08-30 14:20 ` Phillip Lord
2016-08-30 15:08 ` Eli Zaretskii
2016-08-30 12:56 ` Stefan Monnier
2016-08-30 14:12 ` Phillip Lord
2016-08-30 16:06 ` Eli Zaretskii
2016-08-31 11:20 ` Phillip Lord
2016-08-31 14:57 ` Eli Zaretskii
2016-08-30 17:12 ` Alan Mackenzie
2016-08-30 17:27 ` Daniel Colascione
2016-08-30 17:42 ` Eli Zaretskii
2016-08-30 17:46 ` Daniel Colascione
2016-08-30 18:00 ` Eli Zaretskii
2016-08-30 18:04 ` Daniel Colascione
2016-08-30 18:46 ` Eli Zaretskii
2016-08-30 18:58 ` Daniel Colascione
2016-08-30 19:17 ` Eli Zaretskii
2016-08-30 21:46 ` Stefan Monnier
2016-08-31 2:38 ` Eli Zaretskii
2016-08-30 18:27 ` Stefan Monnier
2016-09-01 13:46 ` Eli Zaretskii
2016-08-30 18:01 ` Alan Mackenzie
2016-08-30 18:06 ` Daniel Colascione
2016-08-30 18:17 ` Daniel Colascione
2016-08-30 18:30 ` Alan Mackenzie
2016-08-30 18:32 ` Daniel Colascione
2016-08-30 18:47 ` Alan Mackenzie
2016-08-30 18:55 ` Daniel Colascione
2016-08-30 19:14 ` Alan Mackenzie
2016-08-30 20:34 ` Stefan Monnier
2016-08-30 20:53 ` Alan Mackenzie
2016-08-30 21:37 ` Stefan Monnier
2016-08-30 18:36 ` Stefan Monnier
2016-08-30 18:22 ` Stefan Monnier
2016-08-30 18:00 ` Stefan Monnier
2016-08-30 17:27 ` Eli Zaretskii
2016-08-30 17:42 ` Alan Mackenzie
2016-08-30 17:53 ` Eli Zaretskii
2016-08-30 18:16 ` Alan Mackenzie
2016-08-30 18:51 ` Eli Zaretskii
2016-08-30 19:00 ` Alan Mackenzie
2016-08-30 18:14 ` Stefan Monnier
2016-09-01 21:25 ` Davis Herring
2016-09-02 7:26 ` Eli Zaretskii
2016-08-28 22:36 ` Stefan Monnier
2016-08-30 13:30 ` Phillip Lord
2016-08-30 13:39 ` Stefan Monnier
2016-08-31 11:04 ` Phillip Lord
2016-08-30 15:47 ` Eli Zaretskii
2016-08-30 16:01 ` Stefan Monnier
2016-08-30 16:58 ` Eli Zaretskii
2016-08-30 17:57 ` Stefan Monnier
2016-08-31 11:17 ` Phillip Lord
2016-08-31 11:12 ` Phillip Lord
2016-08-30 16:23 ` Daniel Colascione
2016-08-30 16:53 ` Eli Zaretskii
2016-08-02 19:00 ` Unbalanced change hooks (part 2) Alan Mackenzie
2016-08-02 19:25 ` Eli Zaretskii
2016-08-07 21:16 ` Alan Mackenzie
2016-08-08 15:38 ` Eli Zaretskii
2016-08-08 19:56 ` Stefan Monnier
2016-08-08 20:16 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808143614.GA7208@acm.fritz.box \
--to=acm@muc.de \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=ofv@wanadoo.es \
--cc=rcopley@gmail.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).