From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: font-lock-comment-delimiter-face Date: Sat, 21 May 2005 10:51:42 -0700 Message-ID: <200505211751.j4LHpiKE003108@scanner2.ics.uci.edu> References: <87wtq3ydmf.fsf-monnier+emacs@gnu.org> <17029.21411.495779.643570@farnswood.snap.net.nz> <17030.32533.416687.524645@farnswood.snap.net.nz> <85k6m04y6f.fsf@lola.goethe.zz> <857ji0nly2.fsf@lola.goethe.zz> <200505191652.j4JGqsHc011903@amrm2.ics.uci.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1116697958 29819 80.91.229.2 (21 May 2005 17:52:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 21 May 2005 17:52:38 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 21 19:52:35 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DZY8t-0001oO-1N for ged-emacs-devel@m.gmane.org; Sat, 21 May 2005 19:52:08 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DZYBx-0008Vx-K7 for ged-emacs-devel@m.gmane.org; Sat, 21 May 2005 13:55:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DZYBB-0008Fa-QL for emacs-devel@gnu.org; Sat, 21 May 2005 13:54:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DZYBA-0008Eu-RH for emacs-devel@gnu.org; Sat, 21 May 2005 13:54:29 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DZYBA-0008ET-ML for emacs-devel@gnu.org; Sat, 21 May 2005 13:54:28 -0400 Original-Received: from [128.195.1.36] (helo=scanner2.ics.uci.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DZYHq-0003Uz-1P; Sat, 21 May 2005 14:01:22 -0400 Original-Received: from vino.ics.uci.edu (dann@vino.ics.uci.edu [128.195.11.198]) by scanner2.ics.uci.edu (8.12.10/8.12.10) with ESMTP id j4LHpiKE003108; Sat, 21 May 2005 10:51:44 -0700 (PDT) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Fri, 20 May 2005 17:56:48 -0400") Original-Lines: 81 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam (whitelisted), SpamAssassin (score=-99.788, required 5, SUBJ_HAS_UNIQ_ID, USER_IN_WHITELIST) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37440 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37440 Richard Stallman writes: > If the red colored comments are hard to read on a console, can't we > just change the face foreground for font-lock-comment-face for that > situation (i.e. min-colors == 8 and background-mode == 'dark)? > It seems to me that would be a lot easier than adding > font-lock-comment-delimiter-face route? > > I am not entirely sure what you're proposing. > Could you be more specific? I could try it out. Your original complaint was that font-lock-comment-face that has face-foreground "red" is hard to read on a console. I am proposing to just change that "red" color to some other color that is readable on a console. > So just do M-x list-colors-display RET pick a color for comments and > I'll do the needed change. > > Please don't install such a change, but I'd appreciate it if you sent > me a patch to try. I had no intention of installing a change without reaching some consensus. That would not be wise given the amount of discussions going on. Please try this patch: *** font-lock.el 20 May 2005 15:40:40 -0700 1.257 --- font-lock.el 21 May 2005 10:36:03 -0700 *************** *** 1678,1686 **** (((class color) (min-colors 16) (background dark)) (:foreground "red1")) (((class color) (min-colors 8) (background light)) ! ) (((class color) (min-colors 8) (background dark)) ! ) (t (:weight bold :slant italic))) "Font Lock mode face used to highlight comments." :group 'font-lock-highlighting-faces) --- 1678,1691 ---- (((class color) (min-colors 16) (background dark)) (:foreground "red1")) (((class color) (min-colors 8) (background light)) ! ;; IMHO this should not have been changed, red is quite readable ! ;; on a light background (e.g. xterm -bg white) ! (:foreground "red")) (((class color) (min-colors 8) (background dark)) ! ;; Change the color here if you want to see how other colors ! ;; look like for comments. ! ;; You can choose one of: black red green yellow blue magenta cyan white ! (:foreground "yellow")) (t (:weight bold :slant italic))) "Font Lock mode face used to highlight comments." :group 'font-lock-highlighting-faces) *************** *** 1689,1698 **** '((default :inherit font-lock-comment-face) (((class grayscale))) (((class color) (min-colors 16))) ! (((class color) (min-colors 8) (background light)) ! :foreground "red") ! (((class color) (min-colors 8) (background dark)) ! :foreground "red1")) "Font Lock mode face used to highlight comment delimiters." :group 'font-lock-highlighting-faces) --- 1694,1705 ---- '((default :inherit font-lock-comment-face) (((class grayscale))) (((class color) (min-colors 16))) ! ;; Commented out to disable the effects of font-lock-comment-delimiter-face ! ;; (((class color) (min-colors 8) (background light)) ! ;; :foreground "red") ! ;; (((class color) (min-colors 8) (background dark)) ! ;; :foreground "red1")) ! ) "Font Lock mode face used to highlight comment delimiters." :group 'font-lock-highlighting-faces)