unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kenichi Handa <handa@m17n.org>
Cc: emacs-devel@gnu.org
Subject: Re: TUTORIAL.bg and windows-1251
Date: Mon, 19 Jan 2004 09:34:05 +0900 (JST)	[thread overview]
Message-ID: <200401190034.JAA24455@etlken.m17n.org> (raw)
In-Reply-To: <40098D96.90205@fmi.uni-sofia.bg> (message from Ognyan Kulev on Sat, 17 Jan 2004 21:31:34 +0200)

In article <40098D96.90205@fmi.uni-sofia.bg>, Ognyan Kulev <ogi@fmi.uni-sofia.bg> writes:
> The patch I've send you raises priority in two functions.  Actually, 
> only raising it in fontset_font_pattern gives effect.  So when run with 
> "emacs -q" and cyrillic character is being displayed, is it expected 
> that "FONTSET (fontset, c)" fails in function fontset_font_pattern, or 
> "fontset_id_valid_p (id)" is false?  One of these must fail somewhat in 
> order lookup_overriding_fontspec to be used.

Thank you!!  That question makes me realize what was wrong
in my previous code.  As I installed a fix, please try again
with the latest CVS code.

In my environment, X resource "Font" is set.  Thus, Emacs
creates a fontset "fontset-startup" from that font which
doesn't specify any font for Cyrillic.  Thus, FONTSET_REF
(fontset, c) returns nil in my case.  But, if X resource
"Font" is not set (I think it's your case), Emacs uses the
default fontset.  So, FONTSET_REF (fontset, c) returns
ISO10646-1 font for Cyrillic.  The fix is apperant as below.
It makes the logic for font finding the same as
fontset_ref_via_base.

---
Ken'ichi HANDA
handa@m17n.org

Index: fontset.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/fontset.c,v
retrieving revision 1.83
retrieving revision 1.84
diff -u -c -r1.83 -r1.84
cvs server: conflicting specifications of output style
*** fontset.c	7 Jan 2004 00:21:53 -0000	1.83
--- fontset.c	19 Jan 2004 00:22:03 -0000	1.84
***************
*** 598,604 ****
        fontset = FONTSET_FROM_ID (id);
        xassert (!BASE_FONTSET_P (fontset));
        fontset = FONTSET_BASE (fontset);
!       elt = FONTSET_REF (fontset, c);
      }
    if (NILP (elt))
      {
--- 598,605 ----
        fontset = FONTSET_FROM_ID (id);
        xassert (!BASE_FONTSET_P (fontset));
        fontset = FONTSET_BASE (fontset);
!       if (! EQ (fontset, Vdefault_fontset))
! 	elt = FONTSET_REF (fontset, c);
      }
    if (NILP (elt))
      {

  reply	other threads:[~2004-01-19  0:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-14 18:56 TUTORIAL.bg and windows-1251 Ognyan Kulev
2003-11-15 12:19 ` Ognyan Kulev
2003-11-26  7:33   ` Ognyan Kulev
2003-11-15 14:24 ` Jason Rumney
2003-11-17  7:21 ` Kenichi Handa
2003-11-18 15:49   ` Ognyan Kulev
2003-11-24 23:55     ` Kenichi Handa
2003-11-26  7:16       ` Ognyan Kulev
2003-11-26  7:47         ` Kenichi Handa
2003-11-26  8:30           ` Ognyan Kulev
2003-11-26 13:17             ` Kenichi Handa
2003-11-26 14:08               ` Ognyan Kulev
2003-12-03  8:34               ` Kenichi Handa
2003-12-04 16:28                 ` Ognyan Kulev
2003-12-04 23:28                   ` Kenichi Handa
2003-12-31 15:06                     ` Ognyan Kulev
2003-12-31 15:54                       ` Eli Zaretskii
2004-01-05  4:20                         ` Kenichi Handa
2004-01-05  4:14                       ` Kenichi Handa
2004-01-06 12:03                         ` YAMAMOTO Mitsuharu
2004-01-07  0:25                           ` Kenichi Handa
2004-01-07  1:32                             ` YAMAMOTO Mitsuharu
2004-01-07 16:22                         ` Ognyan Kulev
2004-01-07 23:58                           ` Kenichi Handa
2004-01-09 16:10                             ` Ognyan Kulev
2004-01-13  4:07                               ` Kenichi Handa
2004-01-14 11:42                                 ` Ognyan Kulev
2004-01-14 12:10                                   ` Kenichi Handa
2004-01-17 19:31                                     ` Ognyan Kulev
2004-01-19  0:34                                       ` Kenichi Handa [this message]
2004-01-21  6:45                                         ` Ognyan Kulev
2004-01-21 10:52                                           ` Kenichi Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200401190034.JAA24455@etlken.m17n.org \
    --to=handa@m17n.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).