current CVS redisplay is fucked

current CVS redisplay is fucked

[Miles Bader]

There's an approx 2cm blank gap between the right fringe and the actual
edge of the frame.  It's reaaaal ugly...

[If you do C-x 3 to split the window vertically, it gets even wierder --
some windows have the huge blank gaps, some don't, some have them on
both sides.]

-Miles
-- 
`...the Soviet Union was sliding in to an economic collapse so comprehensive
 that in the end its factories produced not goods but bads: finished products
 less valuable than the raw materials they were made from.'  [The Economist]

Re: current CVS redisplay is fucked

[Miles Bader]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

The problem seems to be this change from yesterday:

   2002-08-27  Kenichi Handa  <handa@etl.go.jp>

           * xdisp.c (get_next_display_element): In unibyte case, don't use
           octal form for such eight-bit characters that can be converted to
           multibyte char.

I reverted the attached patch in my local tree, and the problem is gone.

-Miles



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: xdisp.c patch that causes display problems --]
[-- Type: text/x-patch, Size: 1370 bytes --]

Index: xdisp.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
retrieving revision 1.777
retrieving revision 1.778
diff -u -r1.777 -r1.778
--- xdisp.c	22 Aug 2002 16:52:56 -0000	1.777
+++ xdisp.c	27 Aug 2002 00:59:55 -0000	1.778
@@ -4258,14 +4258,22 @@
 	     the translation.  This could easily be changed but I
 	     don't believe that it is worth doing.
 
-	     Non-printable multibyte characters are also translated
-	     octal form.  */
-	  else if ((it->c < ' '
+	     If it->multibyte_p is nonzero, eight-bit characters and
+	     non-printable multibyte characters are also translated to
+	     octal form.
+
+	     If it->multibyte_p is zero, eight-bit characters that
+	     don't have corresponding multibyte char code are also
+	     translated to octal form.  */
+	  else if (((it->c < ' ' || it->c == 127)
 		    && (it->area != TEXT_AREA
 			|| (it->c != '\n' && it->c != '\t')))
-		   || (it->c >= 127
-		       && it->len == 1)
-		   || !CHAR_PRINTABLE_P (it->c))
+		   || (it->multibyte_p
+		       ? ((it->c >= 127
+			   && it->len == 1)
+			  || !CHAR_PRINTABLE_P (it->c))
+		       : (it->c >= 128
+			  && it->c == unibyte_char_to_multibyte (it->c))))
 	    {
 	      /* IT->c is a control character which must be displayed
 		 either as '\003' or as `^C' where the '\\' and '^'

[-- Attachment #3: Type: text/plain, Size: 40 bytes --]



-- 
We live, as we dream -- alone....

Re: current CVS redisplay is fucked

[Kenichi Handa]

In article <buobs7n6a85.fsf@mcspd15.ucom.lsi.nec.co.jp>, Miles Bader <miles@lsi.nec.co.jp> writes:

> There's an approx 2cm blank gap between the right fringe and the actual
> edge of the frame.  It's reaaaal ugly...

> [If you do C-x 3 to split the window vertically, it gets even wierder --
> some windows have the huge blank gaps, some don't, some have them on
> both sides.]

Ummm, I can't reproduce this bug.   Do you customize
something related to fringe?

> The problem seems to be this change from yesterday:

>    2002-08-27  Kenichi Handa  <handa@etl.go.jp>

>            * xdisp.c (get_next_display_element): In unibyte case, don't use
>            octal form for such eight-bit characters that can be converted to
>            multibyte char.

> I reverted the attached patch in my local tree, and the problem is gone.

I still can't find what's wrong with my patch.  Could you
please try this additional patch instead of reverting the
previous patch?

*** xdisp.c.~1.778.~	Tue Aug 27 09:57:55 2002
--- xdisp.c	Wed Aug 28 11:12:37 2002
***************
*** 4265,4278 ****
  	     If it->multibyte_p is zero, eight-bit characters that
  	     don't have corresponding multibyte char code are also
  	     translated to octal form.  */
! 	  else if (((it->c < ' ' || it->c == 127)
  		    && (it->area != TEXT_AREA
  			|| (it->c != '\n' && it->c != '\t')))
  		   || (it->multibyte_p
  		       ? ((it->c >= 127
  			   && it->len == 1)
  			  || !CHAR_PRINTABLE_P (it->c))
! 		       : (it->c >= 128
  			  && it->c == unibyte_char_to_multibyte (it->c))))
  	    {
  	      /* IT->c is a control character which must be displayed
--- 4265,4278 ----
  	     If it->multibyte_p is zero, eight-bit characters that
  	     don't have corresponding multibyte char code are also
  	     translated to octal form.  */
! 	  else if ((it->c < ' '
  		    && (it->area != TEXT_AREA
  			|| (it->c != '\n' && it->c != '\t')))
  		   || (it->multibyte_p
  		       ? ((it->c >= 127
  			   && it->len == 1)
  			  || !CHAR_PRINTABLE_P (it->c))
! 		       : (it->c >= 127
  			  && it->c == unibyte_char_to_multibyte (it->c))))
  	    {
  	      /* IT->c is a control character which must be displayed

---
Ken'ichi HANDA
handa@etl.go.jp

Re: current CVS redisplay is fucked

[Miles Bader]

Kenichi Handa <handa@etl.go.jp> writes:
> Ummm, I can't reproduce this bug.   Do you customize
> something related to fringe?

I first tried re-adding the patch I had reverted, just to make sure the
bug was still there -- and it wasn't!

Anyway, now it seems to work fine with the code out of CVS, I have no
idea why it was screwing up before.  Maybe a cosmic ray flipped the
wrong bit somewhere...

Sorry for the false alarm.

-Miles
-- 
Somebody has to do something, and it's just incredibly pathetic that it
has to be us.  -- Jerry Garcia

Re: current CVS redisplay is fucked

[Kim F. Storm]

Miles Bader <miles@lsi.nec.co.jp> writes:

> Kenichi Handa <handa@etl.go.jp> writes:
> > Ummm, I can't reproduce this bug.   Do you customize
> > something related to fringe?
> 
> I first tried re-adding the patch I had reverted, just to make sure the
> bug was still there -- and it wasn't!
> 
> Anyway, now it seems to work fine with the code out of CVS, I have no
> idea why it was screwing up before.  Maybe a cosmic ray flipped the
> wrong bit somewhere...
> 
> Sorry for the false alarm.

I saw the same thing yesterday.

Did you install my suggested "alternate-cursor-type" patch?

I found that uninstalling that patch and recompiling made the problem
disappear.

I not surprised if my patch doesn't work together with Richard's
changes from yesterday (blink-cursor-alist) as they are related to the
same areas of the code.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: current CVS redisplay is fucked

[Bill White]

On Tue Aug 27 2002 at 21:20, Kenichi Handa <handa@etl.go.jp> said:

> In article <buobs7n6a85.fsf@mcspd15.ucom.lsi.nec.co.jp>, Miles Bader <miles@lsi.nec.co.jp> writes:
>
>> There's an approx 2cm blank gap between the right fringe and the
>> actual edge of the frame.  It's reaaaal ugly...
>
>> [If you do C-x 3 to split the window vertically, it gets even
>> wierder -- some windows have the huge blank gaps, some don't, some
>> have them on both sides.]

Same here - cvs update Wednesday 28 Aug 2002, 10:05 GMT.  See
http://members.wri.com/billw/images/2002_08_28_062640_shot.jpg (218k)

Also, it seems the little pictures in the fringe are sometimes not
updated. See
http://members.wri.com/billw/images/2002_08_28_063147_shot.jpg (117k)

> Ummm, I can't reproduce this bug.  Do you customize something
> related to fringe?

There's nothing fringe-related in my .emacs or in my custom-file (I've
been happy with them & found nothing I wanted to customize).

bw
-- 
Bill White                                               Office: 5N-X30
Documentation Programmer                      Phone: 217-398-0700 x 234
Wolfram Research                                      Fax: 217-398-0747
http://members.wri.com/billw        Office hours: 4am-noon Mon-Wed, Fri

Re: current CVS redisplay is fucked

[Richard Stallman]

I saw the same problem with the fringe location.  Undoing your
last change made it go away.  Restoring your last change and
adding your new change also made it go away.

It seems quite strange that these changes affect the location of the
fringe, but they did.  I do not customize anything about the fringe.

Re: current CVS redisplay is fucked

[Kenichi Handa]

In article <E17kCIY-0000rl-00@fencepost.gnu.org>, Richard Stallman <rms@gnu.org> writes:
> I saw the same problem with the fringe location.  Undoing your
> last change made it go away.  Restoring your last change and
> adding your new change also made it go away.

And, Miles wrote that just undoing my change and restoring
it solved the problem.  Very strange.  Anyway, I'll install
that new change as soon as cvs locking problem is solved.

---
Ken'ichi HANDA
handa@etl.go.jp

Re: current CVS redisplay is fucked

[Kenichi Handa]

In article <200208290109.KAA02547@etlken.m17n.org>, Kenichi Handa <handa@etl.go.jp> writes:

> In article <E17kCIY-0000rl-00@fencepost.gnu.org>, Richard Stallman <rms@gnu.org> writes:
>>  I saw the same problem with the fringe location.  Undoing your
>>  last change made it go away.  Restoring your last change and
>>  adding your new change also made it go away.

> And, Miles wrote that just undoing my change and restoring
> it solved the problem.  Very strange.  Anyway, I'll install
> that new change as soon as cvs locking problem is solved.

Done.

---
Ken'ichi HANDA
handa@etl.go.jp