unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Miles Bader <miles@lsi.nec.co.jp>
Cc: emacs-pretest-bug@gnu.org
Subject: Re: current CVS redisplay is fucked
Date: 28 Aug 2002 10:30:34 +0900	[thread overview]
Message-ID: <buobs7n6a85.fsf@mcspd15.ucom.lsi.nec.co.jp> (raw)
In-Reply-To: <buoptw36bdp.fsf@mcspd15.ucom.lsi.nec.co.jp>

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

The problem seems to be this change from yesterday:

   2002-08-27  Kenichi Handa  <handa@etl.go.jp>

           * xdisp.c (get_next_display_element): In unibyte case, don't use
           octal form for such eight-bit characters that can be converted to
           multibyte char.

I reverted the attached patch in my local tree, and the problem is gone.

-Miles



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: xdisp.c patch that causes display problems --]
[-- Type: text/x-patch, Size: 1370 bytes --]

Index: xdisp.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
retrieving revision 1.777
retrieving revision 1.778
diff -u -r1.777 -r1.778
--- xdisp.c	22 Aug 2002 16:52:56 -0000	1.777
+++ xdisp.c	27 Aug 2002 00:59:55 -0000	1.778
@@ -4258,14 +4258,22 @@
 	     the translation.  This could easily be changed but I
 	     don't believe that it is worth doing.
 
-	     Non-printable multibyte characters are also translated
-	     octal form.  */
-	  else if ((it->c < ' '
+	     If it->multibyte_p is nonzero, eight-bit characters and
+	     non-printable multibyte characters are also translated to
+	     octal form.
+
+	     If it->multibyte_p is zero, eight-bit characters that
+	     don't have corresponding multibyte char code are also
+	     translated to octal form.  */
+	  else if (((it->c < ' ' || it->c == 127)
 		    && (it->area != TEXT_AREA
 			|| (it->c != '\n' && it->c != '\t')))
-		   || (it->c >= 127
-		       && it->len == 1)
-		   || !CHAR_PRINTABLE_P (it->c))
+		   || (it->multibyte_p
+		       ? ((it->c >= 127
+			   && it->len == 1)
+			  || !CHAR_PRINTABLE_P (it->c))
+		       : (it->c >= 128
+			  && it->c == unibyte_char_to_multibyte (it->c))))
 	    {
 	      /* IT->c is a control character which must be displayed
 		 either as '\003' or as `^C' where the '\\' and '^'

[-- Attachment #3: Type: text/plain, Size: 40 bytes --]



-- 
We live, as we dream -- alone....

  reply	other threads:[~2002-08-28  1:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-28  1:05 current CVS redisplay is fucked Miles Bader
2002-08-28  1:30 ` Miles Bader [this message]
2002-08-28  2:20   ` Kenichi Handa
2002-08-28  2:35     ` Miles Bader
2002-08-28  9:38       ` Kim F. Storm
2002-08-28 11:34     ` Bill White
2002-08-28 23:32     ` Richard Stallman
2002-08-29  1:09       ` Kenichi Handa
2002-08-30 13:46         ` Kenichi Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=buobs7n6a85.fsf@mcspd15.ucom.lsi.nec.co.jp \
    --to=miles@lsi.nec.co.jp \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).