Re: ange-ftp save-buffer bug in 21.2

Re: ange-ftp save-buffer bug in 21.2

[Richard Stallman]

The problem is evidently because of the following code in
ange-ftp-write-region.

		(let ((executing-kbd-macro t)
		      (filename (buffer-file-name))
		      (mod-p (buffer-modified-p)))
		  (unwind-protect
		      (progn
			(ange-ftp-real-write-region start end temp nil visit)
			(setq coding-system-used last-coding-system-used))

Does anyone see a purpose for binding executing-kbd-macro here?  The
code to bind it has been that way for a long, long time.

Re: ange-ftp save-buffer bug in 21.2

[Michael Sperber [Mr. Preprocessor]]

>>>>> "RMS" == Richard Stallman <rms@gnu.org> writes:

RMS> The problem is evidently because of the following code in
RMS> ange-ftp-write-region.

RMS> 		(let ((executing-kbd-macro t)
RMS> 		      (filename (buffer-file-name))
RMS> 		      (mod-p (buffer-modified-p)))
RMS> 		  (unwind-protect
RMS> 		      (progn
RMS> 			(ange-ftp-real-write-region start end temp nil visit)
RMS> 			(setq coding-system-used last-coding-system-used))

RMS> Does anyone see a purpose for binding executing-kbd-macro here?  The
RMS> code to bind it has been that way for a long, long time.

For what it's worth, here's the analogous section in EFS.  It has a
comment:

			  (let ((executing-macro t))
			    ;; let-bind executing-macro to inhibit messaging.
			    ;; Setting VISIT to 'quiet is more elegant.
			    ;; But in Emacs 18, doing it this way allows
			    ;; us to modify the visited file modtime, so
			    ;; that undo's show the buffer modified.

-- 
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla

Re: ange-ftp save-buffer bug in 21.2

[Richard Stallman]

Thanks for finding that.  It now seems that using (or visit 'quiet)
instead of just `visit' as the 5th argument to
ange-ftp-real-write-region is the best solution.