From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: sperber@informatik.uni-tuebingen.de (Michael Sperber [Mr. Preprocessor]) Newsgroups: gmane.emacs.devel Subject: Re: ange-ftp save-buffer bug in 21.2 Date: Fri, 12 Jul 2002 09:01:47 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: References: <200207101818.g6AIIND19276@video.paradise.lost> <200207111201.g6BC1Zc16964@aztec.santafe.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: main.gmane.org 1026457311 14748 127.0.0.1 (12 Jul 2002 07:01:51 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 12 Jul 2002 07:01:51 +0000 (UTC) Cc: jdhunter@ace.bsd.uchicago.edu, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17SuR4-0003pk-00 for ; Fri, 12 Jul 2002 09:01:50 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17Suaq-00010g-00 for ; Fri, 12 Jul 2002 09:11:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17SuRR-0001A9-00; Fri, 12 Jul 2002 03:02:13 -0400 Original-Received: from mx1.informatik.uni-tuebingen.de ([134.2.12.5]) by fencepost.gnu.org with smtp (Exim 3.35 #1 (Debian)) id 17SuR4-00019R-00; Fri, 12 Jul 2002 03:01:50 -0400 Original-Received: from sams.informatik.uni-tuebingen.de (sams [134.2.12.50]) by mx1.informatik.uni-tuebingen.de (Postfix) with ESMTP id 79D06439; Fri, 12 Jul 2002 09:01:48 +0200 (MST) Original-Received: from sams.informatik.uni-tuebingen.de (localhost [127.0.0.1]) by sams.informatik.uni-tuebingen.de (8.12.3/8.12.3) with ESMTP id g6C71leh030904; Fri, 12 Jul 2002 09:01:47 +0200 (CEST) (envelope-from sperber@sams.informatik.uni-tuebingen.de) Original-Received: (from sperber@localhost) by sams.informatik.uni-tuebingen.de (8.12.3/8.12.3/Submit) id g6C71lgk030901; Fri, 12 Jul 2002 09:01:47 +0200 (CEST) Original-To: rms@gnu.org In-Reply-To: <200207111201.g6BC1Zc16964@aztec.santafe.edu> (Richard Stallman's message of "Thu, 11 Jul 2002 06:01:35 -0600 (MDT)") Original-Lines: 29 User-Agent: Gnus/5.090006 (Oort Gnus v0.06) XEmacs/21.5 (bok choi, i386-unknown-freebsd4.5) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:5689 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:5689 >>>>> "RMS" == Richard Stallman writes: RMS> The problem is evidently because of the following code in RMS> ange-ftp-write-region. RMS> (let ((executing-kbd-macro t) RMS> (filename (buffer-file-name)) RMS> (mod-p (buffer-modified-p))) RMS> (unwind-protect RMS> (progn RMS> (ange-ftp-real-write-region start end temp nil visit) RMS> (setq coding-system-used last-coding-system-used)) RMS> Does anyone see a purpose for binding executing-kbd-macro here? The RMS> code to bind it has been that way for a long, long time. For what it's worth, here's the analogous section in EFS. It has a comment: (let ((executing-macro t)) ;; let-bind executing-macro to inhibit messaging. ;; Setting VISIT to 'quiet is more elegant. ;; But in Emacs 18, doing it this way allows ;; us to modify the visited file modtime, so ;; that undo's show the buffer modified. -- Cheers =8-} Mike Friede, Völkerverständigung und überhaupt blabla