* [ELPA] New package: vertico-posframe
@ 2021-10-25 3:06 tumashu
2021-10-25 16:13 ` Philip Kaludercic
0 siblings, 1 reply; 11+ messages in thread
From: tumashu @ 2021-10-25 3:06 UTC (permalink / raw)
To: emacs-devel@gnu.org
** What is vertico-posframe
vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.
** How to enable vertico-posframe
(require 'vertico-posframe)
(vertico-posframe-mode 1)
URL: https://github.com/tumashu/vertico-posframe
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ELPA] New package: vertico-posframe
2021-10-25 3:06 [ELPA] New package: vertico-posframe tumashu
@ 2021-10-25 16:13 ` Philip Kaludercic
2021-10-26 0:45 ` tumashu
0 siblings, 1 reply; 11+ messages in thread
From: Philip Kaludercic @ 2021-10-25 16:13 UTC (permalink / raw)
To: tumashu; +Cc: emacs-devel@gnu.org
tumashu <tumashu@163.com> writes:
> ** What is vertico-posframe
> vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
> NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.
>
> ** How to enable vertico-posframe
> (require 'vertico-posframe)
> (vertico-posframe-mode 1)
>
> URL: https://github.com/tumashu/vertico-posframe
Would it make sense to bundle this directly in Vertico?
--
Philip Kaludercic
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re:Re: [ELPA] New package: vertico-posframe
2021-10-25 16:13 ` Philip Kaludercic
@ 2021-10-26 0:45 ` tumashu
2021-10-26 7:25 ` Iñigo Serna
2021-10-26 9:12 ` Philip Kaludercic
0 siblings, 2 replies; 11+ messages in thread
From: tumashu @ 2021-10-26 0:45 UTC (permalink / raw)
To: Philip Kaludercic; +Cc: mail, emacs-devel@gnu.org
At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net> wrote:
>tumashu <tumashu@163.com> writes:
>
>> ** What is vertico-posframe
>> vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
>> NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.
>>
>> ** How to enable vertico-posframe
>> (require 'vertico-posframe)
>> (vertico-posframe-mode 1)
>>
>> URL: https://github.com/tumashu/vertico-posframe
>
>Would it make sense to bundle this directly in Vertico?
I think vertico prefer keep simple and less code, so we should see the opinion of Daniel Mendler
>
>--
> Philip Kaludercic
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ELPA] New package: vertico-posframe
2021-10-26 0:45 ` tumashu
@ 2021-10-26 7:25 ` Iñigo Serna
2021-10-26 7:35 ` Daniel Mendler
2021-10-26 9:12 ` Philip Kaludercic
1 sibling, 1 reply; 11+ messages in thread
From: Iñigo Serna @ 2021-10-26 7:25 UTC (permalink / raw)
To: tumashu; +Cc: mail, Philip Kaludercic, emacs-devel
Hi,
On 26 October 2021 at 02:45 +02, tumashu <tumashu@163.com> wrote:
> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net>
> wrote:
>>> ** What is vertico-posframe
>>
>>Would it make sense to bundle this directly in Vertico?
>
> I think vertico prefer keep simple and less code, so we should
> see the opinion of Daniel Mendler
It would also add an unneeded dependency of an extenal package not
used
by most vertico users.
Daniel prefered that these extensions be in their own packages and
keep
core clean.
--
Iñigo Serna
On 26 October 2021 at 02:45 +02, tumashu <tumashu@163.com> wrote:
> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net>
> wrote:
>>tumashu <tumashu@163.com> writes:
>>
>>> ** What is vertico-posframe
>>> vertico-posframe is an vertico extension, which lets vertico
>>> use posframe to show its candidate menu.
>>> NOTE: vertico-posframe requires Emacs 26 and do not support
>>> mouse click.
>>>
>>> ** How to enable vertico-posframe
>>> (require 'vertico-posframe)
>>> (vertico-posframe-mode 1)
>>>
>>> URL: https://github.com/tumashu/vertico-posframe
>>
>>Would it make sense to bundle this directly in Vertico?
>
> I think vertico prefer keep simple and less code, so we should
> see the opinion of Daniel Mendler
>
>>
>>--
>> Philip Kaludercic
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ELPA] New package: vertico-posframe
2021-10-26 7:25 ` Iñigo Serna
@ 2021-10-26 7:35 ` Daniel Mendler
2021-10-26 12:00 ` Stefan Monnier
0 siblings, 1 reply; 11+ messages in thread
From: Daniel Mendler @ 2021-10-26 7:35 UTC (permalink / raw)
To: Iñigo Serna, tumashu; +Cc: Philip Kaludercic, emacs-devel
On 10/26/21 9:25 AM, Iñigo Serna wrote:
> Hi,
>
> On 26 October 2021 at 02:45 +02, tumashu <tumashu@163.com> wrote:
>
>> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net>
>> wrote:
>>>> ** What is vertico-posframe
>>>
>>> Would it make sense to bundle this directly in Vertico?
>>
>> I think vertico prefer keep simple and less code, so we should
>> see the opinion of Daniel Mendler
>
> It would also add an unneeded dependency of an extenal package not
> used
> by most vertico users.
> Daniel prefered that these extensions be in their own packages and
> keep
> core clean.
Indeed, the packages should not be bundled together. vertico-posframe is
an independent component, which pulls in a third-party dependency.
Daniel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ELPA] New package: vertico-posframe
2021-10-26 0:45 ` tumashu
2021-10-26 7:25 ` Iñigo Serna
@ 2021-10-26 9:12 ` Philip Kaludercic
2021-10-27 18:00 ` Philip Kaludercic
1 sibling, 1 reply; 11+ messages in thread
From: Philip Kaludercic @ 2021-10-26 9:12 UTC (permalink / raw)
To: tumashu; +Cc: mail, emacs-devel@gnu.org
tumashu <tumashu@163.com> writes:
> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net> wrote:
>>tumashu <tumashu@163.com> writes:
>>
>>> ** What is vertico-posframe
>>> vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
>>> NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.
>>>
>>> ** How to enable vertico-posframe
>>> (require 'vertico-posframe)
>>> (vertico-posframe-mode 1)
>>>
>>> URL: https://github.com/tumashu/vertico-posframe
>>
>>Would it make sense to bundle this directly in Vertico?
>
> I think vertico prefer keep simple and less code, so we should see the opinion of Daniel Mendler
No problem, then it should be possible to add your package too. I will
look over the code later today to check if there is anything that might
be worth discussing.
--
Philip Kaludercic
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ELPA] New package: vertico-posframe
2021-10-26 7:35 ` Daniel Mendler
@ 2021-10-26 12:00 ` Stefan Monnier
2021-10-26 16:51 ` Philip Kaludercic
0 siblings, 1 reply; 11+ messages in thread
From: Stefan Monnier @ 2021-10-26 12:00 UTC (permalink / raw)
To: Daniel Mendler; +Cc: Iñigo Serna, tumashu, Philip Kaludercic, emacs-devel
> Indeed, the packages should not be bundled together. vertico-posframe is
> an independent component, which pulls in a third-party dependency.
I don't have an opinion on how those should be packaged, but I'll just
point out that Vertico would not needed to have `posframe` in its
`Package-Requires` in order to provide support for Posframe.
Stefan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ELPA] New package: vertico-posframe
2021-10-26 12:00 ` Stefan Monnier
@ 2021-10-26 16:51 ` Philip Kaludercic
2021-10-26 18:19 ` Stefan Monnier
0 siblings, 1 reply; 11+ messages in thread
From: Philip Kaludercic @ 2021-10-26 16:51 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Daniel Mendler, emacs-devel, Iñigo Serna, tumashu
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Indeed, the packages should not be bundled together. vertico-posframe is
>> an independent component, which pulls in a third-party dependency.
>
> I don't have an opinion on how those should be packaged, but I'll just
> point out that Vertico would not needed to have `posframe` in its
> `Package-Requires` in order to provide support for Posframe.
Yes, this was what I was thinking about. A soft dependency that would
raise an error of the posframe part were actually required, but would
otherwise ignore it.
But as Daniel has said he prefers not to do it this way, we can add
vertico-posframe as a separate package.
--
Philip Kaludercic
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ELPA] New package: vertico-posframe
2021-10-26 16:51 ` Philip Kaludercic
@ 2021-10-26 18:19 ` Stefan Monnier
0 siblings, 0 replies; 11+ messages in thread
From: Stefan Monnier @ 2021-10-26 18:19 UTC (permalink / raw)
To: Philip Kaludercic; +Cc: Daniel Mendler, Iñigo Serna, tumashu, emacs-devel
Philip Kaludercic [2021-10-26 16:51:10] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> Indeed, the packages should not be bundled together. vertico-posframe is
>>> an independent component, which pulls in a third-party dependency.
>>
>> I don't have an opinion on how those should be packaged, but I'll just
>> point out that Vertico would not needed to have `posframe` in its
>> `Package-Requires` in order to provide support for Posframe.
>
> Yes, this was what I was thinking about. A soft dependency that would
> raise an error of the posframe part were actually required, but would
> otherwise ignore it.
>
> But as Daniel has said he prefers not to do it this way, we can add
> vertico-posframe as a separate package.
Yes, either way is fine.
Stefan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ELPA] New package: vertico-posframe
2021-10-26 9:12 ` Philip Kaludercic
@ 2021-10-27 18:00 ` Philip Kaludercic
2021-10-28 9:12 ` tumashu
0 siblings, 1 reply; 11+ messages in thread
From: Philip Kaludercic @ 2021-10-27 18:00 UTC (permalink / raw)
To: tumashu; +Cc: mail, emacs-devel@gnu.org
Philip Kaludercic <philipk@posteo.net> writes:
> tumashu <tumashu@163.com> writes:
>
>> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net> wrote:
>>>tumashu <tumashu@163.com> writes:
>>>
>>>> ** What is vertico-posframe
>>>> vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
>>>> NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.
>>>>
>>>> ** How to enable vertico-posframe
>>>> (require 'vertico-posframe)
>>>> (vertico-posframe-mode 1)
>>>>
>>>> URL: https://github.com/tumashu/vertico-posframe
>>>
>>>Would it make sense to bundle this directly in Vertico?
>>
>> I think vertico prefer keep simple and less code, so we should see the opinion of Daniel Mendler
>
> No problem, then it should be possible to add your package too. I will
> look over the code later today to check if there is anything that might
> be worth discussing.
The package builds as expected so I'll add it with auto-syncing as there
haven't been any objections. I'd just question why you are requiring
cl-lib? It seems you aren't using it?
--
Philip Kaludercic
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re:Re: [ELPA] New package: vertico-posframe
2021-10-27 18:00 ` Philip Kaludercic
@ 2021-10-28 9:12 ` tumashu
0 siblings, 0 replies; 11+ messages in thread
From: tumashu @ 2021-10-28 9:12 UTC (permalink / raw)
To: Philip Kaludercic; +Cc: Daniel Mendler, emacs-devel@gnu.org
At 2021-10-28 02:00:23, "Philip Kaludercic" <philipk@posteo.net> wrote:
>Philip Kaludercic <philipk@posteo.net> writes:
>
>> tumashu <tumashu@163.com> writes:
>>
>>> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net> wrote:
>>>>tumashu <tumashu@163.com> writes:
>>>>
>>>>> ** What is vertico-posframe
>>>>> vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
>>>>> NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.
>>>>>
>>>>> ** How to enable vertico-posframe
>>>>> (require 'vertico-posframe)
>>>>> (vertico-posframe-mode 1)
>>>>>
>>>>> URL: https://github.com/tumashu/vertico-posframe
>>>>
>>>>Would it make sense to bundle this directly in Vertico?
>>>
>>> I think vertico prefer keep simple and less code, so we should see the opinion of Daniel Mendler
>>
>> No problem, then it should be possible to add your package too. I will
>> look over the code later today to check if there is anything that might
>> be worth discussing.
>
>The package builds as expected so I'll add it with auto-syncing as there
>haven't been any objections. I'd just question why you are requiring
>cl-lib? It seems you aren't using it?
Removed, thanks!
>
>--
> Philip Kaludercic
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-10-28 9:12 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 3:06 [ELPA] New package: vertico-posframe tumashu
2021-10-25 16:13 ` Philip Kaludercic
2021-10-26 0:45 ` tumashu
2021-10-26 7:25 ` Iñigo Serna
2021-10-26 7:35 ` Daniel Mendler
2021-10-26 12:00 ` Stefan Monnier
2021-10-26 16:51 ` Philip Kaludercic
2021-10-26 18:19 ` Stefan Monnier
2021-10-26 9:12 ` Philip Kaludercic
2021-10-27 18:00 ` Philip Kaludercic
2021-10-28 9:12 ` tumashu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).