* Re: master 6fd4ab250b: Revert "Improve X event timestamp tracking"
[not found] ` <20220807034757.EE76BC09BFD@vcs2.savannah.gnu.org>
@ 2022-08-07 7:46 ` Stefan Monnier
2022-08-07 12:52 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2022-08-07 7:46 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu via Mailing list for Emacs changes [2022-08-06 23:47:57] wrote:
> Revert "Improve X event timestamp tracking"
>
> This reverts commit 4b98a79a508ebdc719abfcf51ee6de32e46d0e1c.
>
> This change was installed without answering several important
> questions.
In order to keep the discussion heat down, it's best not to rush new
changes, nor to revert them. AFAIK there was no urgency here to revert
the change since it doesn't completely break normal use.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 6fd4ab250b: Revert "Improve X event timestamp tracking"
2022-08-07 7:46 ` master 6fd4ab250b: Revert "Improve X event timestamp tracking" Stefan Monnier
@ 2022-08-07 12:52 ` Lars Ingebrigtsen
2022-08-07 16:04 ` Daniel Colascione
0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-08-07 12:52 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Po Lu, emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> In order to keep the discussion heat down, it's best not to rush new
> changes, nor to revert them. AFAIK there was no urgency here to revert
> the change since it doesn't completely break normal use.
Indeed.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 6fd4ab250b: Revert "Improve X event timestamp tracking"
2022-08-07 12:52 ` Lars Ingebrigtsen
@ 2022-08-07 16:04 ` Daniel Colascione
2022-08-08 2:37 ` Po Lu
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Colascione @ 2022-08-07 16:04 UTC (permalink / raw)
To: Lars Ingebrigtsen, Stefan Monnier; +Cc: Po Lu, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
How about reinstalling the change while we continue discussion in the bug?
The change does, after all, fix a real user issue.
On August 7, 2022 08:53:45 Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> In order to keep the discussion heat down, it's best not to rush new
>> changes, nor to revert them. AFAIK there was no urgency here to revert
>> the change since it doesn't completely break normal use.
>
> Indeed.
[-- Attachment #2: Type: text/html, Size: 1261 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 6fd4ab250b: Revert "Improve X event timestamp tracking"
2022-08-07 16:04 ` Daniel Colascione
@ 2022-08-08 2:37 ` Po Lu
2022-08-08 11:31 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Po Lu @ 2022-08-08 2:37 UTC (permalink / raw)
To: Daniel Colascione; +Cc: Lars Ingebrigtsen, Stefan Monnier, emacs-devel
Daniel Colascione <dancol@dancol.org> writes:
> How about reinstalling the change while we continue discussion in the
> bug? The change does, after all, fix a real user issue.
How about installing mine? Since the discussion seems to have stopped?
It is always better to fix a user issue with less code compared to more.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 6fd4ab250b: Revert "Improve X event timestamp tracking"
2022-08-08 2:37 ` Po Lu
@ 2022-08-08 11:31 ` Lars Ingebrigtsen
0 siblings, 0 replies; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-08-08 11:31 UTC (permalink / raw)
To: Po Lu; +Cc: Daniel Colascione, Stefan Monnier, emacs-devel
Po Lu <luangruo@yahoo.com> writes:
>> How about reinstalling the change while we continue discussion in the
>> bug? The change does, after all, fix a real user issue.
>
> How about installing mine? Since the discussion seems to have stopped?
> It is always better to fix a user issue with less code compared to more.
I haven't taken the time to familiarise myself with what the actual
issue is -- I'm only saying that there's a controversial piece of code,
neither pushing it, or if that's already been done, reverting it, is the
right thing to do in a hurry.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-08 11:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <165984407752.16927.13675044548281916019@vcs2.savannah.gnu.org>
[not found] ` <20220807034757.EE76BC09BFD@vcs2.savannah.gnu.org>
2022-08-07 7:46 ` master 6fd4ab250b: Revert "Improve X event timestamp tracking" Stefan Monnier
2022-08-07 12:52 ` Lars Ingebrigtsen
2022-08-07 16:04 ` Daniel Colascione
2022-08-08 2:37 ` Po Lu
2022-08-08 11:31 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).