Current master does not work with sr-speedbar package (W64 build)

Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

Current Emacs master (f745cf8c438) does not work with the sr-speedbar package (https://github.com/emacsorphanage/sr-speedbar/blob/master/sr-speedbar.el) from MELPA.

Usually I have it configured so that Emacs opens in a single frame with 2 window: one for the text (80 characters in width showing the buffer text) and one for sr-speedbar (30 characters in width showing folders and files).

After the upgrade to the last Emacs master, the sr-speedbar window has the same width as before but it shows the buffer text... if I remove the desktop file, Emacs start with 2 window each containing the scratch buffer.

If, now, I allow for saving the desktop file, at the next start, I get 3 window (3 scratch buffers): one window 50 characters in width and 2 window 30 characters in width. At the next start, 4 window, about: 25, 30, 30, 30 and so on...

It seems I see this behavior only with the Windows build (MSYS2+MINGW64).

Ciao,
Angelo.

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> Date: Tue, 4 Dec 2018 18:50:51 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> 
> Current Emacs master (f745cf8c438) does not work with the sr-speedbar package (https://github.com/emacsorphanage/sr-speedbar/blob/master/sr-speedbar.el) from MELPA.
> 
> Usually I have it configured so that Emacs opens in a single frame with 2 window: one for the text (80 characters in width showing the buffer text) and one for sr-speedbar (30 characters in width showing folders and files).
> 
> After the upgrade to the last Emacs master, the sr-speedbar window has the same width as before but it shows the buffer text... if I remove the desktop file, Emacs start with 2 window each containing the scratch buffer.
> 
> If, now, I allow for saving the desktop file, at the next start, I get 3 window (3 scratch buffers): one window 50 characters in width and 2 window 30 characters in width. At the next start, 4 window, about: 25, 30, 30, 30 and so on...

Please show the way you configure Emacs for these windows.  My guess
is that you call functions that create windows while the selected
window is dedicated to its buffer, or something similar.

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 4 dicembre 2018 alle 18.57 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
> 
> > Date: Tue, 4 Dec 2018 18:50:51 +0100 (CET)
> > From: Angelo Graziosi <angelo.g0@libero.it>
> > 
> > Current Emacs master (f745cf8c438) does not work with the sr-speedbar package (https://github.com/emacsorphanage/sr-speedbar/blob/master/sr-speedbar.el) from MELPA.
> > 
> > Usually I have it configured so that Emacs opens in a single frame with 2 window: one for the text (80 characters in width showing the buffer text) and one for sr-speedbar (30 characters in width showing folders and files).
> > 
> > After the upgrade to the last Emacs master, the sr-speedbar window has the same width as before but it shows the buffer text... if I remove the desktop file, Emacs start with 2 window each containing the scratch buffer.
> > 
> > If, now, I allow for saving the desktop file, at the next start, I get 3 window (3 scratch buffers): one window 50 characters in width and 2 window 30 characters in width. At the next start, 4 window, about: 25, 30, 30, 30 and so on...
> 
> Please show the way you configure Emacs for these windows.  My guess
> is that you call functions that create windows while the selected
> window is dedicated to its buffer, or something similar.

This is the minimal init.el:

------------------------------------------------------------
$ cat init.el
(setq default-frame-alist
      '(
        (width . 110) ; character
        (height . 56) ; lines
        ))

;; Adds the MELPA repo to Emacs Packages
(when (>= emacs-major-version 24)
  (require 'package)
  (add-to-list
   'package-archives
   '("melpa" . "http://melpa.org/packages/")
   t)
  ;;(package-initialize)
  )


;; Sr-speedbar startup
(defun start-sr-speedbar ()
  "My customization for `sr-speedbar' startup."
  (interactive)

  ;; Start sr-speedbar at Emacs startup
  (sr-speedbar-open)

  ;; As suggested here:
  ;;
  ;;   http://lists.gnu.org/archive/html/bug-gnu-emacs/2017-07/msg01125.html
  ;;
  ;; (Really I had tried this solution but putting it in wrong place!)
  ;;
  (ad-deactivate 'pop-to-buffer)
  )

;; Start sr-speedbar, as suggested here:
;;
;;   http://lists.gnu.org/archive/html/bug-gnu-emacs/\
;;     2017-04/msg00569.html
;;
;;(add-hook 'emacs-startup-hook 'start-sr-speedbar) ; the old way
(add-hook 'window-setup-hook 'start-sr-speedbar)

;; Setup sr-speedbar
(setq sr-speedbar-default-width 30)
(setq sr-speedbar-width 30)
(setq sr-speedbar-max-width 30)
(setq sr-speedbar-auto-refresh t)

------------------------------------------------------------

I notice that with that init file, now Emacs starts with a double scratch buffer (one in text window and one in sr-speedbar window) and minibuffer contains "Opening directory: No such file or directory, c:/msys2/tmp/emacs-master/src/". Indeed I removed the directory: c:/msys2/tmp/emacs-master. It is the directory where the Emacs source is expanded (I use the emacs-master.tar.gz from git repo).

I notice also that Buffer menu contains *Compile-Log* buffer with the text:

Compiling no file at Wed Dec  5 00:20:12 2018

and *Messages* buffer has text:

For information about GNU Emacs and the GNU system, type C-h C-a.
‘sr-speedbar’ window has exist.
speedbar-file-lists: Opening directory: No such file or directory, c:/msys64/tmp/emacs-master/src/

Whwn I use the previous build (Oct 31) with the same init.el, Emacs starts with the *GNU Emacs* buffer (the same of Help - About Emacs menu) and the minibuffer contains "For information about[...]", as expected.

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> Date: Wed, 5 Dec 2018 00:31:19 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: emacs-devel@gnu.org, sebastian_rose@gmx.de, plunix@users.sourceforge.net,
> 	hong@topbug.net
> 
> ;; Sr-speedbar startup
> (defun start-sr-speedbar ()
>   "My customization for `sr-speedbar' startup."
>   (interactive)
> 
>   ;; Start sr-speedbar at Emacs startup
>   (sr-speedbar-open)
> 
>   ;; As suggested here:
>   ;;
>   ;;   http://lists.gnu.org/archive/html/bug-gnu-emacs/2017-07/msg01125.html
>   ;;
>   ;; (Really I had tried this solution but putting it in wrong place!)
>   ;;
>   (ad-deactivate 'pop-to-buffer)

Can you explain why you need the above ad-deactivate?

> ;;(add-hook 'emacs-startup-hook 'start-sr-speedbar) ; the old way
> (add-hook 'window-setup-hook 'start-sr-speedbar)

And why do you start sr-speedbar from window-setup-hook?

> I notice that with that init file, now Emacs starts with a double scratch buffer (one in text window and one in sr-speedbar window) and minibuffer contains "Opening directory: No such file or directory, c:/msys2/tmp/emacs-master/src/". Indeed I removed the directory: c:/msys2/tmp/emacs-master. It is the directory where the Emacs source is expanded (I use the emacs-master.tar.gz from git repo).

I think this is because the sr-speedbar window is a dedicated window,
so Emacs cannot switch to *scratch* in that window.  Removing
sr-speedbar invocation from window-setup-hook will probably fix that.

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 5 dicembre 2018 alle 19.34 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
> 
> > Date: Wed, 5 Dec 2018 00:31:19 +0100 (CET)
> > From: Angelo Graziosi <angelo.g0@libero.it>
> > Cc: emacs-devel@gnu.org, sebastian_rose@gmx.de, plunix@users.sourceforge.net,
> > 	hong@topbug.net
> > 
> > ;; Sr-speedbar startup
> > (defun start-sr-speedbar ()
> >   "My customization for `sr-speedbar' startup."
> >   (interactive)
> > 
> >   ;; Start sr-speedbar at Emacs startup
> >   (sr-speedbar-open)
> > 
> >   ;; As suggested here:
> >   ;;
> >   ;;   http://lists.gnu.org/archive/html/bug-gnu-emacs/2017-07/msg01125.html
> >   ;;
> >   ;; (Really I had tried this solution but putting it in wrong place!)
> >   ;;
> >   (ad-deactivate 'pop-to-buffer)
> 
> Can you explain why you need the above ad-deactivate?

Suggestion from this list (Martin..)... see the above commented out link...

> 
> > ;;(add-hook 'emacs-startup-hook 'start-sr-speedbar) ; the old way
> > (add-hook 'window-setup-hook 'start-sr-speedbar)
> 
> And why do you start sr-speedbar from window-setup-hook?

another suggestion from this list (Martin..)... see the above commented out link... oops the citation forgot it:

   http://lists.gnu.org/archive/html/bug-gnu-emacs/2017-04/msg00569.html

> > I notice that with that init file, now Emacs starts with a double scratch buffer (one in text window and one in sr-speedbar window) and minibuffer contains "Opening directory: No such file or directory, c:/msys2/tmp/emacs-master/src/". Indeed I removed the directory: c:/msys2/tmp/emacs-master. It is the directory where the Emacs source is expanded (I use the emacs-master.tar.gz from git repo).
> 
> I think this is because the sr-speedbar window is a dedicated window,
> so Emacs cannot switch to *scratch* in that window.  Removing
> sr-speedbar invocation from window-setup-hook will probably fix that.

How? May you suggest how should I start sr-speedbar?

Recent changes in Emacs have broken this...

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 5 dicembre 2018 alle 19.34 Eli Zaretskii <eliz@gnu.org> ha scritto:

> Can you explain why you need the above ad-deactivate?
> 
> > ;;(add-hook 'emacs-startup-hook 'start-sr-speedbar) ; the old way
> > (add-hook 'window-setup-hook 'start-sr-speedbar)
> 
> And why do you start sr-speedbar from window-setup-hook?

OK, I have renounced to start sr-speedbar with Emacs and created this simple init.el initialization file:

$ cat init.el
(require 'sr-speedbar)

;; Setup sr-speedbar
(setq sr-speedbar-default-width 30)
(setq sr-speedbar-width 30)
(setq sr-speedbar-max-width 30)
(setq sr-speedbar-auto-refresh t)

with it, Emacs starts with *GNU Emacs* buffer and minibuffer has "For information....", as it is expected...

...but if now I open the sr-speedbar window:

  M-x sr-speedbar-open

I get the same BAD behavior... and the minibuffer shows "Opening directory: No such file or directory, c:/msys64/tmp/emacs-master/src/"! 

WHY it refers to its build directory??? 

Why all this occurs with the Windows build? I have built the same emacs-master.tar.gz source on GNU/Linux and macOS and there all works fine. On these systems I use the same method to start sr-speedbar (almost the same init.el). I start to think my Windows build was corrupted in some manner.. I will try a new build just to see if this fixes this annoying issue.

Thanks,
 Angelo.

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 6 dicembre 2018 alle 0.07 Angelo Graziosi <angelo.g0@libero.it> ha scritto:
>
> I start to think my Windows build was corrupted in some manner.. I will try a new build just to see if this fixes this annoying issue.

Indeed the new build works as expected! So something went wrong in the previous build.. Sorry for the noise...

  Angelo

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 6 dicembre 2018 alle 1.07 Angelo Graziosi <angelo.g0@libero.it> ha scritto:
> 
> 
> 
> > Il 6 dicembre 2018 alle 0.07 Angelo Graziosi <angelo.g0@libero.it> ha scritto:
> >
> > I start to think my Windows build was corrupted in some manner.. I will try a new build just to see if this fixes this annoying issue.
> 
> Indeed the new build works as expected! So something went wrong in the previous build.. Sorry for the noise...

Spoken too soon.. when I remove the c:/msys64/tmp/emacs-master build tree the issues came back...

> 
>   Angelo

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 6 dicembre 2018 alle 1.12 Angelo Graziosi <angelo.g0@libero.it> ha scritto:
> 
> > > I start to think my Windows build was corrupted in some manner.. I will try a new build just to see if this fixes this annoying issue.
> > 
> > Indeed the new build works as expected! So something went wrong in the previous build.. Sorry for the noise...
> 
> Spoken too soon.. when I remove the c:/msys64/tmp/emacs-master build tree the issues came back...

I think the Windows build has defects which you do not see if you use Emacs from its build directory.

I build from emacs-master.tar.gz. After

cd emacs-master
./autogen.sh

./configure --prefix="/c/LocalApps/Emacs" \
         --build=x86_64-w64-mingw32 \
         --without-imagemagick \
         --without-dbus \
         --without-pop \
         --with-modules

make -j 3
make DESTDIR=/tmp/emacs-master/inst install

I create a tar-ball

cd /tmp/emacs-master/inst/c/LocalApps
tar -caf Emacs-bin.tar.gz Emacs

and install it as

tar -xvof Emacs-bin.tar.gz -C /c/LocalApps


I have uninstalled the sr-speedbar and tried to reinstall it, but this fails because Emacs tries to set permission to c:/msys64/tmp/src which, usually, does not exist. Some change in the last month caused this. Maybe , if I have time, I will try to bisect this to know when it occurred.

Good night,
 Angelo.

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> Date: Thu, 6 Dec 2018 00:07:27 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: hong@topbug.net, sebastian_rose@gmx.de, plunix@users.sourceforge.net,
> 	emacs-devel@gnu.org
> 
> OK, I have renounced to start sr-speedbar with Emacs and created this simple init.el initialization file:
> 
> $ cat init.el
> (require 'sr-speedbar)
> 
> ;; Setup sr-speedbar
> (setq sr-speedbar-default-width 30)
> (setq sr-speedbar-width 30)
> (setq sr-speedbar-max-width 30)
> (setq sr-speedbar-auto-refresh t)
> 
> with it, Emacs starts with *GNU Emacs* buffer and minibuffer has "For information....", as it is expected...
> 
> ...but if now I open the sr-speedbar window:
> 
>   M-x sr-speedbar-open
> 
> I get the same BAD behavior... and the minibuffer shows "Opening directory: No such file or directory, c:/msys64/tmp/emacs-master/src/"! 
> 
> WHY it refers to its build directory??? 

This sounds like sr-speedbar specific issue to me.

As to why Emacs complains about that directory, could you turn on
debug-on-error and show a Lisp backtrace from that error?

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> Date: Thu, 6 Dec 2018 01:54:50 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: emacs-devel@gnu.org, sebastian_rose@gmx.de, hong@topbug.net
> 
> I think the Windows build has defects which you do not see if you use Emacs from its build directory.

Could be.  But it also could be that the Windows-specific issue is in
sr-speedbar.  We won't know that until we understand the root cause of
the error message, so let's focus on that, okay?

> I build from emacs-master.tar.gz.

Where (in which local directory) do you unpack emacs-master.tar.gz?

> After
> 
> cd emacs-master
> ./autogen.sh
> 
> ./configure --prefix="/c/LocalApps/Emacs" \
>          --build=x86_64-w64-mingw32 \
>          --without-imagemagick \
>          --without-dbus \
>          --without-pop \
>          --with-modules
> 
> make -j 3
> make DESTDIR=/tmp/emacs-master/inst install
> 
> I create a tar-ball
> 
> cd /tmp/emacs-master/inst/c/LocalApps
> tar -caf Emacs-bin.tar.gz Emacs
> 
> and install it as
> 
> tar -xvof Emacs-bin.tar.gz -C /c/LocalApps

And then you delete the /tmp/emacs-master tree, is that right?

> I have uninstalled the sr-speedbar and tried to reinstall it, but this fails because Emacs tries to set permission to c:/msys64/tmp/src which, usually, does not exist. Some change in the last month caused this.

For this problem, please also produce a Lisp backtrace and post it.
It is very hard to try to analyze a problem without some minimal
details, and this is one of them.

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 6 dicembre 2018 alle 7.35 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
> This sounds like sr-speedbar specific issue to me.

No, I have another test cast to propose.

Build Emacs from master and install it in a different directory from the build one. Now remove the build folder or simply rename it. (As a normal user uses Emacs...)

Remove the .emacs.d folder, which for Windows build is located in AppData/Roaming (or rename it), i.e. start Emacs without any initialization file/folder.

Now start Emacs [*] and try to install an ELPA packages. After Options - Manage Emacs Packages, the minibuffer in Package buffer shows:

"error in process filter: Setting current directory: Permission denied, c:/msys64/tmp/emacs-master/src/"

where c:/msys64/tmp/emacs-master is the build tree of Emacs. Package buffer shows only built-in packages and Buffer menu contains also a *Compile-Log* buffer with the text 

^L
Compiling no file at Thu Dec  6 09:46:33 2018

Now, just create an empty build tree folder:

mkdir -p /tmp/emacs-master/src

All work as expected and after Options - Manage Emacs Packages, the Package buffer shows also ELPA Packages without error in minibuffer. For example, I installed in this way the auctex package....

As you see, no sr-speedbar is used at all.

---
[*] For example, in W10 from a link on the task bar whose target is C:\LocalAps\Emacs\bin\runemacs.exe in my case.

Re: Current master does not work with sr-speedbar package (W64 build)

[martin rudalics]

 > I have uninstalled the sr-speedbar and tried to reinstall it, but
 > this fails because Emacs tries to set permission to
 > c:/msys64/tmp/src which, usually, does not exist. Some change in the
 > last month caused this. Maybe , if I have time, I will try to bisect
 > this to know when it occurred.

Please do that bisection.  What was the last time (on master, I
suppose) this worked as you expected?

Thanks, martin

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> Date: Thu, 6 Dec 2018 10:00:29 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: sebastian_rose@gmx.de, emacs-devel@gnu.org, hong@topbug.net
> 
> Compiling no file at Thu Dec  6 09:46:33 2018

This sounds like bug#33602, which is not Windows-specific.

> As you see, no sr-speedbar is used at all.

OK, but a Lisp backtrace from an error message about non-existent
directory would still be useful.  Maybe it's part of the same problem
as the "no file" above, but I'm not yet sure it is.

Thanks.

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 6 dicembre 2018 alle 10.17 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
> 
> > Date: Thu, 6 Dec 2018 10:00:29 +0100 (CET)
> > From: Angelo Graziosi <angelo.g0@libero.it>
> > Cc: sebastian_rose@gmx.de, emacs-devel@gnu.org, hong@topbug.net
> > 
> > Compiling no file at Thu Dec  6 09:46:33 2018
> 
> This sounds like bug#33602, which is not Windows-specific.

I think we have two kind of bugs: I see the Compile-Log buffer also on macOS and GNU/Linux builds (20181204 froma master). But the error in Pakages buffer shows up only in the Windows build.

> 
> > As you see, no sr-speedbar is used at all.
> 
> OK, but a Lisp backtrace from an error message about non-existent
> directory would still be useful.  Maybe it's part of the same problem
> as the "no file" above, but I'm not yet sure it is.

Please, give me a recipe...

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

On December 6, 2018 1:28:13 PM GMT+02:00, Angelo Graziosi <angelo.g0@libero.it> wrote:
> 
> > Il 6 dicembre 2018 alle 10.17 Eli Zaretskii <eliz@gnu.org> ha
> scritto:
> > 
> > 
> > > Date: Thu, 6 Dec 2018 10:00:29 +0100 (CET)
> > > From: Angelo Graziosi <angelo.g0@libero.it>
> > > Cc: sebastian_rose@gmx.de, emacs-devel@gnu.org, hong@topbug.net
> > > 
> > > Compiling no file at Thu Dec  6 09:46:33 2018
> > 
> > This sounds like bug#33602, which is not Windows-specific.
> 
> I think we have two kind of bugs: I see the Compile-Log buffer also on
> macOS and GNU/Linux builds (20181204 froma master). But the error in
> Pakages buffer shows up only in the Windows build.
> 
> > 
> > > As you see, no sr-speedbar is used at all.
> > 
> > OK, but a Lisp backtrace from an error message about non-existent
> > directory would still be useful.  Maybe it's part of the same
> problem
> > as the "no file" above, but I'm not yet sure it is.
> 
> Please, give me a recipe...

Type "M-x set-variable RET debug-on-error RET t RET", then do the steps needed to trigger the problem.  Emacs should display a buffer with Lisp backtrace; post that here.

Thanks.

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 6 dicembre 2018 alle 10.10 martin rudalics <rudalics@gmx.at> ha scritto:
> 
> 
>  > I have uninstalled the sr-speedbar and tried to reinstall it, but
>  > this fails because Emacs tries to set permission to
>  > c:/msys64/tmp/src which, usually, does not exist. Some change in the
>  > last month caused this. Maybe , if I have time, I will try to bisect
>  > this to know when it occurred.
> 
> Please do that bisection.  What was the last time (on master, I
> suppose) this worked as you expected?

Just for the record, 

building http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-88762b4063a42a69234bda74b1626b646734715a.tar.gz, which should be a 20181118 master source, builds Emacs 26.90.1... as also confirms this: http://git.savannah.gnu.org/cgit/emacs.git/tree/README?id=88762b4063a42a69234bda74b1626b646734715a...

Is this to be expected?

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 6 dicembre 2018 alle 13.57 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
> Type "M-x set-variable RET debug-on-error RET t RET", then do the steps needed to trigger the problem.  Emacs should display a buffer with Lisp backtrace; post that here.
> 

Starting Emacs without initialization file/directory and with Options - Manage Emacs Packages.

Debugger entered--Lisp error: (file-error "Setting current directory" #("Permission denied" 0 17 (charset windows-1252)) "c:/msys64/tmp/emacs-master/src/")
  signal(file-error ("Setting current directory" #("Permission denied" 0 17 (charset windows-1252)) "c:/msys64/tmp/emacs-master/src/"))
  (if nil nil (signal (car err) (cdr err)))
  (condition-case err (progn (let* ((er (and t (plist-get status :error)))) (if er (error "Error retrieving: %s %S" url er))) (save-current-buffer (set-buffer b-sym) (goto-char (point-min)) (if (search-forward-regexp "^\15?\n\15?" nil 'noerror) nil (error "Error retrieving: %s %S" url "incomprehensible buffer"))) (url-insert-buffer-contents b-sym url) (kill-buffer b-sym) (goto-char (point-min)) t) (error (package--update-downloads-in-progress archive) (if nil nil (signal (car err) (cdr err)))))
  (if (condition-case err (progn (let* ((er (and t (plist-get status :error)))) (if er (error "Error retrieving: %s %S" url er))) (save-current-buffer (set-buffer b-sym) (goto-char (point-min)) (if (search-forward-regexp "^\15?\n\15?" nil 'noerror) nil (error "Error retrieving: %s %S" url "incomprehensible buffer"))) (url-insert-buffer-contents b-sym url) (kill-buffer b-sym) (goto-char (point-min)) t) (error (package--update-downloads-in-progress archive) (if nil nil (signal (car err) (cdr err))))) (progn (let* ((location (cdr archive)) (name (car archive)) (content (buffer-string)) (dir (expand-file-name (concat "archives/" name) package-user-dir)) (local-file (expand-file-name file dir))) (if (listp (read content)) (progn (make-directory dir t) (if (or (not package-check-signature) (memb
 er name package-unsigned-archives)) (progn (write-region content nil local-file nil ...) (package--update-downloads-in-progress archive)) (package--check-signature location file content async #'... #'...)))))))
  (progn (if (condition-case err (progn (let* ((er (and t ...))) (if er (error "Error retrieving: %s %S" url er))) (save-current-buffer (set-buffer b-sym) (goto-char (point-min)) (if (search-forward-regexp "^\15?\n\15?" nil 'noerror) nil (error "Error retrieving: %s %S" url "incomprehensible buffer"))) (url-insert-buffer-contents b-sym url) (kill-buffer b-sym) (goto-char (point-min)) t) (error (package--update-downloads-in-progress archive) (if nil nil (signal (car err) (cdr err))))) (progn (let* ((location (cdr archive)) (name (car archive)) (content (buffer-string)) (dir (expand-file-name (concat "archives/" name) package-user-dir)) (local-file (expand-file-name file dir))) (if (listp (read content)) (progn (make-directory dir t) (if (or ... ...) (progn ... ...) (package--check-signature
  location file content async ... ...))))))))
  (unwind-protect (progn (if (condition-case err (progn (let* ((er ...)) (if er (error "Error retrieving: %s %S" url er))) (save-current-buffer (set-buffer b-sym) (goto-char (point-min)) (if (search-forward-regexp "^\15?\n\15?" nil ...) nil (error "Error retrieving: %s %S" url "incomprehensible buffer"))) (url-insert-buffer-contents b-sym url) (kill-buffer b-sym) (goto-char (point-min)) t) (error (package--update-downloads-in-progress archive) (if nil nil (signal (car err) (cdr err))))) (progn (let* ((location (cdr archive)) (name (car archive)) (content (buffer-string)) (dir (expand-file-name ... package-user-dir)) (local-file (expand-file-name file dir))) (if (listp (read content)) (progn (make-directory dir t) (if ... ... ...))))))) (and (buffer-name temp-buffer) (kill-buffer temp-buffe
 r)))
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (if (condition-case err (progn (let* (...) (if er ...)) (save-current-buffer (set-buffer b-sym) (goto-char ...) (if ... nil ...)) (url-insert-buffer-contents b-sym url) (kill-buffer b-sym) (goto-char (point-min)) t) (error (package--update-downloads-in-progress archive) (if nil nil (signal ... ...)))) (progn (let* ((location ...) (name ...) (content ...) (dir ...) (local-file ...)) (if (listp ...) (progn ... ...)))))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))
  (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (if (condition-case err (progn (let* ... ...) (save-current-buffer ... ... ...) (url-insert-buffer-contents b-sym url) (kill-buffer b-sym) (goto-char ...) t) (error (package--update-downloads-in-progress archive) (if nil nil ...))) (progn (let* (... ... ... ... ...) (if ... ...))))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))))
  (let ((b-sym (current-buffer))) (require 'url-handlers) (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (if (condition-case err (progn ... ... ... ... ... t) (error ... ...)) (progn (let* ... ...)))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))))
  (closure ((temp-buffer . #<killed buffer>) (url . "https://elpa.gnu.org/packages/archive-contents") (url-1 . "https://elpa.gnu.org/packages/") (async . t) (file . "archive-contents") (archive "gnu" . "https://elpa.gnu.org/packages/") package-quickstart-file cl-struct-package--ac-desc-tags warning-minimum-level autoload-timestamps generated-autoload-file tar-parse-info Info-directory-list cl-struct-package--bi-desc-tags cl-struct-package-desc-tags t) (status) (let ((b-sym (current-buffer))) (require 'url-handlers) (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (if ... ...)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))))))((:peer (:certificates ((:version 3 :serial-number "03:e9:84:8e:54:a5:e0:73:ad:eb
 :85:06:03:50:c3:79:f2..." :issuer "C=US,O=Let's Encrypt,CN=Let's Encrypt Authority X3" :valid-from "2018-11-27" :valid-to "2019-02-25" :subject "CN=elpa.gnu.org" :public-key-algorithm "RSA" :certificate-security-level "Medium" :signature-algorithm "RSA-SHA256" :public-key-id "sha1:54:a6:1b:e5:6d:9f:62:a6:11:ec:90:83:af:3f:28:..." :certificate-id "sha1:a0:a4:2a:bc:a4:d3:e2:90:1b:e3:23:a6:8f:e3:85:...") (:version 3 :serial-number "0a:01:41:42:00:00:01:53:85:73:6a:0b:85:ec:a7:08" :issuer "O=Digital Signature Trust Co.,CN=DST Root CA X3" :valid-from "2016-03-17" :valid-to "2021-03-17" :subject "C=US,O=Let's Encrypt,CN=Let's Encrypt Authority X3" :public-key-algorithm "RSA" :certificate-security-level "Medium" :signature-algorithm "RSA-SHA256" :public-key-id "sha1:da:9b:52:a8:77:11:69:d3:13:1
 8:a5:67:e1:dc:9b:..." :certificate-id "sha1:e6:a3:b4:5b:06:2d:50:9b:33:82:28:2d:19:6e:fe:...")) :certificate (:version 3 :serial-number "03:e9:84:8e:54:a5:e0:73:ad:eb:85:06:03:50:c3:79:f2..." :issuer "C=US,O=Let's Encrypt,CN=Let's Encrypt Authority X3" :valid-from "2018-11-27" :valid-to "2019-02-25" :subject "CN=elpa.gnu.org" :public-key-algorithm "RSA" :certificate-security-level "Medium" :signature-algorithm "RSA-SHA256" :public-key-id "sha1:54:a6:1b:e5:6d:9f:62:a6:11:ec:90:83:af:3f:28:..." :certificate-id "sha1:a0:a4:2a:bc:a4:d3:e2:90:1b:e3:23:a6:8f:e3:85:...") :key-exchange "ECDHE-RSA" :protocol "TLS1.2" :cipher "AES-256-GCM" :mac "AEAD")))
  apply((closure ((temp-buffer . #<killed buffer>) (url . "https://elpa.gnu.org/packages/archive-contents") (url-1 . "https://elpa.gnu.org/packages/") (async . t) (file . "archive-contents") (archive "gnu" . "https://elpa.gnu.org/packages/") package-quickstart-file cl-struct-package--ac-desc-tags warning-minimum-level autoload-timestamps generated-autoload-file tar-parse-info Info-directory-list cl-struct-package--bi-desc-tags cl-struct-package-desc-tags t) (status) (let ((b-sym (current-buffer))) (require 'url-handlers) (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (if ... ...)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))))) (:peer (:certificates ((:version 3 :serial-number "03:e9:84:8e:54:a5:e0:73
 :ad:eb:85:06:03:50:c3:79:f2..." :issuer "C=US,O=Let's Encrypt,CN=Let's Encrypt Authority X3" :valid-from "2018-11-27" :valid-to "2019-02-25" :subject "CN=elpa.gnu.org" :public-key-algorithm "RSA" :certificate-security-level "Medium" :signature-algorithm "RSA-SHA256" :public-key-id "sha1:54:a6:1b:e5:6d:9f:62:a6:11:ec:90:83:af:3f:28:..." :certificate-id "sha1:a0:a4:2a:bc:a4:d3:e2:90:1b:e3:23:a6:8f:e3:85:...") (:version 3 :serial-number "0a:01:41:42:00:00:01:53:85:73:6a:0b:85:ec:a7:08" :issuer "O=Digital Signature Trust Co.,CN=DST Root CA X3" :valid-from "2016-03-17" :valid-to "2021-03-17" :subject "C=US,O=Let's Encrypt,CN=Let's Encrypt Authority X3" :public-key-algorithm "RSA" :certificate-security-level "Medium" :signature-algorithm "RSA-SHA256" :public-key-id "sha1:da:9b:52:a8:77:11:69:d
 3:13:18:a5:67:e1:dc:9b:..." :certificate-id "sha1:e6:a3:b4:5b:06:2d:50:9b:33:82:28:2d:19:6e:fe:...")) :certificate (:version 3 :serial-number "03:e9:84:8e:54:a5:e0:73:ad:eb:85:06:03:50:c3:79:f2..." :issuer "C=US,O=Let's Encrypt,CN=Let's Encrypt Authority X3" :valid-from "2018-11-27" :valid-to "2019-02-25" :subject "CN=elpa.gnu.org" :public-key-algorithm "RSA" :certificate-security-level "Medium" :signature-algorithm "RSA-SHA256" :public-key-id "sha1:54:a6:1b:e5:6d:9f:62:a6:11:ec:90:83:af:3f:28:..." :certificate-id "sha1:a0:a4:2a:bc:a4:d3:e2:90:1b:e3:23:a6:8f:e3:85:...") :key-exchange "ECDHE-RSA" :protocol "TLS1.2" :cipher "AES-256-GCM" :mac "AEAD")))
  url-http-activate-callback()
  url-http-content-length-after-change-function(37118 40106 2988)
  url-http-generic-filter(#<process elpa.gnu.org> "ypermedia\")\n       (:url . \"http://elpa.gnu.org/pa...")

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> Date: Thu, 6 Dec 2018 18:49:58 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: sebastian_rose@gmx.de, emacs-devel@gnu.org, hong@topbug.net
> 
> > Il 6 dicembre 2018 alle 13.57 Eli Zaretskii <eliz@gnu.org> ha scritto:
> > 
> > Type "M-x set-variable RET debug-on-error RET t RET", then do the steps needed to trigger the problem.  Emacs should display a buffer with Lisp backtrace; post that here.
> > 
> 
> Starting Emacs without initialization file/directory and with Options - Manage Emacs Packages.
> 
> Debugger entered--Lisp error: (file-error "Setting current directory" #("Permission denied" 0 17 (charset windows-1252)) "c:/msys64/tmp/emacs-master/src/")
>   signal(file-error ("Setting current directory" #("Permission denied" 0 17 (charset windows-1252)) "c:/msys64/tmp/emacs-master/src/"))
>   (if nil nil (signal (car err) (cdr err)))
>   (condition-case err (progn (let* ((er (and t (plist-get status :error)))) (if er (error "Error retrieving: %s %S" url er))) (save-current-buffer (set-buffer b-sym) (goto-char (point-min)) (if (search-forward-regexp "^\15?\n\15?" nil 'noerror) nil (error "Error retrieving: %s %S" url "incomprehensible buffer"))) (url-insert-buffer-contents b-sym url) (kill-buffer b-sym) (goto-char (point-min)) t) (error (package--update-downloads-in-progress archive) (if nil nil (signal (car err) (cdr err)))))

Thanks.

When you start Emacs without initialization file/directory, what is
the value of default-directory in the *scratch* buffer?

Re: Current master does not work with sr-speedbar package (W64 build)

[martin rudalics]

I can see that Compile-log buffer as well (I don't see it in Emacs
26.2).  It's caused by the (require 'package) in your init file.  What
happens when you remove the entire package/MELPA form and simply load
sr-speedbar.el locally?  When I do that with the rest of your
specifications, the frame comes up as expected with current master.

martin

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 6 dicembre 2018 alle 19.45 martin rudalics <rudalics@gmx.at> ha scritto:
> 
> 
> I can see that Compile-log buffer as well (I don't see it in Emacs
> 26.2).  It's caused by the (require 'package) in your init file.  What
> happens when you remove the entire package/MELPA form and simply load
> sr-speedbar.el locally?  When I do that with the rest of your
> specifications, the frame comes up as expected with current master.

I have proposed a test case without init file/folder.. See the other posts in thread.

Ciao,
 Angelo.

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 6 dicembre 2018 alle 19.20 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
> When you start Emacs without initialization file/directory, what is
> the value of default-directory in the *scratch* buffer?

C-x C-f in scratch says " c:/msys64/tmp/emacs-master/src/"..

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> Date: Thu, 6 Dec 2018 20:36:22 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: emacs-devel@gnu.org, hong@topbug.net
> 
> C-x C-f in scratch says " c:/msys64/tmp/emacs-master/src/"..

That sounds like the root cause of the problem, doesn't it?  Because
the c:/msys64/tmp/emacs-master/src directory doesn't exist, if I
understood correctly your build procedure: you have deleted that
directory by the time the Emacs executable is started.  Is that
correct or am I missing something?

If my understanding is indeed correct, then how come Emacs thinks its
current directory is a non-existing directory?  Are you invoking Emacs
by typing "emacs" or "runemacs" at the shell prompt, or by some other
way?

(And btw, is the leading SPC character at the beginning of
default-directory really part of the directory name?)

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 6 dicembre 2018 alle 20.47 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
> 
> > Date: Thu, 6 Dec 2018 20:36:22 +0100 (CET)
> > From: Angelo Graziosi <angelo.g0@libero.it>
> > Cc: emacs-devel@gnu.org, hong@topbug.net
> > 
> > C-x C-f in scratch says " c:/msys64/tmp/emacs-master/src/"..
> 
> That sounds like the root cause of the problem, doesn't it?  Because
> the c:/msys64/tmp/emacs-master/src directory doesn't exist, if I
> understood correctly your build procedure: you have deleted that
> directory by the time the Emacs executable is started.  Is that
> correct or am I missing something?

After the build, I create a tar-ball (a sort of binary package from 'make install') and install this (unpack it) so that

$ ls -lrt /c/LocalApps/Emacs/
totale 8
drwxr-xr-x 1 ... lib
drwxr-xr-x 1 ... share
drwxr-xr-x 1 ... include
drwxr-xr-x 1 ... libexec
drwxr-xr-x 1 ... bin

> If my understanding is indeed correct, then how come Emacs thinks its
> current directory is a non-existing directory?  Are you invoking Emacs
> by typing "emacs" or "runemacs" at the shell prompt, or by some other
> way?

I start Emacs from a link on the task bar. Its target is:

C:\LocalApps\Emacs\bin\runemacs.exe

> 
> (And btw, is the leading SPC character at the beginning of
> default-directory really part of the directory name?)

No, a copy/paste mistake...

BTW, in bisecting I have found that commit  

73ba6f16d1fe95d7535c8e20f19d11275b8356c4 (2018-11-12 09:38:27)   OK

works as expected (both without init file/folder and with my init file)

while commit

644a308b4e1513e04be9360e1586e14b32ec0159 (2018-11-16 08:30:20)  NOT OK

has the issues described in this thread.. There is still some work to do...

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 6 dicembre 2018 alle 21.45 Angelo Graziosi <angelo.g0@libero.it> ha scritto:
> 
> BTW, in bisecting I have found that commit  
> 
> 73ba6f16d1fe95d7535c8e20f19d11275b8356c4 (2018-11-12 09:38:27)   OK
> 
> works as expected (both without init file/folder and with my init file)
> 
> while commit
> 
> 644a308b4e1513e04be9360e1586e14b32ec0159 (2018-11-16 08:30:20)  NOT OK
> 
> has the issues described in this thread.. There is still some work to do...

I have find that the issue come from this commit:

Paul Eggert 900276502fbb4dcabdabc5d7d24b4bc5645f2cf3 (2018-11-13 09:32:50 -0800)
Act like POSIX sh if $HOME is relative

With the previous commit:

Stefan Monnier ce1fb157e840fd292c3db4632831c4514a663890 (2018-11-13 09:03:12 -0500)
lisp/files.el: Justify binding of read-circle with comments

Emacs works as expected.

Re: Current master does not work with sr-speedbar package (W64 build)

[Stefan Monnier]

>   (closure (...) (status) (let ((b-sym (current-buffer))) (require 'url-handlers) ...

This is weird: the above code seems clearly to come from package, but
you should be running code from package.elc instead (IOW the above code
is not byte-compiled whereas it should be).

It's probably unrelated to your problem, but it might be worthwhile to
investigate why that is.

Can you look at `load-history` to see if indeed `package.el` was loaded
instead of `package.elc` and if so, check from where it was loaded (is
it some extra copy you have lying around somewhere) and why there's no
.elc file next to it.


        Stefan

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> Date: Thu, 6 Dec 2018 21:45:15 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: rudalics@gmx.at, emacs-devel@gnu.org, hong@topbug.net
> 
> > > C-x C-f in scratch says " c:/msys64/tmp/emacs-master/src/"..
> > 
> > That sounds like the root cause of the problem, doesn't it?  Because
> > the c:/msys64/tmp/emacs-master/src directory doesn't exist, if I
> > understood correctly your build procedure: you have deleted that
> > directory by the time the Emacs executable is started.  Is that
> > correct or am I missing something?
> 
> After the build, I create a tar-ball (a sort of binary package from 'make install') and install this (unpack it) so that
> 
> $ ls -lrt /c/LocalApps/Emacs/
> totale 8
> drwxr-xr-x 1 ... lib
> drwxr-xr-x 1 ... share
> drwxr-xr-x 1 ... include
> drwxr-xr-x 1 ... libexec
> drwxr-xr-x 1 ... bin

And then you delete the build tree, in c:/msys64/tmp/emacs-master/,
right?

> I start Emacs from a link on the task bar. Its target is:
> 
> C:\LocalApps\Emacs\bin\runemacs.exe

Does that link have Properties which specify the directory in which to
start the executable?  If there is such a property, could it be that
the directory to start in is c:/msys64/tmp/emacs-master/src/, per
chance?

> I have find that the issue come from this commit:
> 
> Paul Eggert 900276502fbb4dcabdabc5d7d24b4bc5645f2cf3 (2018-11-13 09:32:50 -0800)
> Act like POSIX sh if $HOME is relative
> 
> With the previous commit:
> 
> Stefan Monnier ce1fb157e840fd292c3db4632831c4514a663890 (2018-11-13 09:03:12 -0500)
> lisp/files.el: Justify binding of read-circle with comments
> 
> Emacs works as expected.

Do you have HOME set to some value?  If so, what value?

Re: Current master does not work with sr-speedbar package (W64 build)

[martin rudalics]

 >>    (closure (...) (status) (let ((b-sym (current-buffer))) (require 'url-handlers) ...
 >
 > This is weird: the above code seems clearly to come from package, but
 > you should be running code from package.elc instead (IOW the above code
 > is not byte-compiled whereas it should be).
 >
 > It's probably unrelated to your problem, but it might be worthwhile to
 > investigate why that is.
 >
 > Can you look at `load-history` to see if indeed `package.el` was loaded
 > instead of `package.elc` and if so, check from where it was loaded (is
 > it some extra copy you have lying around somewhere) and why there's no
 > .elc file next to it.

Can you tell me how package.elc _could_ be loaded after you gave it the

;;\sno-byte-compile: t

directive?

martin

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> Date: Fri, 7 Dec 2018 00:55:57 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: rudalics@gmx.at, emacs-devel@gnu.org
> 
> I have find that the issue come from this commit:
> 
> Paul Eggert 900276502fbb4dcabdabc5d7d24b4bc5645f2cf3 (2018-11-13 09:32:50 -0800)
> Act like POSIX sh if $HOME is relative

Thanks, I think I see the problem and will have a solution shortly.

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 7 dicembre 2018 alle 7.22 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
> 
> > Date: Thu, 6 Dec 2018 21:45:15 +0100 (CET)
> > From: Angelo Graziosi <angelo.g0@libero.it>
> > Cc: rudalics@gmx.at, emacs-devel@gnu.org, hong@topbug.net
> > 
> > > > C-x C-f in scratch says " c:/msys64/tmp/emacs-master/src/"..
> > > 
> > > That sounds like the root cause of the problem, doesn't it?  Because
> > > the c:/msys64/tmp/emacs-master/src directory doesn't exist, if I
> > > understood correctly your build procedure: you have deleted that
> > > directory by the time the Emacs executable is started.  Is that
> > > correct or am I missing something?
> > 
> > After the build, I create a tar-ball (a sort of binary package from 'make install') and install this (unpack it) so that
> > 
> > $ ls -lrt /c/LocalApps/Emacs/
> > totale 8
> > drwxr-xr-x 1 ... lib
> > drwxr-xr-x 1 ... share
> > drwxr-xr-x 1 ... include
> > drwxr-xr-x 1 ... libexec
> > drwxr-xr-x 1 ... bin
> 
> And then you delete the build tree, in c:/msys64/tmp/emacs-master/,
> right?

yes,

rm -rf /tmp/emacs-master

in MSYS2 shell...

> 
> > I start Emacs from a link on the task bar. Its target is:
> > 
> > C:\LocalApps\Emacs\bin\runemacs.exe
> 
> Does that link have Properties which specify the directory in which to
> start the executable?  If there is such a property, could it be that
> the directory to start in is c:/msys64/tmp/emacs-master/src/, per
> chance?

No, it is:

From: C:\LocalApps\Emacs\bin

> 
> > I have find that the issue come from this commit:
> > 
> > Paul Eggert 900276502fbb4dcabdabc5d7d24b4bc5645f2cf3 (2018-11-13 09:32:50 -0800)
> > Act like POSIX sh if $HOME is relative
> > 
> > With the previous commit:
> > 
> > Stefan Monnier ce1fb157e840fd292c3db4632831c4514a663890 (2018-11-13 09:03:12 -0500)
> > lisp/files.el: Justify binding of read-circle with comments
> > 
> > Emacs works as expected.
> 
> Do you have HOME set to some value?  If so, what value?

No, it is the default: "...\AppData\Roaming"

Thanks.

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> Date: Fri, 07 Dec 2018 10:04:49 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: rudalics@gmx.at, emacs-devel@gnu.org
> 
> > Date: Fri, 7 Dec 2018 00:55:57 +0100 (CET)
> > From: Angelo Graziosi <angelo.g0@libero.it>
> > Cc: rudalics@gmx.at, emacs-devel@gnu.org
> > 
> > I have find that the issue come from this commit:
> > 
> > Paul Eggert 900276502fbb4dcabdabc5d7d24b4bc5645f2cf3 (2018-11-13 09:32:50 -0800)
> > Act like POSIX sh if $HOME is relative
> 
> Thanks, I think I see the problem and will have a solution shortly.

Should be fixed now, please try.

Re: Current master does not work with sr-speedbar package (W64 build)

[Stefan Monnier]

> Can you tell me how package.elc _could_ be loaded after you gave it the
>
> ;;\sno-byte-compile: t
>
> directive?

There is not supposed to be such a directive.  At least here package.el
does get compiled.  Maybe it's a bug we fixed already?


        Stefan

Re: Current master does not work with sr-speedbar package (W64 build)

[martin rudalics]

 >> Can you tell me how package.elc _could_ be loaded after you gave it the
 >>
 >> ;;\sno-byte-compile: t
 >>
 >> directive?
 >
 > There is not supposed to be such a directive.  At least here package.el
 > does get compiled.  Maybe it's a bug we fixed already?

Not here.  When I remove the offending line it gets compiled.  So you
probably should invent something more sophisticated ;-)

martin

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Date: Fri, 07 Dec 2018 08:00:48 -0500
> Cc: emacs-devel@gnu.org
> 
> > Can you tell me how package.elc _could_ be loaded after you gave it the
> >
> > ;;\sno-byte-compile: t
> >
> > directive?
> 
> There is not supposed to be such a directive.  At least here package.el
> does get compiled.  Maybe it's a bug we fixed already?

No, the current master still has it in the Local Variables section.

Re: Current master does not work with sr-speedbar package (W64 build)

[Stefan Monnier]

> Not here.  When I remove the offending line it gets compiled.  So you
> probably should invent something more sophisticated ;-)

Hmm... I must be missing something:

    emacs-26-0% rm lisp/emacs-lisp/package.elc; make |& grep ELC
      ELC      emacs-lisp/package.elc
    emacs-26-0%

this is with a vanilla checkout of the `emacs-26` branch.

Can you show me the patch corresponding to "remove the offending line"?


        Stefan

Re: Current master does not work with sr-speedbar package (W64 build)

[martin rudalics]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

 >> Not here.  When I remove the offending line it gets compiled.  So you
 >> probably should invent something more sophisticated ;-)
 >
 > Hmm... I must be missing something:
 >
 >      emacs-26-0% rm lisp/emacs-lisp/package.elc; make |& grep ELC
 >        ELC      emacs-lisp/package.elc
 >      emacs-26-0%
 >
 > this is with a vanilla checkout of the `emacs-26` branch.
 >
 > Can you show me the patch corresponding to "remove the offending line"?

The offending line is not in the Local Variables section but in the
'insert' call of 'package-quickstart-refresh'.

       (insert "\f
;; Local\sVariables:
;; version-control: never
;;\sno-byte-compile: t
;; no-update-autoloads: t
;; End:
"))))

The corresponding Makefile.in condition is

grep '^;.*no-byte-compile: t'

so I see no way that it would byte-compile this.

I attach I patch that fixes this here.

martin

[-- Attachment #2: package.diff --]
[-- Type: text/plain, Size: 496 bytes --]

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index dcede1a..e91001e 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -3570,9 +3570,7 @@ package-quickstart-refresh
       ;; mistaken for an actual file-local section of package.el.
       (insert "\f
 ;; Local\sVariables:
-;; version-control: never
-;;\sno-byte-compile: t
-;; no-update-autoloads: t
+;; version-control: never\n;;\sno-byte-compile: t\n;; no-update-autoloads: t
 ;; End:
 "))))
 

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Fri, 07 Dec 2018 08:26:40 -0500
> 
> > Not here.  When I remove the offending line it gets compiled.  So you
> > probably should invent something more sophisticated ;-)
> 
> Hmm... I must be missing something:
> 
>     emacs-26-0% rm lisp/emacs-lisp/package.elc; make |& grep ELC
>       ELC      emacs-lisp/package.elc
>     emacs-26-0%
> 
> this is with a vanilla checkout of the `emacs-26` branch.

You should look on master, not on emacs-26.

Re: Current master does not work with sr-speedbar package (W64 build)

[Angelo Graziosi]

> Il 7 dicembre 2018 alle 9.57 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
> 
> > Date: Fri, 07 Dec 2018 10:04:49 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: rudalics@gmx.at, emacs-devel@gnu.org
> > 
> > > Date: Fri, 7 Dec 2018 00:55:57 +0100 (CET)
> > > From: Angelo Graziosi <angelo.g0@libero.it>
> > > Cc: rudalics@gmx.at, emacs-devel@gnu.org
> > > 
> > > I have find that the issue come from this commit:
> > > 
> > > Paul Eggert 900276502fbb4dcabdabc5d7d24b4bc5645f2cf3 (2018-11-13 09:32:50 -0800)
> > > Act like POSIX sh if $HOME is relative
> > 
> > Thanks, I think I see the problem and will have a solution shortly.
> 
> Should be fixed now, please try.

Yes, it is fixed but for the sake of completeness when Emacs starts there is still a Compile-Log buffer (maybe the discussion between Martin and Stefan). This happens also on macOS and GNU/Linux.

Thanks,
 Angelo.

Re: Current master does not work with sr-speedbar package (W64 build)

[Eli Zaretskii]

> Date: Fri, 7 Dec 2018 17:34:40 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: rudalics@gmx.at, emacs-devel@gnu.org
> 
> > Should be fixed now, please try.
> 
> Yes, it is fixed

Thanks for testing.

> but for the sake of completeness when Emacs starts there is still a Compile-Log buffer (maybe the discussion between Martin and Stefan). This happens also on macOS and GNU/Linux.

That's a separate problem, as I mentioned earlier.

Re: Current master does not work with sr-speedbar package (W64 build)

[Stefan Monnier]

>       (insert "\f
> ;; Local\sVariables:
> ;; version-control: never
> ;;\sno-byte-compile: t
> ;; no-update-autoloads: t
> ;; End:
> "))))

Thanks.  I tweaked the Makefile.in regexp not to fall into this trap.


        Stefan