From: "Lennart Borgman" <lennart.borgman.073@student.lu.se>
Cc: hunterd42@comcast.net, emacs-devel@gnu.org,
kobayays@otsukakj.co.jp, jasonr@gnu.org
Subject: Re: Hourglass only for X-windows?
Date: Sat, 12 Mar 2005 02:03:45 +0100 [thread overview]
Message-ID: <010601c5269f$660e83d0$0200a8c0@sedrcw11488> (raw)
In-Reply-To: 01c5267c$Blat.v2.4$37bc1380@zahav.net.il
----- Original Message -----
From: "Eli Zaretskii" <eliz@gnu.org>
> I don't see how this is more readable. One cannot understand the
> meaning of HAVE_HOURGLASS without grepping thru lots of places.
Hm ;-)
There is something I do not understand in your argument. How about
HAVE_MOUSE, HAVE_SOUND? They seem possible to grasp to me - and they are
used in Emacs.
> We already have pieces of code that are conditioned similarly, e.g.:
>
> #if defined (USE_X_TOOLKIT) || defined (HAVE_NTGUI)
>
> So this is clearly an accepted practice in Emacs.
I find it very hard to guess what this define is for without reading the
code. Using names like HAVE_MOUSE, HAVE_HOURGLASS makes it much more easy to
guess IMO. And I think that is important if you are scanning the code
quickly trying to find things, see the structure etc. It may of course
depend on how you are thinking, but for me this makes sense. I would guess
it makes sense for a lot of other people too (but I am of course not sure.)
next prev parent reply other threads:[~2005-03-12 1:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-27 17:57 Hourglass only for X-windows? Lennart Borgman
2005-02-27 20:29 ` Eli Zaretskii
2005-02-28 0:20 ` Lennart Borgman
2005-02-28 4:38 ` Eli Zaretskii
2005-02-28 15:57 ` Lennart Borgman
2005-02-28 23:05 ` Eli Zaretskii
2005-03-01 0:17 ` Lennart Borgman
2005-03-10 23:33 ` Lennart Borgman
2005-03-11 13:28 ` Eli Zaretskii
2005-03-11 13:44 ` Jason Rumney
2005-03-11 15:51 ` Eli Zaretskii
2005-03-11 16:03 ` Lennart Borgman
2005-03-11 16:15 ` Eli Zaretskii
2005-03-11 16:43 ` Lennart Borgman
2005-03-11 17:25 ` Jan D.
2005-03-11 18:42 ` Lennart Borgman
2005-03-11 20:51 ` Eli Zaretskii
2005-03-12 1:03 ` Lennart Borgman [this message]
2005-03-12 2:11 ` Jason Rumney
2005-03-12 9:37 ` Lennart Borgman
2005-03-12 11:43 ` Jan D.
2005-03-12 13:41 ` Stefan Monnier
2005-03-12 15:41 ` Jason Rumney
2005-03-13 3:50 ` David Hunter
2005-03-14 11:28 ` YAMAMOTO Mitsuharu
2005-03-13 15:29 ` Richard Stallman
2005-03-12 10:01 ` Eli Zaretskii
2005-03-12 21:40 ` Lennart Borgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='010601c5269f$660e83d0$0200a8c0@sedrcw11488' \
--to=lennart.borgman.073@student.lu.se \
--cc=emacs-devel@gnu.org \
--cc=hunterd42@comcast.net \
--cc=jasonr@gnu.org \
--cc=kobayays@otsukakj.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).