From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman" Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Sat, 12 Mar 2005 02:03:45 +0100 Message-ID: <010601c5269f$660e83d0$0200a8c0@sedrcw11488> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> <01c5263e$Blat.v2.4$65b1b4e0@zahav.net.il> <4231A0BE.1070704@gnu.org> <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> <01c52655$Blat.v2.4$b47b9200@zahav.net.il> <00ee01c52659$a01c9620$0200a8c0@sedrcw11488> <534dd629871884654f6c43846c34db9a@swipnet.se> <00f501c5266a$1bf72de0$0200a8c0@sedrcw11488> <01c5267c$Blat.v2.4$37bc1380@zahav.net.il> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1110591419 12547 80.91.229.2 (12 Mar 2005 01:36:59 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 12 Mar 2005 01:36:59 +0000 (UTC) Cc: hunterd42@comcast.net, emacs-devel@gnu.org, kobayays@otsukakj.co.jp, jasonr@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 12 02:36:58 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D9vYj-0006jM-5Q for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2005 02:36:53 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9vns-0001Kc-H0 for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 20:52:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D9vLR-0006mq-FB for emacs-devel@gnu.org; Fri, 11 Mar 2005 20:23:10 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D9vLN-0006ku-KS for emacs-devel@gnu.org; Fri, 11 Mar 2005 20:23:06 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9vLN-0006jD-40 for emacs-devel@gnu.org; Fri, 11 Mar 2005 20:23:05 -0500 Original-Received: from [81.228.11.115] (helo=av9-1-sn1.fre.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D9v3X-0005o0-QJ; Fri, 11 Mar 2005 20:04:40 -0500 Original-Received: by av9-1-sn1.fre.skanova.net (Postfix, from userid 502) id 4CADB37E46; Sat, 12 Mar 2005 02:04:38 +0100 (CET) Original-Received: from smtp3-1-sn1.fre.skanova.net (smtp3-1-sn1.fre.skanova.net [81.228.11.163]) by av9-1-sn1.fre.skanova.net (Postfix) with ESMTP id 3BBF637E45; Sat, 12 Mar 2005 02:04:38 +0100 (CET) Original-Received: from sedrcw11488 (t5o58p108.telia.com [195.67.196.108]) by smtp3-1-sn1.fre.skanova.net (Postfix) with SMTP id B02E737E42; Sat, 12 Mar 2005 02:04:35 +0100 (CET) Original-To: "Eli Zaretskii" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1409 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34499 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34499 ----- Original Message ----- From: "Eli Zaretskii" > I don't see how this is more readable. One cannot understand the > meaning of HAVE_HOURGLASS without grepping thru lots of places. Hm ;-) There is something I do not understand in your argument. How about HAVE_MOUSE, HAVE_SOUND? They seem possible to grasp to me - and they are used in Emacs. > We already have pieces of code that are conditioned similarly, e.g.: > > #if defined (USE_X_TOOLKIT) || defined (HAVE_NTGUI) > > So this is clearly an accepted practice in Emacs. I find it very hard to guess what this define is for without reading the code. Using names like HAVE_MOUSE, HAVE_HOURGLASS makes it much more easy to guess IMO. And I think that is important if you are scanning the code quickly trying to find things, see the structure etc. It may of course depend on how you are thinking, but for me this makes sense. I would guess it makes sense for a lot of other people too (but I am of course not sure.)