unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Lennart Borgman" <lennart.borgman.073@student.lu.se>
Cc: hunterd42@comcast.net, kobayays@otsukakj.co.jp, emacs-devel@gnu.org
Subject: Re: Hourglass only for X-windows?
Date: Fri, 11 Mar 2005 17:03:28 +0100	[thread overview]
Message-ID: <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> (raw)
In-Reply-To: 4231A0BE.1070704@gnu.org

----- Original Message ----- 
From: "Jason Rumney" <jasonr@gnu.org>

> >>I have implemented code for hourglass on w32 now (or rather I should say
> >>Dave Hunter has done it, I just did a small amount of typing). Could we
> >>please get a decision on the issue above so that it is possible to get
this
> >>working with the CVS code? (The hourglass code in keyboard.c is
currently
> >>only called if HAVE_X_WINDOWS is defined.)
> >>
> >>
> >
> >I suggest adding WINDOWSNT to HAVE_X_WINDOWS in the condition for
> >calling the hourglass code.  Would that resolve the issue?
> >
> >
>
> HAVE_NTGUI is better than WINDOWSNT here, I think.

I think it would be much more readable if we had a special define. This was
my suggestion earlier:

> I suggest removing the "#ifdef HAVE_X_WINDOWS" completely or (which I
> believe most would like better - but not I) replacing them with something
> like
>
>     #ifdef HAS_HOURGLASS

In the light of your answers I do not believe you want to remove these
ifdefs so I suggest now we do something like:

   #if HAVE_HOURGLASS

I do not know where to put this definition however, "hourglass" is found in
the following files:

dispextern-jan.h
dispextern.h
macterm.h
msdos.h
w32term.h
xterm.h
eval.c
fns.c
keyboard-jan.c
keyboard.c
lread.c
macfns.c
macterm.c
minibuf.c
w32fns.c
xdisp.c
xfns-jan.c
xfns.c
xterm.c

Should it go into some header file or into the makefiles?

  parent reply	other threads:[~2005-03-11 16:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-27 17:57 Hourglass only for X-windows? Lennart Borgman
2005-02-27 20:29 ` Eli Zaretskii
2005-02-28  0:20   ` Lennart Borgman
2005-02-28  4:38     ` Eli Zaretskii
2005-02-28 15:57       ` Lennart Borgman
2005-02-28 23:05         ` Eli Zaretskii
2005-03-01  0:17           ` Lennart Borgman
2005-03-10 23:33             ` Lennart Borgman
2005-03-11 13:28               ` Eli Zaretskii
2005-03-11 13:44                 ` Jason Rumney
2005-03-11 15:51                   ` Eli Zaretskii
2005-03-11 16:03                   ` Lennart Borgman [this message]
2005-03-11 16:15                     ` Eli Zaretskii
2005-03-11 16:43                       ` Lennart Borgman
2005-03-11 17:25                         ` Jan D.
2005-03-11 18:42                           ` Lennart Borgman
2005-03-11 20:51                             ` Eli Zaretskii
2005-03-12  1:03                               ` Lennart Borgman
2005-03-12  2:11                                 ` Jason Rumney
2005-03-12  9:37                                   ` Lennart Borgman
2005-03-12 11:43                                     ` Jan D.
2005-03-12 13:41                                   ` Stefan Monnier
2005-03-12 15:41                                     ` Jason Rumney
2005-03-13  3:50                                       ` David Hunter
2005-03-14 11:28                                         ` YAMAMOTO Mitsuharu
2005-03-13 15:29                                     ` Richard Stallman
2005-03-12 10:01                                 ` Eli Zaretskii
2005-03-12 21:40                                   ` Lennart Borgman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488' \
    --to=lennart.borgman.073@student.lu.se \
    --cc=emacs-devel@gnu.org \
    --cc=hunterd42@comcast.net \
    --cc=kobayays@otsukakj.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).