From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman" Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Fri, 11 Mar 2005 17:03:28 +0100 Message-ID: <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> <01c5263e$Blat.v2.4$65b1b4e0@zahav.net.il> <4231A0BE.1070704@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1110558192 5659 80.91.229.2 (11 Mar 2005 16:23:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 11 Mar 2005 16:23:12 +0000 (UTC) Cc: hunterd42@comcast.net, kobayays@otsukakj.co.jp, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 11 17:23:12 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D9mo5-0006Sx-Qy for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 17:16:11 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9n3C-0007GQ-Ao for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 11:31:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D9mvt-0006Cf-Rq for emacs-devel@gnu.org; Fri, 11 Mar 2005 11:24:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D9mvf-00068m-9A for emacs-devel@gnu.org; Fri, 11 Mar 2005 11:24:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9mvf-00063x-1i for emacs-devel@gnu.org; Fri, 11 Mar 2005 11:23:59 -0500 Original-Received: from [81.228.11.108] (helo=av1-2-sn1.fre.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D9mcu-0001AZ-OQ; Fri, 11 Mar 2005 11:04:37 -0500 Original-Received: by av1-2-sn1.fre.skanova.net (Postfix, from userid 502) id EEF0237E68; Fri, 11 Mar 2005 17:04:33 +0100 (CET) Original-Received: from smtp3-1-sn1.fre.skanova.net (smtp3-1-sn1.fre.skanova.net [81.228.11.163]) by av1-2-sn1.fre.skanova.net (Postfix) with ESMTP id 09CD137E4B; Fri, 11 Mar 2005 17:04:33 +0100 (CET) Original-Received: from sedrcw11488 (t5o58p129.telia.com [195.67.196.129]) by smtp3-1-sn1.fre.skanova.net (Postfix) with SMTP id 5593937E58; Fri, 11 Mar 2005 17:04:30 +0100 (CET) Original-To: "Jason Rumney" , "Eli Zaretskii" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1409 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34479 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34479 ----- Original Message ----- From: "Jason Rumney" > >>I have implemented code for hourglass on w32 now (or rather I should say > >>Dave Hunter has done it, I just did a small amount of typing). Could we > >>please get a decision on the issue above so that it is possible to get this > >>working with the CVS code? (The hourglass code in keyboard.c is currently > >>only called if HAVE_X_WINDOWS is defined.) > >> > >> > > > >I suggest adding WINDOWSNT to HAVE_X_WINDOWS in the condition for > >calling the hourglass code. Would that resolve the issue? > > > > > > HAVE_NTGUI is better than WINDOWSNT here, I think. I think it would be much more readable if we had a special define. This was my suggestion earlier: > I suggest removing the "#ifdef HAVE_X_WINDOWS" completely or (which I > believe most would like better - but not I) replacing them with something > like > > #ifdef HAS_HOURGLASS In the light of your answers I do not believe you want to remove these ifdefs so I suggest now we do something like: #if HAVE_HOURGLASS I do not know where to put this definition however, "hourglass" is found in the following files: dispextern-jan.h dispextern.h macterm.h msdos.h w32term.h xterm.h eval.c fns.c keyboard-jan.c keyboard.c lread.c macfns.c macterm.c minibuf.c w32fns.c xdisp.c xfns-jan.c xfns.c xterm.c Should it go into some header file or into the makefiles?