From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 45328@debbugs.gnu.org
Subject: bug#45328: 28.0.50; [PATCH] Compare raw syntax descriptors with equal in `python-indent-region'
Date: Sun, 21 Mar 2021 21:19:33 +0000 [thread overview]
Message-ID: <xjfh7l4ryqi.fsf@sdf.org> (raw)
In-Reply-To: <CADwFkmn4JNdWQUU02xqs0JLY4i0EPEuu8LHjwZajm=QTC29O6g@mail.gmail.com> (Stefan Kangas's message of "Fri, 19 Mar 2021 21:51:39 -0500")
Stefan Kangas <stefan@marxist.se> writes:
> Andrea Corallo <akrl@sdf.org> writes:
>
>> In `python-indent-region' we are comparing raw syntax descriptors using
>> `eq' but I think we should use `equal' (as we do underneath in
>> `python-fill-string').
>>
>> I'm quite convinced the fix is correct but; should this go also in 27
>> where the code is the same?
>
> That was in December, and there were no followups.
>
> We are one week away from Emacs 27.2, so I don't think we want this on
> emacs-27 right now. If you think the fix is correct, I don't see why we
> couldn't push it there after Emacs 27.2 is released.
>
> Should we perhaps start by getting the fix pushed to master?
Uhmm, I thought the patch was correct but re-testing it this is now
breaking the `python-indent-region-5' test.
Maybe there's a reason why we should use eq there or maybe this is
unveiling a real bug? Not sure, I guess some expert of that code should
probably have a look.
Andrea
next prev parent reply other threads:[~2021-03-21 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 23:03 bug#45328: 28.0.50; [PATCH] Compare raw syntax descriptors with equal in `python-indent-region' Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-20 2:51 ` Stefan Kangas
2021-03-21 21:19 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-05-17 15:06 ` Lars Ingebrigtsen
2022-05-09 13:54 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfh7l4ryqi.fsf@sdf.org \
--to=bug-gnu-emacs@gnu.org \
--cc=45328@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).