From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45328: 28.0.50; [PATCH] Compare raw syntax descriptors with equal in `python-indent-region' Date: Sun, 21 Mar 2021 21:19:33 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38555"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45328@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 21 22:20:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lO5Ua-0009vG-1G for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 22:20:12 +0100 Original-Received: from localhost ([::1]:57824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lO5UY-0008RB-OC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 17:20:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lO5UQ-0008Qp-R3 for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 17:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44022) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lO5UQ-0001N0-Io for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 17:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lO5UQ-0001yO-Eh for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 17:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Mar 2021 21:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45328-submit@debbugs.gnu.org id=B45328.16163615777543 (code B ref 45328); Sun, 21 Mar 2021 21:20:02 +0000 Original-Received: (at 45328) by debbugs.gnu.org; 21 Mar 2021 21:19:37 +0000 Original-Received: from localhost ([127.0.0.1]:55568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lO5U0-0001xa-TM for submit@debbugs.gnu.org; Sun, 21 Mar 2021 17:19:37 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:60334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lO5Ty-0001xR-Jx for 45328@debbugs.gnu.org; Sun, 21 Mar 2021 17:19:35 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 12LLJXGq024114 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 21 Mar 2021 21:19:33 GMT In-Reply-To: (Stefan Kangas's message of "Fri, 19 Mar 2021 21:51:39 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202810 Archived-At: Stefan Kangas writes: > Andrea Corallo writes: > >> In `python-indent-region' we are comparing raw syntax descriptors using >> `eq' but I think we should use `equal' (as we do underneath in >> `python-fill-string'). >> >> I'm quite convinced the fix is correct but; should this go also in 27 >> where the code is the same? > > That was in December, and there were no followups. > > We are one week away from Emacs 27.2, so I don't think we want this on > emacs-27 right now. If you think the fix is correct, I don't see why we > couldn't push it there after Emacs 27.2 is released. > > Should we perhaps start by getting the fix pushed to master? Uhmm, I thought the patch was correct but re-testing it this is now breaking the `python-indent-region-5' test. Maybe there's a reason why we should use eq there or maybe this is unveiling a real bug? Not sure, I guess some expert of that code should probably have a look. Andrea