From: Stefan Kangas <stefan@marxist.se>
To: Andrea Corallo <akrl@sdf.org>
Cc: 45328@debbugs.gnu.org
Subject: bug#45328: 28.0.50; [PATCH] Compare raw syntax descriptors with equal in `python-indent-region'
Date: Fri, 19 Mar 2021 21:51:39 -0500 [thread overview]
Message-ID: <CADwFkmn4JNdWQUU02xqs0JLY4i0EPEuu8LHjwZajm=QTC29O6g@mail.gmail.com> (raw)
In-Reply-To: <xjf8s9twg84.fsf@sdf.org> (Andrea Corallo's message of "Sat, 19 Dec 2020 23:03:55 +0000")
Andrea Corallo <akrl@sdf.org> writes:
> In `python-indent-region' we are comparing raw syntax descriptors using
> `eq' but I think we should use `equal' (as we do underneath in
> `python-fill-string').
>
> I'm quite convinced the fix is correct but; should this go also in 27
> where the code is the same?
That was in December, and there were no followups.
We are one week away from Emacs 27.2, so I don't think we want this on
emacs-27 right now. If you think the fix is correct, I don't see why we
couldn't push it there after Emacs 27.2 is released.
Should we perhaps start by getting the fix pushed to master?
>>From 9163724fcd8eea5c9e2908ecb38d90406669a8d3 Mon Sep 17 00:00:00 2001
> From: Andrea Corallo <akrl@sdf.org>
> Date: Sat, 19 Dec 2020 23:51:36 +0100
> Subject: [PATCH] * Compare raw syntax descriptors with equal in
> `python-indent-region'.
>
> * lisp/progmodes/python.el (python-indent-region): Compare raw
> syntax descriptors with equal.
> ---
> lisp/progmodes/python.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
> index d75944a702..dc2efdfcf7 100644
> --- a/lisp/progmodes/python.el
> +++ b/lisp/progmodes/python.el
> @@ -1259,7 +1259,7 @@ Called from a program, START and END specify the region to indent."
> ;; Don't mess with strings, unless it's the
> ;; enclosing set of quotes or a docstring.
> (or (not (python-syntax-context 'string))
> - (eq
> + (equal
> (syntax-after
> (+ (1- (point))
> (current-indentation)
next prev parent reply other threads:[~2021-03-20 2:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 23:03 bug#45328: 28.0.50; [PATCH] Compare raw syntax descriptors with equal in `python-indent-region' Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-20 2:51 ` Stefan Kangas [this message]
2021-03-21 21:19 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-17 15:06 ` Lars Ingebrigtsen
2022-05-09 13:54 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmn4JNdWQUU02xqs0JLY4i0EPEuu8LHjwZajm=QTC29O6g@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=45328@debbugs.gnu.org \
--cc=akrl@sdf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).