unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#36298: Blank tooltips in Cairo
@ 2019-06-19 20:14 Clément Pit-Claudel
  2019-06-19 20:36 ` Noam Postavsky
  0 siblings, 1 reply; 6+ messages in thread
From: Clément Pit-Claudel @ 2019-06-19 20:14 UTC (permalink / raw)
  To: 36298

Hi all,

In cairo builds, when x-gtk-use-system-tooltips is set to nil, running (x-show-tip "xyz") produce a blank tooltip on my machine (the tooltip has the right dimensions, but is blank).

To reproduce, you can run the following:

    emacs -Q --eval '(progn (setq x-gtk-use-system-tooltips nil) (x-show-tip "xyz"))'

Cheers,
Clément.

In GNU Emacs 27.0.50 (build 15, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10)
 of 2019-06-19 built on clem-w50-mint
Repository revision: a7f71e8dfae9b1571a2ad34e44f000ff4a391644
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Linux Mint 19.1

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure -C --with-cairo'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LIBSYSTEMD JSON
PDUMPER LCMS2 GMP

Important settings:
  value of $LC_MONETARY: en_DK.UTF-8
  value of $LC_NUMERIC: en_DK.UTF-8
  value of $LC_TIME: sv_SE.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 45196 5707)
 (symbols 48 6234 1)
 (strings 32 15386 1168)
 (string-bytes 1 500579)
 (vectors 16 9729)
 (vector-slots 8 127280 8734)
 (floats 8 17 25)
 (intervals 56 188 0)
 (buffers 992 11))





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#36298: Blank tooltips in Cairo
  2019-06-19 20:14 bug#36298: Blank tooltips in Cairo Clément Pit-Claudel
@ 2019-06-19 20:36 ` Noam Postavsky
  2019-06-20  2:15   ` YAMAMOTO Mitsuharu
  0 siblings, 1 reply; 6+ messages in thread
From: Noam Postavsky @ 2019-06-19 20:36 UTC (permalink / raw)
  To: Clément Pit-Claudel; +Cc: 36298

merge 36298 34819
quit

Clément Pit-Claudel <cpitclaudel@gmail.com> writes:

> In cairo builds, when x-gtk-use-system-tooltips is set to nil, running (x-show-tip "xyz") produce a blank tooltip on my machine (the tooltip has the right dimensions, but is blank).
>
> To reproduce, you can run the following:
>
>     emacs -Q --eval '(progn (setq x-gtk-use-system-tooltips nil) (x-show-tip "xyz"))'

This one happens in non-Cairo builds too.






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#36298: Blank tooltips in Cairo
  2019-06-19 20:36 ` Noam Postavsky
@ 2019-06-20  2:15   ` YAMAMOTO Mitsuharu
  2019-06-20  2:20     ` YAMAMOTO Mitsuharu
  2019-06-20 13:24     ` Clément Pit-Claudel
  0 siblings, 2 replies; 6+ messages in thread
From: YAMAMOTO Mitsuharu @ 2019-06-20  2:15 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: Clément Pit-Claudel, 36298, control

unmerge 362
quit

On Thu, 20 Jun 2019 05:36:09 +0900,
Noam Postavsky wrote:
> 
> merge 36298 34819
> quit
> 
> Clément Pit-Claudel <cpitclaudel@gmail.com> writes:
> 
> > In cairo builds, when x-gtk-use-system-tooltips is set to nil, running (x-show-tip "xyz") produce a blank tooltip on my machine (the tooltip has the right dimensions, but is blank).
> >
> > To reproduce, you can run the following:
> >
> >     emacs -Q --eval '(progn (setq x-gtk-use-system-tooltips nil) (x-show-tip "xyz"))'
> 
> This one happens in non-Cairo builds too.

Probably a separate issue.  It seems like a regression by a proposed
fix of Bug#23925 (not yet applied).  Please try below instead.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

diff --git a/src/xterm.c b/src/xterm.c
index bc56e99513d..462028c1504 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -8835,7 +8835,11 @@ handle_one_xevent (struct x_display_info *dpyinfo,
         font_drop_xrender_surfaces (f);
       unblock_input ();
 #ifdef USE_CAIRO
-      if (f)
+      if (f
+#ifdef USE_GTK
+	  && FRAME_TOOLTIP_P (f)
+#endif
+	  )
 	x_cr_update_surface_desired_size (f, configureEvent.xconfigure.width,
 					  configureEvent.xconfigure.height);
 #endif





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#36298: Blank tooltips in Cairo
  2019-06-20  2:15   ` YAMAMOTO Mitsuharu
@ 2019-06-20  2:20     ` YAMAMOTO Mitsuharu
  2019-06-20 13:24     ` Clément Pit-Claudel
  1 sibling, 0 replies; 6+ messages in thread
From: YAMAMOTO Mitsuharu @ 2019-06-20  2:20 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: Clément Pit-Claudel, 36298

unmerge 36298
quit

On Thu, 20 Jun 2019 11:15:47 +0900,
YAMAMOTO Mitsuharu wrote:
> 
> unmerge 362
> quit

Oops, wrong bug number.  Also, I should have added
control@debbugs.gnu.org to Bcc:, not to Cc:.  Please remove it when
replying to the previous post.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#36298: Blank tooltips in Cairo
  2019-06-20  2:15   ` YAMAMOTO Mitsuharu
  2019-06-20  2:20     ` YAMAMOTO Mitsuharu
@ 2019-06-20 13:24     ` Clément Pit-Claudel
  2019-06-21  0:39       ` YAMAMOTO Mitsuharu
  1 sibling, 1 reply; 6+ messages in thread
From: Clément Pit-Claudel @ 2019-06-20 13:24 UTC (permalink / raw)
  To: YAMAMOTO Mitsuharu, Noam Postavsky; +Cc: 36298

On 2019-06-19 22:15, YAMAMOTO Mitsuharu wrote:
> Probably a separate issue.  It seems like a regression by a proposed
> fix of Bug#23925 (not yet applied).  Please try below instead.

Perfect.  With this patch tooltips work and the previous issue is still fixed as well.

Thanks a lot!





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#36298: Blank tooltips in Cairo
  2019-06-20 13:24     ` Clément Pit-Claudel
@ 2019-06-21  0:39       ` YAMAMOTO Mitsuharu
  0 siblings, 0 replies; 6+ messages in thread
From: YAMAMOTO Mitsuharu @ 2019-06-21  0:39 UTC (permalink / raw)
  To: Clément Pit-Claudel; +Cc: Noam Postavsky, 36298-done

On Thu, 20 Jun 2019 22:24:09 +0900,
Clément Pit-Claudel wrote:
> 
> On 2019-06-19 22:15, YAMAMOTO Mitsuharu wrote:
> > Probably a separate issue.  It seems like a regression by a proposed
> > fix of Bug#23925 (not yet applied).  Please try below instead.
> 
> Perfect.  With this patch tooltips work and the previous issue is still fixed as well.
> 
> Thanks a lot!

Thanks for testing.  Expecting further fixes for Bug#34819, I've
pushed a different fix to master as 2a229f495fe.  Closing the bug.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-06-21  0:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 20:14 bug#36298: Blank tooltips in Cairo Clément Pit-Claudel
2019-06-19 20:36 ` Noam Postavsky
2019-06-20  2:15   ` YAMAMOTO Mitsuharu
2019-06-20  2:20     ` YAMAMOTO Mitsuharu
2019-06-20 13:24     ` Clément Pit-Claudel
2019-06-21  0:39       ` YAMAMOTO Mitsuharu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).