From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Noam Postavsky <npostavs@gmail.com>
Cc: "Clément Pit-Claudel" <cpitclaudel@gmail.com>,
36298@debbugs.gnu.org, control@debbugs.gnu.org
Subject: bug#36298: Blank tooltips in Cairo
Date: Thu, 20 Jun 2019 11:15:47 +0900 [thread overview]
Message-ID: <wlsgs557e4.wl-mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <85zhmd71om.fsf@gmail.com>
unmerge 362
quit
On Thu, 20 Jun 2019 05:36:09 +0900,
Noam Postavsky wrote:
>
> merge 36298 34819
> quit
>
> Clément Pit-Claudel <cpitclaudel@gmail.com> writes:
>
> > In cairo builds, when x-gtk-use-system-tooltips is set to nil, running (x-show-tip "xyz") produce a blank tooltip on my machine (the tooltip has the right dimensions, but is blank).
> >
> > To reproduce, you can run the following:
> >
> > emacs -Q --eval '(progn (setq x-gtk-use-system-tooltips nil) (x-show-tip "xyz"))'
>
> This one happens in non-Cairo builds too.
Probably a separate issue. It seems like a regression by a proposed
fix of Bug#23925 (not yet applied). Please try below instead.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
diff --git a/src/xterm.c b/src/xterm.c
index bc56e99513d..462028c1504 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -8835,7 +8835,11 @@ handle_one_xevent (struct x_display_info *dpyinfo,
font_drop_xrender_surfaces (f);
unblock_input ();
#ifdef USE_CAIRO
- if (f)
+ if (f
+#ifdef USE_GTK
+ && FRAME_TOOLTIP_P (f)
+#endif
+ )
x_cr_update_surface_desired_size (f, configureEvent.xconfigure.width,
configureEvent.xconfigure.height);
#endif
next prev parent reply other threads:[~2019-06-20 2:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 20:14 bug#36298: Blank tooltips in Cairo Clément Pit-Claudel
2019-06-19 20:36 ` Noam Postavsky
2019-06-20 2:15 ` YAMAMOTO Mitsuharu [this message]
2019-06-20 2:20 ` YAMAMOTO Mitsuharu
2019-06-20 13:24 ` Clément Pit-Claudel
2019-06-21 0:39 ` YAMAMOTO Mitsuharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wlsgs557e4.wl-mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=36298@debbugs.gnu.org \
--cc=control@debbugs.gnu.org \
--cc=cpitclaudel@gmail.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).