From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 57066@debbugs.gnu.org
Subject: bug#57066: 29.0.50; Complex emoji overlaps with text
Date: Thu, 11 Aug 2022 15:24:38 +0900 [thread overview]
Message-ID: <wla68bguvt.wl-mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <wlv8qze2tg.wl-mituharu@math.s.chiba-u.ac.jp>
On Thu, 11 Aug 2022 15:01:31 +0900,
YAMAMOTO Mitsuharu wrote:
>
> It seems that position unit adjustment for bitmap fonts is no longer
> necessary on HarfBuzz 5:
>
> https://github.com/harfbuzz/harfbuzz/issues/489
>
> Could you test if the following patch works?
Oops, it breaks non-HarfBuzz builds. Pleae try below instead.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
diff --git a/src/ftcrfont.c b/src/ftcrfont.c
index 39ea068556..d5d3e440af 100644
--- a/src/ftcrfont.c
+++ b/src/ftcrfont.c
@@ -568,7 +568,11 @@ ftcrhbfont_begin_hb_font (struct font *font, double *position_unit)
ftcrfont_info->ft_size = ft_face->size;
hb_font_t *hb_font = fthbfont_begin_hb_font (font, position_unit);
- if (ftcrfont_info->bitmap_position_unit)
+ /* HarfBuzz 5 correctly scales bitmap-only fonts without position
+ unit adjustment.
+ (https://github.com/harfbuzz/harfbuzz/issues/489) */
+ if (!hb_version_atleast (5, 0, 0)
+ && ftcrfont_info->bitmap_position_unit)
*position_unit = ftcrfont_info->bitmap_position_unit;
return hb_font;
next prev parent reply other threads:[~2022-08-11 6:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 9:17 bug#57066: 29.0.50; Complex emoji overlaps with text Protesilaos Stavrou
2022-08-09 11:14 ` Eli Zaretskii
2022-08-09 11:28 ` Protesilaos Stavrou
2022-08-09 12:01 ` Eli Zaretskii
2022-08-09 12:50 ` Protesilaos Stavrou
2022-08-09 16:05 ` Eli Zaretskii
2022-08-09 17:17 ` Protesilaos Stavrou
2022-08-09 17:31 ` Eli Zaretskii
2022-08-09 17:41 ` Protesilaos Stavrou
2022-08-09 17:54 ` Eli Zaretskii
2022-08-10 3:15 ` Protesilaos Stavrou
2022-08-10 12:33 ` Eli Zaretskii
2022-08-11 4:07 ` Protesilaos Stavrou
2022-08-11 6:01 ` YAMAMOTO Mitsuharu
2022-08-11 6:24 ` YAMAMOTO Mitsuharu [this message]
2022-08-11 6:35 ` Protesilaos Stavrou
2022-08-11 6:49 ` Eli Zaretskii
2022-08-11 7:23 ` YAMAMOTO Mitsuharu
2022-08-11 7:43 ` Eli Zaretskii
2022-08-11 8:57 ` YAMAMOTO Mitsuharu
2022-08-11 9:35 ` Eli Zaretskii
2022-08-11 9:49 ` YAMAMOTO Mitsuharu
2022-08-09 11:23 ` Fernando de Morais
2022-08-09 11:54 ` Eli Zaretskii
2022-08-09 12:06 ` Fernando de Morais
2022-08-09 18:28 ` Lars Ingebrigtsen
2022-08-10 3:16 ` Protesilaos Stavrou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wla68bguvt.wl-mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=57066@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=info@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).