From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.bugs Subject: bug#57066: 29.0.50; Complex emoji overlaps with text Date: Thu, 11 Aug 2022 15:24:38 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <87r11pzsgb.fsf@protesilaos.com> <83iln1vfbl.fsf@gnu.org> <87o7wtzmdn.fsf@protesilaos.com> <837d3hvd5j.fsf@gnu.org> <87lerxzim5.fsf@protesilaos.com> <835yj1v1vy.fsf@gnu.org> <87czd9pc9z.fsf@protesilaos.com> <83iln1tjap.fsf@gnu.org> <877d3hpb55.fsf@protesilaos.com> <83bkstti9j.fsf@gnu.org> <87bkssn60s.fsf@protesilaos.com> <83zggcqnvz.fsf@gnu.org> <87edxnqv88.fsf@protesilaos.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24584"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: Eli Zaretskii , 57066@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 11 08:26:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oM1dy-0006CG-43 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Aug 2022 08:26:10 +0200 Original-Received: from localhost ([::1]:52978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oM1dw-0001FX-EW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Aug 2022 02:26:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oM1cs-0001EA-FB for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2022 02:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33241) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oM1cs-00082z-6Q for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2022 02:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oM1cr-0004zw-Vq for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2022 02:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: YAMAMOTO Mitsuharu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Aug 2022 06:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57066 X-GNU-PR-Package: emacs Original-Received: via spool by 57066-submit@debbugs.gnu.org id=B57066.166019908619185 (code B ref 57066); Thu, 11 Aug 2022 06:25:01 +0000 Original-Received: (at 57066) by debbugs.gnu.org; 11 Aug 2022 06:24:46 +0000 Original-Received: from localhost ([127.0.0.1]:51223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM1cc-0004zN-IX for submit@debbugs.gnu.org; Thu, 11 Aug 2022 02:24:46 -0400 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:57984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM1cY-0004zA-9U for 57066@debbugs.gnu.org; Thu, 11 Aug 2022 02:24:45 -0400 Original-Received: from mathent.math.s.chiba-u.ac.jp (mathent [192.168.32.5]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 9EF1CF0908; Thu, 11 Aug 2022 15:24:38 +0900 (JST) (envelope-from mituharu@math.s.chiba-u.ac.jp) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239330 Archived-At: On Thu, 11 Aug 2022 15:01:31 +0900, YAMAMOTO Mitsuharu wrote: > > It seems that position unit adjustment for bitmap fonts is no longer > necessary on HarfBuzz 5: > > https://github.com/harfbuzz/harfbuzz/issues/489 > > Could you test if the following patch works? Oops, it breaks non-HarfBuzz builds. Pleae try below instead. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp diff --git a/src/ftcrfont.c b/src/ftcrfont.c index 39ea068556..d5d3e440af 100644 --- a/src/ftcrfont.c +++ b/src/ftcrfont.c @@ -568,7 +568,11 @@ ftcrhbfont_begin_hb_font (struct font *font, double *position_unit) ftcrfont_info->ft_size = ft_face->size; hb_font_t *hb_font = fthbfont_begin_hb_font (font, position_unit); - if (ftcrfont_info->bitmap_position_unit) + /* HarfBuzz 5 correctly scales bitmap-only fonts without position + unit adjustment. + (https://github.com/harfbuzz/harfbuzz/issues/489) */ + if (!hb_version_atleast (5, 0, 0) + && ftcrfont_info->bitmap_position_unit) *position_unit = ftcrfont_info->bitmap_position_unit; return hb_font;