From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 57066@debbugs.gnu.org
Subject: bug#57066: 29.0.50; Complex emoji overlaps with text
Date: Thu, 11 Aug 2022 15:01:31 +0900 [thread overview]
Message-ID: <wlv8qze2tg.wl-mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <87edxnqv88.fsf@protesilaos.com>
On Thu, 11 Aug 2022 13:07:03 +0900,
Protesilaos Stavrou wrote:
>
> > From: Eli Zaretskii <eliz@gnu.org>
> > Date: Wed, 10 Aug 2022 15:33:20 +0300
>
> >> > <Shrug> strange. What is the default value? That is
> >> >
> >> > M-: (default-value 'buffer-file-coding-system) RET
> >>
> >> It is nil.
> >
> > But of course. Should be fixed now, thanks.
>
> Thank you! The C-u C-x = works now.
>
> Back to my original recipe then:
>
> - C-x 8 e s
> - Type "sun" and RET
> - C-b
> - C-u C-x =
>
> This gives me the following Help buffer:
>
> position: 152 of 153 (99%), column: 6
> character: ☀ (displayed as ☀) (codepoint 9728, #o23000, #x2600)
> charset: unicode (Unicode (ISO10646))
> code point in charset: 0x2600
> script: symbol
> syntax: w which means: word
> category: .:Base, j:Japanese
> to input: type "C-x 8 RET 2600" or "C-x 8 RET BLACK SUN WITH RAYS"
> buffer code: #xE2 #x98 #x80
> file code: not encodable by coding system nil
> display: composed to form "☀️" (see below)
>
> Composed with the following character(s) "️" using this font:
> ftcrhb:-GOOG-Noto Color Emoji-regular-normal-normal-*-13-*-*-*-m-0-iso10646-1
> by these glyphs:
> [0 1 9728 59 16 0 17 13 4 [0 0 2]]
> with these character(s):
> ️ (#xfe0f) VARIATION SELECTOR-16
>
> Character code properties: customize what to show
> name: BLACK SUN WITH RAYS
> general-category: So (Symbol, Other)
> decomposition: (9728) ('☀')
>
> There are text properties here:
> fontified t
>
>
> I also attach a screenshot where the coloured sun overlaps with a double
> quotes character.
>
> --
> Protesilaos Stavrou
> https://protesilaos.com
It seems that position unit adjustment for bitmap fonts is no longer
necessary on HarfBuzz 5:
https://github.com/harfbuzz/harfbuzz/issues/489
Could you test if the following patch works?
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
diff --git a/src/ftcrfont.c b/src/ftcrfont.c
index 39ea068556..42610ccd9d 100644
--- a/src/ftcrfont.c
+++ b/src/ftcrfont.c
@@ -273,7 +273,8 @@ ftcrfont_open (struct frame *f, Lisp_Object entity, int pixel_size)
#ifdef HAVE_HARFBUZZ
ftcrfont_info->hb_font = NULL;
#endif /* HAVE_HARFBUZZ */
- if (ft_face->units_per_EM)
+ if (hb_version_atleast (5, 0, 0)
+ || ft_face->units_per_EM)
ftcrfont_info->bitmap_position_unit = 0;
else
ftcrfont_info->bitmap_position_unit = (extents.height
diff --git a/src/ftfont.h b/src/ftfont.h
index f771dc159b..5248aef649 100644
--- a/src/ftfont.h
+++ b/src/ftfont.h
@@ -66,7 +66,9 @@ #define EMACS_FTFONT_H
cairo_scaled_font_t *cr_scaled_font;
/* Scale factor from the bitmap strike metrics in 1/64 pixels, used
as the hb_position_t value in HarfBuzz, to those in (scaled)
- pixels. The value is 0 for scalable fonts. */
+ pixels. The value is 0 for scalable fonts. This is only
+ necessary for HarfBuzz prior to version 5, and the value is
+ always 0 on later versions. */
double bitmap_position_unit;
/* Font metrics cache. */
struct font_metrics **metrics;
next prev parent reply other threads:[~2022-08-11 6:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 9:17 bug#57066: 29.0.50; Complex emoji overlaps with text Protesilaos Stavrou
2022-08-09 11:14 ` Eli Zaretskii
2022-08-09 11:28 ` Protesilaos Stavrou
2022-08-09 12:01 ` Eli Zaretskii
2022-08-09 12:50 ` Protesilaos Stavrou
2022-08-09 16:05 ` Eli Zaretskii
2022-08-09 17:17 ` Protesilaos Stavrou
2022-08-09 17:31 ` Eli Zaretskii
2022-08-09 17:41 ` Protesilaos Stavrou
2022-08-09 17:54 ` Eli Zaretskii
2022-08-10 3:15 ` Protesilaos Stavrou
2022-08-10 12:33 ` Eli Zaretskii
2022-08-11 4:07 ` Protesilaos Stavrou
2022-08-11 6:01 ` YAMAMOTO Mitsuharu [this message]
2022-08-11 6:24 ` YAMAMOTO Mitsuharu
2022-08-11 6:35 ` Protesilaos Stavrou
2022-08-11 6:49 ` Eli Zaretskii
2022-08-11 7:23 ` YAMAMOTO Mitsuharu
2022-08-11 7:43 ` Eli Zaretskii
2022-08-11 8:57 ` YAMAMOTO Mitsuharu
2022-08-11 9:35 ` Eli Zaretskii
2022-08-11 9:49 ` YAMAMOTO Mitsuharu
2022-08-09 11:23 ` Fernando de Morais
2022-08-09 11:54 ` Eli Zaretskii
2022-08-09 12:06 ` Fernando de Morais
2022-08-09 18:28 ` Lars Ingebrigtsen
2022-08-10 3:16 ` Protesilaos Stavrou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wlv8qze2tg.wl-mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=57066@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=info@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).