From: Ruijie Yu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rahguzar@zohomail.eu, 61602@debbugs.gnu.org
Subject: bug#61602: [PATCH]: comint-mode redirection
Date: Fri, 12 May 2023 14:58:55 +0800 [thread overview]
Message-ID: <sdvwn1e6no0.fsf@netyu.xyz> (raw)
In-Reply-To: <83ednm3v9v.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 61602@debbugs.gnu.org
>> Date: Fri, 12 May 2023 10:16:48 +0800
>> From: Ruijie Yu via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>>
>> Thanks for the patch. First of all, when sending a patch(set) for
>> Emacs, you need to run something like this:
>>
>> $ git format-patch
>>
>> and send the generated file(s).
>
> No, this is not a requirement around here. We prefer format-patch,
> indeed, but we don't enforce it. Simple diffs are perfectly
> acceptable.
Yes, I should have worded that way. I meant exactly what you said: it
is a preferred way but not a requirement.
>> What you have sent is a "diff" file, which bears no commit messages.
>> At least in Emacs contributions, patches should usually come
>> together with their commit messages.
>
> That is true. But adding commit log messages doesn't have to be via
> "git format-patch".
Yes.
>> > --- a/lisp/comint.el
>> > +++ b/lisp/comint.el
>> > @@ -161,7 +161,10 @@ comint-prompt-regexp
>> > Defaults to \"^\", the null string at BOL.
>> >
>> > This variable is only used if the variable
>> > -`comint-use-prompt-regexp' is non-nil.
>> > +`comint-use-prompt-regexp' is non-nil. The exception to
>> > +this is redirection. Many commands including
>> > +`comint-redirect-send-command-to-process' use it as
>> > +`comint-redirect-finished-regexp'.
>>
>> This paragraph sounds a bit weird, but I don't know how to reword it.
>> Maybe someone else can help.
>
> I'm not sure the addition is necessary in the first place. What is
> its purpose? why is it useful to mention those exceptional cases?
>
>> Also, here and elsewhere, except for the first line, there should
>> generally be one empty line between paragraphs.
>
> This is not a requirement. It's a judgment call whether an empty line
> is needed or not.
Noted.
>> > -If NO-DISPLAY is non-nil, do not show the output buffer."
>> > +If NO-DISPLAY is non-nil, do not show the output buffer.
>> > +If FINISHED-REGEXP is non-nil it is used as `comint-redirect-finished-regexp'
>> > +instead of `comint-prompt-regexp'."
>>
>> Please clarify what "it" is.
>
> I think it's clear in this case: there's no other candidate for being
> "it" here except FINISHED-REGEXP.
When I first read this sentence, I interpretted it as:
If F-R is non-nil, F-R is used as `c-r-f-r'. Otherwise F-R is used
as `c-p-r'.
I don't know. Maybe you see it differently, in which case I'm fine with
not changing it.
--
Best,
RY
next prev parent reply other threads:[~2023-05-12 6:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 11:26 bug#61602: 29.0.60; comint-mode redirection Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-09 10:04 ` Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-11 17:45 ` bug#61602: [PATCH]: " Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-11 18:14 ` Eli Zaretskii
2023-05-11 18:35 ` Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-12 5:28 ` Eli Zaretskii
2023-05-12 2:16 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-12 6:42 ` Eli Zaretskii
2023-05-12 6:58 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-05-12 7:54 ` Andreas Schwab
2023-05-12 7:25 ` Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-12 7:11 ` Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sdvwn1e6no0.fsf@netyu.xyz \
--to=bug-gnu-emacs@gnu.org \
--cc=61602@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rahguzar@zohomail.eu \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).