From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ruijie Yu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61602: [PATCH]: comint-mode redirection Date: Fri, 12 May 2023 14:58:55 +0800 Message-ID: References: <873573ryft.fsf@zohomail.eu> <87pm763gfy.fsf@zohomail.eu> <83ednm3v9v.fsf@gnu.org> Reply-To: Ruijie Yu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36953"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.11.3; emacs 30.0.50 Cc: rahguzar@zohomail.eu, 61602@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 12 09:00:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pxMlO-0009P7-99 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 May 2023 09:00:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxMl7-0006JC-2A; Fri, 12 May 2023 03:00:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxMl1-0006It-5n for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxMl0-0000k6-SP for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxMl0-0007y4-Or for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ruijie Yu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 07:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61602 X-GNU-PR-Package: emacs Original-Received: via spool by 61602-submit@debbugs.gnu.org id=B61602.168387475630545 (code B ref 61602); Fri, 12 May 2023 07:00:02 +0000 Original-Received: (at 61602) by debbugs.gnu.org; 12 May 2023 06:59:16 +0000 Original-Received: from localhost ([127.0.0.1]:53884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxMkG-0007wb-0d for submit@debbugs.gnu.org; Fri, 12 May 2023 02:59:16 -0400 Original-Received: from netyu.xyz ([152.44.41.246]:51774 helo=mail.netyu.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxMkD-0007wS-RL for 61602@debbugs.gnu.org; Fri, 12 May 2023 02:59:14 -0400 Original-Received: from fw.net.yu.netyu.xyz ( [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id 76296dae (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 12 May 2023 06:59:12 +0000 (UTC) In-reply-to: <83ednm3v9v.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261608 Archived-At: Eli Zaretskii writes: >> Cc: 61602@debbugs.gnu.org >> Date: Fri, 12 May 2023 10:16:48 +0800 >> From: Ruijie Yu via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> >> Thanks for the patch. First of all, when sending a patch(set) for >> Emacs, you need to run something like this: >> >> $ git format-patch >> >> and send the generated file(s). > > No, this is not a requirement around here. We prefer format-patch, > indeed, but we don't enforce it. Simple diffs are perfectly > acceptable. Yes, I should have worded that way. I meant exactly what you said: it is a preferred way but not a requirement. >> What you have sent is a "diff" file, which bears no commit messages. >> At least in Emacs contributions, patches should usually come >> together with their commit messages. > > That is true. But adding commit log messages doesn't have to be via > "git format-patch". Yes. >> > --- a/lisp/comint.el >> > +++ b/lisp/comint.el >> > @@ -161,7 +161,10 @@ comint-prompt-regexp >> > Defaults to \"^\", the null string at BOL. >> > >> > This variable is only used if the variable >> > -`comint-use-prompt-regexp' is non-nil. >> > +`comint-use-prompt-regexp' is non-nil. The exception to >> > +this is redirection. Many commands including >> > +`comint-redirect-send-command-to-process' use it as >> > +`comint-redirect-finished-regexp'. >> >> This paragraph sounds a bit weird, but I don't know how to reword it. >> Maybe someone else can help. > > I'm not sure the addition is necessary in the first place. What is > its purpose? why is it useful to mention those exceptional cases? > >> Also, here and elsewhere, except for the first line, there should >> generally be one empty line between paragraphs. > > This is not a requirement. It's a judgment call whether an empty line > is needed or not. Noted. >> > -If NO-DISPLAY is non-nil, do not show the output buffer." >> > +If NO-DISPLAY is non-nil, do not show the output buffer. >> > +If FINISHED-REGEXP is non-nil it is used as `comint-redirect-finished-regexp' >> > +instead of `comint-prompt-regexp'." >> >> Please clarify what "it" is. > > I think it's clear in this case: there's no other candidate for being > "it" here except FINISHED-REGEXP. When I first read this sentence, I interpretted it as: If F-R is non-nil, F-R is used as `c-r-f-r'. Otherwise F-R is used as `c-p-r'. I don't know. Maybe you see it differently, in which case I'm fine with not changing it. -- Best, RY