From: Andreas Schwab <schwab@linux-m68k.org>
To: 61602@debbugs.gnu.org
Cc: ruijie@netyu.xyz, rahguzar@zohomail.eu, eliz@gnu.org
Subject: bug#61602: [PATCH]: comint-mode redirection
Date: Fri, 12 May 2023 09:54:46 +0200 [thread overview]
Message-ID: <878rdu2ddl.fsf@igel.home> (raw)
In-Reply-To: <sdvwn1e6no0.fsf@netyu.xyz> (Ruijie Yu via's message of "Fri, 12 May 2023 14:58:55 +0800")
On Mai 12 2023, Ruijie Yu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:
>>> > -If NO-DISPLAY is non-nil, do not show the output buffer."
>>> > +If NO-DISPLAY is non-nil, do not show the output buffer.
>>> > +If FINISHED-REGEXP is non-nil it is used as `comint-redirect-finished-regexp'
>>> > +instead of `comint-prompt-regexp'."
>>>
>>> Please clarify what "it" is.
>>
>> I think it's clear in this case: there's no other candidate for being
>> "it" here except FINISHED-REGEXP.
>
> When I first read this sentence, I interpretted it as:
>
> If F-R is non-nil, F-R is used as `c-r-f-r'. Otherwise F-R is used
> as `c-p-r'.
>
> I don't know. Maybe you see it differently, in which case I'm fine with
> not changing it.
Perhaps a better wording:
FINISHED-REGEXP is used as `comint-redirect-finished-regexp'. If
FINISHED-REGEXP is nil it defaults to `comint-prompt-regexp'.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2023-05-12 7:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 11:26 bug#61602: 29.0.60; comint-mode redirection Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-09 10:04 ` Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-11 17:45 ` bug#61602: [PATCH]: " Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-11 18:14 ` Eli Zaretskii
2023-05-11 18:35 ` Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-12 5:28 ` Eli Zaretskii
2023-05-12 2:16 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-12 6:42 ` Eli Zaretskii
2023-05-12 6:58 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-12 7:54 ` Andreas Schwab [this message]
2023-05-12 7:25 ` Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-12 7:11 ` Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rdu2ddl.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=61602@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rahguzar@zohomail.eu \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).