unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 58720@debbugs.gnu.org
Subject: bug#58720: 29.0.50; Improve error reporting of EUDC plist functions
Date: Sat, 22 Oct 2022 14:06:00 -0400	[thread overview]
Message-ID: <m3ilkbbunr.fsf@fitzsim.org> (raw)
In-Reply-To: <8735bfpxjx.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 22 Oct 2022 20:39:46 +0300")

Hi Basil,

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Severity: wishlist
> Tags: patch
>
> In https://bugs.gnu.org/58531#19 it was suggested that
> eudc-plist-member, eudc-plist-get, and eudc-lax-plist-get could signal a
> more informative wrong-type-argument instead of a generic static error
> when passed a degenerate plist argument.  The attached patch makes this
> so.
>
> An alternative is to simply call plist-member and plist-get directly,
> relying on them for any error reporting, and not worry about arguments
> that degenerate further down the list than the point of interest.
>
> WDYT?  How important is it to name and shame degenerate plists as
> eagerly as possible in EUDC?

This patch looks good to me.  I haven't tested it, but if you have, feel
free to push to master.  (EUDC is not packaged in GNU ELPA, so it's OK
to use new functions like plistp without providing backward
compatibility.)

Thanks!
Thomas





  reply	other threads:[~2022-10-22 18:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-22 17:39 bug#58720: 29.0.50; Improve error reporting of EUDC plist functions Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-22 18:06 ` Thomas Fitzsimmons [this message]
2022-10-22 21:51   ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ilkbbunr.fsf@fitzsim.org \
    --to=fitzsim@fitzsim.org \
    --cc=58720@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).