From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Cc: 58720-done@debbugs.gnu.org
Subject: bug#58720: 29.0.50; Improve error reporting of EUDC plist functions
Date: Sun, 23 Oct 2022 00:51:00 +0300 [thread overview]
Message-ID: <8735bfttmj.fsf@tcd.ie> (raw)
In-Reply-To: <m3ilkbbunr.fsf@fitzsim.org> (Thomas Fitzsimmons's message of "Sat, 22 Oct 2022 14:06:00 -0400")
close 58720 29.1
quit
Thomas Fitzsimmons [2022-10-22 14:06 -0400] wrote:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> In https://bugs.gnu.org/58531#19 it was suggested that
>> eudc-plist-member, eudc-plist-get, and eudc-lax-plist-get could signal a
>> more informative wrong-type-argument instead of a generic static error
>> when passed a degenerate plist argument. The attached patch makes this
>> so.
>>
>> An alternative is to simply call plist-member and plist-get directly,
>> relying on them for any error reporting, and not worry about arguments
>> that degenerate further down the list than the point of interest.
>>
>> WDYT? How important is it to name and shame degenerate plists as
>> eagerly as possible in EUDC?
>
> This patch looks good to me. I haven't tested it, but if you have, feel
> free to push to master. (EUDC is not packaged in GNU ELPA, so it's OK
> to use new functions like plistp without providing backward
> compatibility.)
Thanks. Pushed and closing.
Improve error reporting of EUDC plist functions
9db7b11cf7 2022-10-23 00:44:52 +0300
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=9db7b11cf7
--
Basil
prev parent reply other threads:[~2022-10-22 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 17:39 bug#58720: 29.0.50; Improve error reporting of EUDC plist functions Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-22 18:06 ` Thomas Fitzsimmons
2022-10-22 21:51 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735bfttmj.fsf@tcd.ie \
--to=bug-gnu-emacs@gnu.org \
--cc=58720-done@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=fitzsim@fitzsim.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).