From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#58720: 29.0.50; Improve error reporting of EUDC plist functions Date: Sat, 22 Oct 2022 14:06:00 -0400 Message-ID: References: <8735bfpxjx.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12623"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: 58720@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 24 00:26:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omjQ0-00033x-QH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Oct 2022 00:26:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omilL-0006HN-PD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Oct 2022 17:44:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omIti-00043k-CV for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 14:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omIti-00071R-53 for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 14:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omIth-0007vP-Ta for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 14:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2022 18:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58720-submit@debbugs.gnu.org id=B58720.166646197530411 (code B ref 58720); Sat, 22 Oct 2022 18:07:01 +0000 Original-Received: (at 58720) by debbugs.gnu.org; 22 Oct 2022 18:06:15 +0000 Original-Received: from localhost ([127.0.0.1]:42291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omIsx-0007uR-Ek for submit@debbugs.gnu.org; Sat, 22 Oct 2022 14:06:15 -0400 Original-Received: from mail.fitzsim.org ([69.165.165.189]:33386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omIsu-0007uC-UI for 58720@debbugs.gnu.org; Sat, 22 Oct 2022 14:06:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=elc6/WRljxOk/n+AqpzNrM2hzTbilZHwXjton9gm+Yc=; b=Iej5/Bh2x6JdYJAOFiuU2yGP42 KMPPmDc4GPJPKeIo+ISqqgYuac56DxIbviUTg9jOkqtwz21M8PS5UwQIUTKrN24rFO3v5aZmZ3yg8 WY3CbFSIuCR7Xru8E8bGDtUYzd8cWEeQcfz27sUOsjheLvKMNIa57hSQWEXJnQHmdryO6hhvrzqYm XFEK8cP4LiyHIC3aT+t9ZlAl5IDfBj0rxmOEUsdFqDQObDrlGlwHJrxT6jzjw03BFTbWFxatM5Fjl AIcxTab6/DCOMmQMw9WwRFMaV+txFhBciI+1fdmoOd0ybTEbmnIrpgqG1pHcqW9kgwxYyV5GSI/0A XlTkYgIw==; Original-Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1omIsk-000IaU-7x; Sat, 22 Oct 2022 14:06:05 -0400 In-Reply-To: <8735bfpxjx.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 22 Oct 2022 20:39:46 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:246040 Archived-At: Hi Basil, "Basil L. Contovounesios" writes: > Severity: wishlist > Tags: patch > > In https://bugs.gnu.org/58531#19 it was suggested that > eudc-plist-member, eudc-plist-get, and eudc-lax-plist-get could signal a > more informative wrong-type-argument instead of a generic static error > when passed a degenerate plist argument. The attached patch makes this > so. > > An alternative is to simply call plist-member and plist-get directly, > relying on them for any error reporting, and not worry about arguments > that degenerate further down the list than the point of interest. > > WDYT? How important is it to name and shame degenerate plists as > eagerly as possible in EUDC? This patch looks good to me. I haven't tested it, but if you have, feel free to push to master. (EUDC is not packaged in GNU ELPA, so it's OK to use new functions like plistp without providing backward compatibility.) Thanks! Thomas