unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS
@ 2020-07-25 18:35 Philipp
  2020-12-25  6:27 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Philipp @ 2020-07-25 18:35 UTC (permalink / raw)
  To: 42534


This is a follow-up to Bug#30700, reporting each test failure as
individual bug.  In this case, the test package-test-macro-compilation
fails on macOS:

Test package-test-macro-compilation backtrace:
  signal(ert-test-failed (((should (equal (macro-problem-func) '(1 b))
  ert-fail(((should (equal (macro-problem-func) '(1 b))) :form (equal 
  #f(compiled-function () #<bytecode 0x1f953e56a3a07011>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name package-test-macro-compilation :docum
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/package-t
  command-line()
  normal-top-level()
Test package-test-macro-compilation condition:
    (ert-test-failed
     ((should
       (equal
	(macro-problem-func)
	'...))
      :form
      (equal
       (progn a b)
       (1 b))
      :value nil :explanation
      (proper-lists-of-different-length 3 2
					(progn a b)
					(1 b)
					first-mismatch-at 0)))
   FAILED  23/32  package-test-macro-compilation (1.641010 sec)



In GNU Emacs 28.0.50 (build 67, x86_64-apple-darwin19.5.0, NS appkit-1894.50 Version 10.15.5 (Build 19F101))
 of 2020-07-25
Repository revision: 3b44829823f43d3736b8ec9db2258eeff7f6c16a
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1894
System Description:  Mac OS X 10.15.5

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --with-modules --without-xml2 --without-pop --with-mailutils
 --enable-gcc-warnings=warn-only --enable-checking=all
 --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0''

Configured features:
JPEG TIFF GIF PNG NOTIFY KQUEUE ACL GNUTLS ZLIB TOOLKIT_SCROLL_BARS NS
MODULES THREADS JSON PDUMPER LCMS2

Important settings:
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822
mml easymenu mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs
text-property-search time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro
kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json map url-vars mailcap subr-x rx gnutls puny seq
byte-opt gv bytecomp byte-compile cconv dbus xml compile comint
ansi-color ring cl-loaddefs cl-lib tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win
ucs-normalize mule-util term/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads kqueue cocoa ns
lcms2 multi-tty make-network-process emacs)

Memory information:
((conses 16 69913 5569)
 (symbols 48 8650 1)
 (strings 32 23673 1933)
 (string-bytes 1 769982)
 (vectors 16 14334)
 (vector-slots 8 180946 11780)
 (floats 8 26 29)
 (intervals 56 206 0)
 (buffers 992 10))





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS
  2020-07-25 18:35 bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS Philipp
@ 2020-12-25  6:27 ` Lars Ingebrigtsen
  2020-12-25 11:03   ` Philipp Stephani
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-25  6:27 UTC (permalink / raw)
  To: Philipp; +Cc: 42534

Philipp <p.stephani2@gmail.com> writes:

> This is a follow-up to Bug#30700, reporting each test failure as
> individual bug.  In this case, the test package-test-macro-compilation
> fails on macOS:
>
> Test package-test-macro-compilation backtrace:
>   signal(ert-test-failed (((should (equal (macro-problem-func) '(1 b))
>   ert-fail(((should (equal (macro-problem-func) '(1 b))) :form (equal 

I'm now seeing this build failure on Macos (Catalina) any more -- has it
gone away for you, too?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS
  2020-12-25  6:27 ` Lars Ingebrigtsen
@ 2020-12-25 11:03   ` Philipp Stephani
  2020-12-25 20:29     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Philipp Stephani @ 2020-12-25 11:03 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 42534

Am Fr., 25. Dez. 2020 um 07:27 Uhr schrieb Lars Ingebrigtsen <larsi@gnus.org>:
>
> Philipp <p.stephani2@gmail.com> writes:
>
> > This is a follow-up to Bug#30700, reporting each test failure as
> > individual bug.  In this case, the test package-test-macro-compilation
> > fails on macOS:
> >
> > Test package-test-macro-compilation backtrace:
> >   signal(ert-test-failed (((should (equal (macro-problem-func) '(1 b))
> >   ert-fail(((should (equal (macro-problem-func) '(1 b))) :form (equal
>
> I'm now seeing this build failure on Macos (Catalina) any more -- has it
> gone away for you, too?
>

I'm still seeing this on Big Sur.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS
  2020-12-25 11:03   ` Philipp Stephani
@ 2020-12-25 20:29     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-25 20:29 UTC (permalink / raw)
  To: Philipp Stephani; +Cc: 42534

Philipp Stephani <p.stephani2@gmail.com> writes:

>> I'm now seeing this build failure on Macos (Catalina) any more -- has it
>> gone away for you, too?
>>
>
> I'm still seeing this on Big Sur.

And now I'm getting it on Catalina again:

1 unexpected results:
   FAILED  package-test-macro-compilation

Either I missed it the last time, or it's unstable, I guess.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS
  2020-12-25 20:42       ` Eli Zaretskii
@ 2020-12-25 20:49         ` Lars Ingebrigtsen
  2020-12-25 21:43         ` bug#37615: " Lars Ingebrigtsen
  1 sibling, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-25 20:49 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 42534, 37615, Artur Malabarba

Eli Zaretskii <eliz@gnu.org> writes:

> I cannot understand why this happens on MS-Windows, but not on
> GNU/Linux.

The test that fails is this:

(ert-deftest package-test-macro-compilation ()
  "Install a package which includes a dependency."
  (with-package-test (:basedir (ert-resource-directory))
    (package-install-file (expand-file-name "macro-problem-package-1.0/"))
    (require 'macro-problem)
    ;; `macro-problem-func' uses a macro from `macro-aux'.
    (should (equal (macro-problem-func) '(progn a b)))
    (package-install-file (expand-file-name "macro-problem-package-2.0/"))
    ;; After upgrading, `macro-problem-func' depends on a new version
    ;; of the macro from `macro-aux'.
    (should (equal (macro-problem-func) '(1 b)))
    ;; `macro-problem-10-and-90' depends on an entirely new macro from `macro-aux'.
    (should (equal (macro-problem-10-and-90) '(10 90)))))

The thing that doesn't work is:

    (package-install-file (expand-file-name "macro-problem-package-2.0/"))

This does not reload the files, and that's because
package--load-files-for-activation doesn't reload them.  Which is
because package--list-loaded-files doesn't identify the files as
something that needs to be reloaded, as far as I can tell.

That function does a whole lot of comparison of file paths, and my guess
is that whatever it's doing (I'm having a hard time following the logic)
only works on GNU/Linux systems.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS
  2020-12-26  8:39           ` Eli Zaretskii
@ 2020-12-26 22:00             ` Lars Ingebrigtsen
  0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-26 22:00 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 42534, 37615, bruce.connor.am

Eli Zaretskii <eliz@gnu.org> writes:

> In my case, the problem was that MS-Windows (in the version I run
> here) produces short 8+3 alias file names for long directory names,
> the file name for temporary-file-directory didn't compare equal to
> what Emacs expected, exactly as on macOS; file-truename fixed that.

Ah, I see.  Apparently the Windows setup I'm using (for Emacs build
tests) isn't doing the 8+3 thing (Windows 10 with msys2/mingw shell).

Anyway, thanks for checking; closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-12-26 22:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-25 18:35 bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS Philipp
2020-12-25  6:27 ` Lars Ingebrigtsen
2020-12-25 11:03   ` Philipp Stephani
2020-12-25 20:29     ` Lars Ingebrigtsen
  -- strict thread matches above, loose matches on Subject: below --
2019-10-04  8:13 bug#37615: 27.0.50; package-test-macro-compilation fails Eli Zaretskii
2020-12-25  6:29 ` bug#37615: bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS Lars Ingebrigtsen
2020-12-25  7:54   ` Eli Zaretskii
2020-12-25 19:37     ` Lars Ingebrigtsen
2020-12-25 20:42       ` Eli Zaretskii
2020-12-25 20:49         ` Lars Ingebrigtsen
2020-12-25 21:43         ` bug#37615: " Lars Ingebrigtsen
2020-12-26  8:39           ` Eli Zaretskii
2020-12-26 22:00             ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).