bug#37615: 27.0.50; package-test-macro-compilation fails

bug#37615: 27.0.50; package-test-macro-compilation fails

[Eli Zaretskii]

I just did the obvious:

  cd test
  make lisp/emacs-lisp/package-tests.log

and got this:

  Test package-test-macro-compilation backtrace:
    signal(ert-test-failed (((should (equal (macro-problem-func) '(1 b))
    ert-fail(((should (equal (macro-problem-func) '(1 b))) :form (equal
    (if (unwind-protect (setq value-77 (apply fn-75 args-76)) (setq form
    (let (form-description-79) (if (unwind-protect (setq value-77 (apply
    (let ((value-77 'ert-form-evaluation-aborted-78)) (let (form-descrip
    (let* ((fn-75 #'equal) (args-76 (condition-case err (let ((signal-ho
    (progn nil (package-install-file (expand-file-name "macro-problem-pa
    (unwind-protect (progn nil (package-install-file (expand-file-name "
    (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
    (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-b
    (progn (fset 'y-or-n-p vnew) (fset 'yes-or-no-p vnew) (let ((temp-bu
    (unwind-protect (progn (fset 'y-or-n-p vnew) (fset 'yes-or-no-p vnew
    (let* ((vnew #'(lambda (&rest r) t)) (vnew #'(lambda (&rest r) t)) (
    (progn (cd "package-resources") (if (file-directory-p package-user-d
    (unwind-protect (progn (cd "package-resources") (if (file-directory-
    (let* ((package-test-user-dir (make-temp-file "pkg-test-user-dir-" t
    (lambda nil (let* ((package-test-user-dir (make-temp-file "pkg-test-
    ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
    ert-run-test(#s(ert-test :name package-test-macro-compilation :docum
    ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
    ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
    ert-run-tests-batch((not (tag :unstable)))
    ert-run-tests-batch-and-exit((not (tag :unstable)))
    eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
    command-line-1((#("-L" 0 2 (charset cp862)) #(";." 0 2 (charset cp86
    command-line()
    normal-top-level()
  Test package-test-macro-compilation condition:
      (ert-test-failed
       ((should
	 (equal
	  (macro-problem-func)
	  '...))
	:form
	(equal
	 (progn a b)
	 (1 b))
	:value nil :explanation
	(proper-lists-of-different-length 3 2
					  (progn a b)
					  (1 b)
					  first-mismatch-at 0)))
     FAILED  13/21  package-test-macro-compilation (0.796875 sec)

In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)
 of 2019-10-04 built on HOME-C4E4A596F7
Repository revision: 3886a5c140b03f07c8faea7cacad0a791bc54fa5
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 5.1.2600
System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure -C --prefix=/d/usr --with-wide-int --with-modules
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2
HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1255

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads w32notify w32 lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 50864 9234)
 (symbols 48 7160 1)
 (strings 16 18763 2090)
 (string-bytes 1 528068)
 (vectors 16 9862)
 (vector-slots 8 129461 7294)
 (floats 8 21 35)
 (intervals 40 258 0)
 (buffers 888 11))

bug#37615: 27.0.50; package-test-macro-compilation fails

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> I just did the obvious:
>
>   cd test
>   make lisp/emacs-lisp/package-tests.log
>
> and got this:
[...]
>      FAILED  13/21  package-test-macro-compilation (0.796875 sec)
>
> In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)
>  of 2019-10-04 built on HOME-C4E4A596F7

Could this be MS-Windows specific?  I'm not seeing it here, on GNU/Linux.

Best regards,
Stefan Kangas

bug#37615: 27.0.50; package-test-macro-compilation fails

[Robert Pluim]

>>>>> On Fri, 4 Oct 2019 10:23:45 +0200, Stefan Kangas <stefan@marxist.se> said:

    Stefan> Eli Zaretskii <eliz@gnu.org> writes:
    >> I just did the obvious:
    >> 
    >> cd test
    >> make lisp/emacs-lisp/package-tests.log
    >> 
    >> and got this:
    Stefan> [...]
    >> FAILED  13/21  package-test-macro-compilation (0.796875 sec)
    >> 
    >> In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)
    >> of 2019-10-04 built on HOME-C4E4A596F7

    Stefan> Could this be MS-Windows specific?  I'm not seeing it here, on GNU/Linux.

Iʼm seeing it on macOS (and make bootstrap fails....)

Robert

bug#37615: 27.0.50; package-test-macro-compilation fails

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 4 Oct 2019 10:23:45 +0200
> Cc: 37615@debbugs.gnu.org
> 
> >   cd test
> >   make lisp/emacs-lisp/package-tests.log
> >
> > and got this:
> [...]
> >      FAILED  13/21  package-test-macro-compilation (0.796875 sec)
> >
> > In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)
> >  of 2019-10-04 built on HOME-C4E4A596F7
> 
> Could this be MS-Windows specific?  I'm not seeing it here, on GNU/Linux.

Could be.  Do you know where should I look and what additional details
to send?

In general, this test is too noisy and displays a lot of messages that
fill the screen and make it hard to find relevant parts.  So maybe I'm
missing some important clue.  For example, is any of the below related
or not?

    INFO     Scraping files for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el...
  Generating autoloads for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-aux.el...
  ~/macro-problem-2.0/macro-problem-autoloads.el and c:/Documents and Settings/Zaretzky/Local Settings/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el are the same file
  Generating autoloads for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-aux.el...done
  Generating autoloads for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem.el...
  ~/macro-problem-2.0/macro-problem-autoloads.el and c:/Documents and Settings/Zaretzky/Local Settings/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el are the same file
  Generating autoloads for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem.el...done
    INFO     Scraping files for ../../../../../../DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el...done
  Wrote c:/Documents and Settings/Zaretzky/Local Settings/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el
  Checking c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0...
  Compiling c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-aux.el...
  Compiling c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-autoloads.el...
  Compiling c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem-pkg.el...
  Compiling c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/pkg-test-user-dir-A1WA70/macro-problem-2.0/macro-problem.el...

  In macro-problem-10-and-90:
  macro-problem.el:27:45:Warning: reference to free variable `hehe'

  In end of data:
  macro-problem.el:31:1:Warning: the function `macro-aux-3' is not known to be
      defined.

bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Philipp]

This is a follow-up to Bug#30700, reporting each test failure as
individual bug.  In this case, the test package-test-macro-compilation
fails on macOS:

Test package-test-macro-compilation backtrace:
  signal(ert-test-failed (((should (equal (macro-problem-func) '(1 b))
  ert-fail(((should (equal (macro-problem-func) '(1 b))) :form (equal 
  #f(compiled-function () #<bytecode 0x1f953e56a3a07011>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name package-test-macro-compilation :docum
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/package-t
  command-line()
  normal-top-level()
Test package-test-macro-compilation condition:
    (ert-test-failed
     ((should
       (equal
	(macro-problem-func)
	'...))
      :form
      (equal
       (progn a b)
       (1 b))
      :value nil :explanation
      (proper-lists-of-different-length 3 2
					(progn a b)
					(1 b)
					first-mismatch-at 0)))
   FAILED  23/32  package-test-macro-compilation (1.641010 sec)



In GNU Emacs 28.0.50 (build 67, x86_64-apple-darwin19.5.0, NS appkit-1894.50 Version 10.15.5 (Build 19F101))
 of 2020-07-25
Repository revision: 3b44829823f43d3736b8ec9db2258eeff7f6c16a
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1894
System Description:  Mac OS X 10.15.5

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --with-modules --without-xml2 --without-pop --with-mailutils
 --enable-gcc-warnings=warn-only --enable-checking=all
 --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0''

Configured features:
JPEG TIFF GIF PNG NOTIFY KQUEUE ACL GNUTLS ZLIB TOOLKIT_SCROLL_BARS NS
MODULES THREADS JSON PDUMPER LCMS2

Important settings:
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822
mml easymenu mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs
text-property-search time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro
kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json map url-vars mailcap subr-x rx gnutls puny seq
byte-opt gv bytecomp byte-compile cconv dbus xml compile comint
ansi-color ring cl-loaddefs cl-lib tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win
ucs-normalize mule-util term/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads kqueue cocoa ns
lcms2 multi-tty make-network-process emacs)

Memory information:
((conses 16 69913 5569)
 (symbols 48 8650 1)
 (strings 32 23673 1933)
 (string-bytes 1 769982)
 (vectors 16 14334)
 (vector-slots 8 180946 11780)
 (floats 8 26 29)
 (intervals 56 206 0)
 (buffers 992 10))

bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Lars Ingebrigtsen]

Philipp <p.stephani2@gmail.com> writes:

> This is a follow-up to Bug#30700, reporting each test failure as
> individual bug.  In this case, the test package-test-macro-compilation
> fails on macOS:
>
> Test package-test-macro-compilation backtrace:
>   signal(ert-test-failed (((should (equal (macro-problem-func) '(1 b))
>   ert-fail(((should (equal (macro-problem-func) '(1 b))) :form (equal 

I'm now seeing this build failure on Macos (Catalina) any more -- has it
gone away for you, too?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37615: bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> I just did the obvious:
>
>   cd test
>   make lisp/emacs-lisp/package-tests.log

[...]

>      FAILED  13/21  package-test-macro-compilation (0.796875 sec)
>
> In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)

I tried this (with mingw64) in Emacs 28, and this test didn't fail for
me.  Are you still seeing this?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37615: bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 37615@debbugs.gnu.org,  42534@debbugs.gnu.org
> Date: Fri, 25 Dec 2020 07:29:10 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I just did the obvious:
> >
> >   cd test
> >   make lisp/emacs-lisp/package-tests.log
> 
> [...]
> 
> >      FAILED  13/21  package-test-macro-compilation (0.796875 sec)
> >
> > In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)
> 
> I tried this (with mingw64) in Emacs 28, and this test didn't fail for
> me.  Are you still seeing this?

Yes (with current master).  I get this in the failure message:

  Test package-test-macro-compilation condition:
      (ert-test-failed
       ((should
	 (equal
	  (macro-problem-func)
	  '...))
	:form
	(equal
	 (progn a b)
	 (1 b))
	:value nil :explanation
	(proper-lists-of-different-length 3 2
					  (progn a b)
					  (1 b)
					  first-mismatch-at 0)))
     FAILED  23/32  package-test-macro-compilation (0.953125 sec)

I'm happy to provide more details if needed, or debug this more given
some instructions.

bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Philipp Stephani]

Am Fr., 25. Dez. 2020 um 07:27 Uhr schrieb Lars Ingebrigtsen <larsi@gnus.org>:
>
> Philipp <p.stephani2@gmail.com> writes:
>
> > This is a follow-up to Bug#30700, reporting each test failure as
> > individual bug.  In this case, the test package-test-macro-compilation
> > fails on macOS:
> >
> > Test package-test-macro-compilation backtrace:
> >   signal(ert-test-failed (((should (equal (macro-problem-func) '(1 b))
> >   ert-fail(((should (equal (macro-problem-func) '(1 b))) :form (equal
>
> I'm now seeing this build failure on Macos (Catalina) any more -- has it
> gone away for you, too?
>

I'm still seeing this on Big Sur.

bug#37615: bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>      FAILED  23/32  package-test-macro-compilation (0.953125 sec)

I'm getting this failure instead (on a brand new msys2/mingw
installation): 

1 unexpected results:
   FAILED  package-test-signed

> I'm happy to provide more details if needed, or debug this more given
> some instructions.

I'm pretty unfamiliar with package.el and wholly unfamiliar with
Windows, so I'll leave that to somebody else.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Lars Ingebrigtsen]

Philipp Stephani <p.stephani2@gmail.com> writes:

>> I'm now seeing this build failure on Macos (Catalina) any more -- has it
>> gone away for you, too?
>>
>
> I'm still seeing this on Big Sur.

And now I'm getting it on Catalina again:

1 unexpected results:
   FAILED  package-test-macro-compilation

Either I missed it the last time, or it's unstable, I guess.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37615: bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 37615@debbugs.gnu.org,  42534@debbugs.gnu.org
> Date: Fri, 25 Dec 2020 20:37:49 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >      FAILED  23/32  package-test-macro-compilation (0.953125 sec)

First signs of trouble are here:

  In macro-problem-10-and-90:
  macro-problem.el:27:45: Warning: reference to free variable `hehe'

  In end of data:
  macro-problem.el:31:1: Warning: the function `macro-aux-3' is not known to be
      defined.

I cannot understand why this happens on MS-Windows, but not on
GNU/Linux.

> I'm getting this failure instead (on a brand new msys2/mingw
> installation): 
> 
> 1 unexpected results:
>    FAILED  package-test-signed

On my system this is skipped because gpg2 is not installed.

> > I'm happy to provide more details if needed, or debug this more given
> > some instructions.
> 
> I'm pretty unfamiliar with package.el and wholly unfamiliar with
> Windows, so I'll leave that to somebody else.

CC'ing the author of package-tests in the hope that he could suggest
some ideas for fixing this.

bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> I cannot understand why this happens on MS-Windows, but not on
> GNU/Linux.

The test that fails is this:

(ert-deftest package-test-macro-compilation ()
  "Install a package which includes a dependency."
  (with-package-test (:basedir (ert-resource-directory))
    (package-install-file (expand-file-name "macro-problem-package-1.0/"))
    (require 'macro-problem)
    ;; `macro-problem-func' uses a macro from `macro-aux'.
    (should (equal (macro-problem-func) '(progn a b)))
    (package-install-file (expand-file-name "macro-problem-package-2.0/"))
    ;; After upgrading, `macro-problem-func' depends on a new version
    ;; of the macro from `macro-aux'.
    (should (equal (macro-problem-func) '(1 b)))
    ;; `macro-problem-10-and-90' depends on an entirely new macro from `macro-aux'.
    (should (equal (macro-problem-10-and-90) '(10 90)))))

The thing that doesn't work is:

    (package-install-file (expand-file-name "macro-problem-package-2.0/"))

This does not reload the files, and that's because
package--load-files-for-activation doesn't reload them.  Which is
because package--list-loaded-files doesn't identify the files as
something that needs to be reloaded, as far as I can tell.

That function does a whole lot of comparison of file paths, and my guess
is that whatever it's doing (I'm having a hard time following the logic)
only works on GNU/Linux systems.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37615: bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Lars Ingebrigtsen]

The problem on Macos seems to be that it's comparing file-truenames, but
that's not what's in the load history.  For instance,
"/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"
is in load-history, but it's finding conflicts by truenaming:

(file-truename "/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads")
=> "/private/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"

And indeed:

larsi@open-catalina test % ls -ld /var
lrwxr-xr-x@ 1 root  admin  11 Dec 18 15:11 /var -> private/var

The following seems to fix the problem for me on Macos and doesn't lead
to any breakages on Debian, so I'm pushing it now.  Can you check
whether this fixes the problem on Windows?

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 0170e61e12..bc450b09d0 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -830,7 +830,7 @@ package--files-load-history
         (mapcar (lambda (x)
                   (let ((f (car x)))
                     (and (stringp f)
-                         (file-name-sans-extension f))))
+                         (file-name-sans-extension (file-truename f)))))
                 load-history)))
 
 (defun package--list-of-conflicts (dir history)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37615: bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Artur Malabarba <bruce.connor.am@gmail.com>,  37615@debbugs.gnu.org,
>   42534@debbugs.gnu.org
> Date: Fri, 25 Dec 2020 22:43:24 +0100
> 
> The problem on Macos seems to be that it's comparing file-truenames, but
> that's not what's in the load history.  For instance,
> "/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"
> is in load-history, but it's finding conflicts by truenaming:
> 
> (file-truename "/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads")
> => "/private/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"
> 
> And indeed:
> 
> larsi@open-catalina test % ls -ld /var
> lrwxr-xr-x@ 1 root  admin  11 Dec 18 15:11 /var -> private/var
> 
> The following seems to fix the problem for me on Macos and doesn't lead
> to any breakages on Debian, so I'm pushing it now.  Can you check
> whether this fixes the problem on Windows?

Yes, thanks.

In my case, the problem was that MS-Windows (in the version I run
here) produces short 8+3 alias file names for long directory names,
the file name for temporary-file-directory didn't compare equal to
what Emacs expected, exactly as on macOS; file-truename fixed that.

bug#42534: 28.0.50; package-test-macro-compilation test fails on macOS

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> In my case, the problem was that MS-Windows (in the version I run
> here) produces short 8+3 alias file names for long directory names,
> the file name for temporary-file-directory didn't compare equal to
> what Emacs expected, exactly as on macOS; file-truename fixed that.

Ah, I see.  Apparently the Windows setup I'm using (for Emacs build
tests) isn't doing the 8+3 thing (Windows 10 with msys2/mingw shell).

Anyway, thanks for checking; closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no