* bug#56272: [PATCH] fix configure.ac quoting of AC_CHECK_LIB's 2nd arg
@ 2022-06-28 5:31 Jim Meyering
2022-06-28 11:29 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Jim Meyering @ 2022-06-28 5:31 UTC (permalink / raw)
To: 56272
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
I tried to build latest emacs bootstrapped with the latest autoconf and
hit a failure due to inadequate quoting in configure.ac. This fixes
three such problems:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-fix-configure.ac-quoting-of-AC_CHECK_LIB-s-2nd-arg.patch --]
[-- Type: text/x-patch, Size: 1886 bytes --]
From 5cbeba4d1f2102066b3d0c327e289c6a840b114b Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@fb.com>
Date: Sun, 26 Jun 2022 21:26:01 -0700
Subject: [PATCH] fix configure.ac quoting of AC_CHECK_LIB's 2nd arg
Running an autoconf-head-generated configure, would fail like this:
/emacs/configure: line 18002: syntax error near unexpected token `;;'
/emacs/configure: line 18002: ` ;;'
That is due to under-quoting of AC_CHECK_LIB's second argument, which led to
the comma in an embedded string being interpreted as paramater-delimiting.
* configure.ac: Quote the second arg of each AC_CHECK_LIB invocation.
---
configure.ac | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index c91b7de322..17f86627a7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3622,7 +3622,7 @@ AC_DEFUN
CFLAGS="$CFLAGS $XFT_CFLAGS"
LIBS="$XFT_LIBS $LIBS"
AC_CHECK_HEADER(X11/Xft/Xft.h,
- AC_CHECK_LIB(Xft, XftFontOpen, HAVE_XFT=yes, , $XFT_LIBS) , ,
+ [AC_CHECK_LIB(Xft, XftFontOpen, HAVE_XFT=yes, , $XFT_LIBS)] , ,
[[#include <X11/X.h>]])
if test "${HAVE_XFT}" = "yes"; then
@@ -3818,7 +3818,7 @@ AC_DEFUN
XCB_LIBS=
if test "${HAVE_X11}" = "yes"; then
AC_CHECK_HEADER(X11/Xlib-xcb.h,
- AC_CHECK_LIB(xcb, xcb_translate_coordinates, HAVE_XCB=yes))
+ [AC_CHECK_LIB(xcb, xcb_translate_coordinates, HAVE_XCB=yes)])
if test "${HAVE_XCB}" = "yes"; then
AC_CHECK_LIB(X11-xcb, XGetXCBConnection, HAVE_X11_XCB=yes)
if test "${HAVE_X11_XCB}" = "yes"; then
@@ -4597,7 +4597,7 @@ AC_DEFUN
HAVE_XSYNC=no
if test "${HAVE_X11}" = "yes"; then
AC_CHECK_HEADER(X11/extensions/sync.h,
- AC_CHECK_LIB(Xext, XSyncQueryExtension, HAVE_XSYNC=yes),
+ [AC_CHECK_LIB(Xext, XSyncQueryExtension, HAVE_XSYNC=yes)],
[], [#include <X11/Xlib.h>])
if test "${HAVE_XSYNC}" = "yes"; then
--
2.37.0.rc2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#56272: [PATCH] fix configure.ac quoting of AC_CHECK_LIB's 2nd arg
2022-06-28 5:31 bug#56272: [PATCH] fix configure.ac quoting of AC_CHECK_LIB's 2nd arg Jim Meyering
@ 2022-06-28 11:29 ` Eli Zaretskii
2022-06-29 0:14 ` Jim Meyering
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2022-06-28 11:29 UTC (permalink / raw)
To: Jim Meyering; +Cc: 56272
> From: Jim Meyering <jim@meyering.net>
> Date: Mon, 27 Jun 2022 22:31:54 -0700
>
> I tried to build latest emacs bootstrapped with the latest autoconf and
> hit a failure due to inadequate quoting in configure.ac. This fixes
> three such problems:
For the record: which version of Autoconf was that?
I installed the changes on the master branch, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#56272: [PATCH] fix configure.ac quoting of AC_CHECK_LIB's 2nd arg
2022-06-28 11:29 ` Eli Zaretskii
@ 2022-06-29 0:14 ` Jim Meyering
2022-06-29 2:33 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Jim Meyering @ 2022-06-29 0:14 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 56272
On Tue, Jun 28, 2022 at 4:29 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Jim Meyering <jim@meyering.net>
> > Date: Mon, 27 Jun 2022 22:31:54 -0700
> >
> > I tried to build latest emacs bootstrapped with the latest autoconf and
> > hit a failure due to inadequate quoting in configure.ac. This fixes
> > three such problems:
>
> For the record: which version of Autoconf was that?
>
> I installed the changes on the master branch, thanks.
Thank you. I was using latest built from autoconf-git's HEAD as of
yesterday, which was v2.72a-36-g256d8549
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-29 2:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-28 5:31 bug#56272: [PATCH] fix configure.ac quoting of AC_CHECK_LIB's 2nd arg Jim Meyering
2022-06-28 11:29 ` Eli Zaretskii
2022-06-29 0:14 ` Jim Meyering
2022-06-29 2:33 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).