From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Meyering Newsgroups: gmane.emacs.bugs Subject: bug#56272: [PATCH] fix configure.ac quoting of AC_CHECK_LIB's 2nd arg Date: Mon, 27 Jun 2022 22:31:54 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8260"; mail-complaints-to="usenet@ciao.gmane.io" To: 56272@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 28 09:28:07 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o65dn-0001uc-Bs for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jun 2022 09:28:07 +0200 Original-Received: from localhost ([::1]:50440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o65dm-00053g-8l for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jun 2022 03:28:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o63qQ-0005xq-G0 for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 01:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59917) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o63qQ-00051R-6p for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 01:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o63qQ-0006Wb-2z for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 01:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Jun 2022 05:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.165639433124994 (code B ref -1); Tue, 28 Jun 2022 05:33:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Jun 2022 05:32:11 +0000 Original-Received: from localhost ([127.0.0.1]:53814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o63pb-0006V4-4D for submit@debbugs.gnu.org; Tue, 28 Jun 2022 01:32:11 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:50474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o63pV-0006Un-Da for submit@debbugs.gnu.org; Tue, 28 Jun 2022 01:32:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o63pV-0004im-1p for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 01:32:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o63pU-0004xu-O1 for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 01:32:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49116) by fencepost.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o63pU-0002Ul-IB for bug-emacs@gnu.org; Tue, 28 Jun 2022 01:32:04 -0400 Original-Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:38442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o63pQ-0004xK-5A for bug-emacs@gnu.org; Tue, 28 Jun 2022 01:32:04 -0400 Original-Received: by mail-pj1-x102e.google.com with SMTP id m14-20020a17090a668e00b001ee6ece8368so5442228pjj.3 for ; Mon, 27 Jun 2022 22:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:subject:date:message-id:mime-version; bh=SmhKWZEXb0+KS0fD5NYX0LmFKNfbCyitetYLMa38kW8=; b=gd7Q7Oo0XhAuDMx4XNuSBa83UAd4xlLwWWl1wtNJMicgCoydY1aF552MfBiL5lR4AV +7FC236g6KnG+gyo/CqpoVnva5pTVjy6EJ9LogX5RsK2Zg9FZO+OnfprN4LWCRySMRNZ bk6aAdvxhJ08Hs3DomGGhzQcyeoUjvtuepqKdfwMUJcUS5OFtrtuJ7DF4d9uyl4I6WbP 52YmoaVLj+OHIghdBRGFyGZ+w90mPEHtHERESWj+s3vSe87NLJBECBgKFmS/8MySMvzN 4YXisa24Ya9Jduqg2Jjw2luVeqdJVjpAa3rPOU7lLIwOg4Fm3uT0xkNzpHnAMsWjAx2W 6TrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=SmhKWZEXb0+KS0fD5NYX0LmFKNfbCyitetYLMa38kW8=; b=fvfUrQtp1bN/CzNFtZIAYzIl/VTWAnKp6DampHBjkCm16y/FvYxAjJ0zjQ52+PuzpP 1E/+IpCIc4Wv5eAhB6GLrwP45Rvmz1PxQwmKsuIsCxcEKYU8moEcUjahsul7ihpKByXq lUPnI1TlrgkvVIk6tG77INPkoUn/pOtDqW8w6WhavRrNst7z9UusFweXvfgBVbyLdF6b exKTTjG9wbXdjiFtM+caOeUqQ34qeVCYwk3ENqAqBNKYJVvgyZkmKzW2+j9+3Fu9xHm4 am00RUexw9QMpKgTcrba2Z/kZ/+lRZLGcIQgaKW0ppy0l1XESJ/V12fnX2Gw8jf+6ARg uQNQ== X-Gm-Message-State: AJIora94s48njL82AqQPo2nIneV6TrbLBZiviiSxXQ+7HEOFb01TnQtp EbqfP/nJvBPXJgseKmQ/U8cLhSzds10= X-Google-Smtp-Source: AGRyM1vqHneHA5LFJlaPSVtsnA2KXVEGcqCS2aylAMbG/e/dFYoIwoLMJFHkqXQqD9r4hSOh2ssfcA== X-Received: by 2002:a17:902:f78e:b0:168:fffc:fd57 with SMTP id q14-20020a170902f78e00b00168fffcfd57mr3104598pln.149.1656394317484; Mon, 27 Jun 2022 22:31:57 -0700 (PDT) Original-Received: from meyering-mbp ([2620:10d:c090:400::5:1cd]) by smtp.gmail.com with ESMTPSA id a8-20020a1709027e4800b001620db30cd6sm8147571pln.201.2022.06.27.22.31.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 22:31:56 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=meyering@gmail.com; helo=mail-pj1-x102e.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235513 Archived-At: --=-=-= Content-Type: text/plain I tried to build latest emacs bootstrapped with the latest autoconf and hit a failure due to inadequate quoting in configure.ac. This fixes three such problems: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-fix-configure.ac-quoting-of-AC_CHECK_LIB-s-2nd-arg.patch >From 5cbeba4d1f2102066b3d0c327e289c6a840b114b Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 26 Jun 2022 21:26:01 -0700 Subject: [PATCH] fix configure.ac quoting of AC_CHECK_LIB's 2nd arg Running an autoconf-head-generated configure, would fail like this: /emacs/configure: line 18002: syntax error near unexpected token `;;' /emacs/configure: line 18002: ` ;;' That is due to under-quoting of AC_CHECK_LIB's second argument, which led to the comma in an embedded string being interpreted as paramater-delimiting. * configure.ac: Quote the second arg of each AC_CHECK_LIB invocation. --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index c91b7de322..17f86627a7 100644 --- a/configure.ac +++ b/configure.ac @@ -3622,7 +3622,7 @@ AC_DEFUN CFLAGS="$CFLAGS $XFT_CFLAGS" LIBS="$XFT_LIBS $LIBS" AC_CHECK_HEADER(X11/Xft/Xft.h, - AC_CHECK_LIB(Xft, XftFontOpen, HAVE_XFT=yes, , $XFT_LIBS) , , + [AC_CHECK_LIB(Xft, XftFontOpen, HAVE_XFT=yes, , $XFT_LIBS)] , , [[#include ]]) if test "${HAVE_XFT}" = "yes"; then @@ -3818,7 +3818,7 @@ AC_DEFUN XCB_LIBS= if test "${HAVE_X11}" = "yes"; then AC_CHECK_HEADER(X11/Xlib-xcb.h, - AC_CHECK_LIB(xcb, xcb_translate_coordinates, HAVE_XCB=yes)) + [AC_CHECK_LIB(xcb, xcb_translate_coordinates, HAVE_XCB=yes)]) if test "${HAVE_XCB}" = "yes"; then AC_CHECK_LIB(X11-xcb, XGetXCBConnection, HAVE_X11_XCB=yes) if test "${HAVE_X11_XCB}" = "yes"; then @@ -4597,7 +4597,7 @@ AC_DEFUN HAVE_XSYNC=no if test "${HAVE_X11}" = "yes"; then AC_CHECK_HEADER(X11/extensions/sync.h, - AC_CHECK_LIB(Xext, XSyncQueryExtension, HAVE_XSYNC=yes), + [AC_CHECK_LIB(Xext, XSyncQueryExtension, HAVE_XSYNC=yes)], [], [#include ]) if test "${HAVE_XSYNC}" = "yes"; then -- 2.37.0.rc2 --=-=-=--