* bug#41184: 28.0.50; Crash on NS when opening text file in a possibly invalid zip archive
@ 2020-05-11 1:52 Filipp Gunbin
2020-05-11 14:44 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Filipp Gunbin @ 2020-05-11 1:52 UTC (permalink / raw)
To: 41184
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
- emacs -Q
- C-x C-f <path to attached zip> RET
- RET on the first file in archive (the one with .txt extension)
TTY emacs doesn't crash with the same recipe.
Thanks.
In GNU Emacs 28.0.50 (build 14, x86_64-apple-darwin19.2.0, NS appkit-1894.20 Version 10.15.2 (Build 19C57))
of 2020-05-09 built on fgunbin.local
Repository revision: ae3c510696f02f01d03052f070e5ce65b4018a45
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1894
System Description: Mac OS X 10.15.2
[-- Attachment #2: Фрейд Зигмунд. Вытеснение - royallib.com.txt.zip --]
[-- Type: application/zip, Size: 10982 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#41184: 28.0.50; Crash on NS when opening text file in a possibly invalid zip archive
2020-05-11 1:52 bug#41184: 28.0.50; Crash on NS when opening text file in a possibly invalid zip archive Filipp Gunbin
@ 2020-05-11 14:44 ` Eli Zaretskii
2020-05-11 15:57 ` Andrii Kolomoiets
2020-05-12 10:44 ` Filipp Gunbin
0 siblings, 2 replies; 7+ messages in thread
From: Eli Zaretskii @ 2020-05-11 14:44 UTC (permalink / raw)
To: Filipp Gunbin; +Cc: 41184
> From: Filipp Gunbin <fgunbin@fastmail.fm>
> Date: Mon, 11 May 2020 04:52:28 +0300
>
> - emacs -Q
> - C-x C-f <path to attached zip> RET
> - RET on the first file in archive (the one with .txt extension)
Can you please show the backtrace? Without that, the bug report is
only useful if the crash can be reproduced, and you shouldn't rely on
that (e.g, I couldn't reproduce it).
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#41184: 28.0.50; Crash on NS when opening text file in a possibly invalid zip archive
2020-05-11 14:44 ` Eli Zaretskii
@ 2020-05-11 15:57 ` Andrii Kolomoiets
2020-05-11 16:51 ` Eli Zaretskii
2020-05-12 10:44 ` Filipp Gunbin
1 sibling, 1 reply; 7+ messages in thread
From: Andrii Kolomoiets @ 2020-05-11 15:57 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Filipp Gunbin, 41184
Eli Zaretskii <eliz@gnu.org> writes:
>> - emacs -Q
>> - C-x C-f <path to attached zip> RET
>> - RET on the first file in archive (the one with .txt extension)
>
> Can you please show the backtrace? Without that, the bug report is
> only useful if the crash can be reproduced, and you shouldn't rely on
> that (e.g, I couldn't reproduce it).
For this time not only the subject contains "NS" but also the message
body contains "Mac OS X" ;-)
Can reproduce it with those steps. Here is backtrace:
Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: aString != nil'
abort() called
terminating with uncaught exception of type NSException
Application Specific Backtrace 1:
0 CoreFoundation 0x00007fff32c47d07 __exceptionPreprocess + 250
1 libobjc.A.dylib 0x00007fff6b96b5bf objc_exception_throw + 48
2 CoreFoundation 0x00007fff32c70ec8 +[NSException raise:format:arguments:] + 88
3 Foundation 0x00007fff3535bf3d -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 191
4 AppKit 0x00007fff2fe991c4 -[NSWindow setTitle:] + 185
5 Emacs-x86_64-10_14 0x000000010b22dfb1 ns_set_name_internal + 161
6 Emacs-x86_64-10_14 0x000000010b227e8b ns_implicitly_set_name + 475
7 Emacs-x86_64-10_14 0x000000010b08a531 gui_consider_frame_title + 609
8 Emacs-x86_64-10_14 0x000000010b05f9fc redisplay_internal + 1324
9 Emacs-x86_64-10_14 0x000000010b0fdbe5 read_char + 2213
10 Emacs-x86_64-10_14 0x000000010b0fb7aa read_key_sequence + 1722
11 Emacs-x86_64-10_14 0x000000010b0f9fac command_loop_1 + 1340
12 Emacs-x86_64-10_14 0x000000010b180b87 internal_condition_case + 263
13 Emacs-x86_64-10_14 0x000000010b10a120 command_loop_2 + 48
14 Emacs-x86_64-10_14 0x000000010b1803ab internal_catch + 267
15 Emacs-x86_64-10_14 0x000000010b24c385 command_loop.cold.1 + 69
16 Emacs-x86_64-10_14 0x000000010b0f9073 command_loop + 131
17 Emacs-x86_64-10_14 0x000000010b0f8fa3 recursive_edit_1 + 115
18 Emacs-x86_64-10_14 0x000000010b0f91fb Frecursive_edit + 347
19 Emacs-x86_64-10_14 0x000000010b0f7dd7 main + 7431
20 libdyld.dylib 0x00007fff6cb12cc9 start + 1
--
Andrii
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#41184: 28.0.50; Crash on NS when opening text file in a possibly invalid zip archive
2020-05-11 15:57 ` Andrii Kolomoiets
@ 2020-05-11 16:51 ` Eli Zaretskii
2020-05-11 18:46 ` Andrii Kolomoiets
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2020-05-11 16:51 UTC (permalink / raw)
To: Andrii Kolomoiets; +Cc: fgunbin, 41184
> From: Andrii Kolomoiets <andreyk.mad@gmail.com>
> Cc: Filipp Gunbin <fgunbin@fastmail.fm>, 41184@debbugs.gnu.org
> Date: Mon, 11 May 2020 18:57:52 +0300
>
> Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: aString != nil'
> abort() called
> terminating with uncaught exception of type NSException
>
> Application Specific Backtrace 1:
> 0 CoreFoundation 0x00007fff32c47d07 __exceptionPreprocess + 250
> 1 libobjc.A.dylib 0x00007fff6b96b5bf objc_exception_throw + 48
> 2 CoreFoundation 0x00007fff32c70ec8 +[NSException raise:format:arguments:] + 88
> 3 Foundation 0x00007fff3535bf3d -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 191
> 4 AppKit 0x00007fff2fe991c4 -[NSWindow setTitle:] + 185
> 5 Emacs-x86_64-10_14 0x000000010b22dfb1 ns_set_name_internal + 161
> 6 Emacs-x86_64-10_14 0x000000010b227e8b ns_implicitly_set_name + 475
> 7 Emacs-x86_64-10_14 0x000000010b08a531 gui_consider_frame_title + 609
Looks like some NS-specific issue with showing a strange file name in
the frame title?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#41184: 28.0.50; Crash on NS when opening text file in a possibly invalid zip archive
2020-05-11 16:51 ` Eli Zaretskii
@ 2020-05-11 18:46 ` Andrii Kolomoiets
2020-05-11 18:53 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Andrii Kolomoiets @ 2020-05-11 18:46 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: fgunbin, 41184
Eli Zaretskii <eliz@gnu.org> writes:
>> Terminating app due to uncaught exception
>> 'NSInternalInconsistencyException', reason: 'Invalid parameter not
>> satisfying: aString != nil'
>> abort() called
>> terminating with uncaught exception of type NSException
>>
>> Application Specific Backtrace 1:
>> 0 CoreFoundation 0x00007fff32c47d07 __exceptionPreprocess + 250
>> 1 libobjc.A.dylib 0x00007fff6b96b5bf objc_exception_throw + 48
>> 2 CoreFoundation 0x00007fff32c70ec8 +[NSException raise:format:arguments:] + 88
>> 3 Foundation 0x00007fff3535bf3d -[NSAssertionHandler
>> handleFailureInMethod:object:file:lineNumber:description:] + 191
>> 4 AppKit 0x00007fff2fe991c4 -[NSWindow setTitle:] + 185
>> 5 Emacs-x86_64-10_14 0x000000010b22dfb1 ns_set_name_internal + 161
>> 6 Emacs-x86_64-10_14 0x000000010b227e8b ns_implicitly_set_name + 475
>> 7 Emacs-x86_64-10_14 0x000000010b08a531 gui_consider_frame_title + 609
>
> Looks like some NS-specific issue with showing a strange file name in
> the frame title?
You are absolutely right.
Actually crash can be reproduced with single step:
(set-frame-name "\200")
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#41184: 28.0.50; Crash on NS when opening text file in a possibly invalid zip archive
2020-05-11 18:46 ` Andrii Kolomoiets
@ 2020-05-11 18:53 ` Eli Zaretskii
0 siblings, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2020-05-11 18:53 UTC (permalink / raw)
To: Andrii Kolomoiets; +Cc: fgunbin, 41184
> From: Andrii Kolomoiets <andreyk.mad@gmail.com>
> Cc: fgunbin@fastmail.fm, 41184@debbugs.gnu.org
> Date: Mon, 11 May 2020 21:46:38 +0300
>
> >> 4 AppKit 0x00007fff2fe991c4 -[NSWindow setTitle:] + 185
> >> 5 Emacs-x86_64-10_14 0x000000010b22dfb1 ns_set_name_internal + 161
> >> 6 Emacs-x86_64-10_14 0x000000010b227e8b ns_implicitly_set_name + 475
> >> 7 Emacs-x86_64-10_14 0x000000010b08a531 gui_consider_frame_title + 609
> >
> > Looks like some NS-specific issue with showing a strange file name in
> > the frame title?
>
> You are absolutely right.
>
> Actually crash can be reproduced with single step:
>
> (set-frame-name "\200")
It probably means the APIs used by ns_set_name_internal cannot handle
invalid UTF-8 sequences. The code there seems to naïvely encode in
UTF-8, but doesn't have any error handling for when that fails.
Someone who knows about NS programming should add some simple
workaround, like showing a string "\200" instead of a byte \200.
Or something.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#41184: 28.0.50; Crash on NS when opening text file in a possibly invalid zip archive
2020-05-11 14:44 ` Eli Zaretskii
2020-05-11 15:57 ` Andrii Kolomoiets
@ 2020-05-12 10:44 ` Filipp Gunbin
1 sibling, 0 replies; 7+ messages in thread
From: Filipp Gunbin @ 2020-05-12 10:44 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 41184
On 11/05/2020 17:44 +0300, Eli Zaretskii wrote:
>> From: Filipp Gunbin <fgunbin@fastmail.fm>
>> Date: Mon, 11 May 2020 04:52:28 +0300
>>
>> - emacs -Q
>> - C-x C-f <path to attached zip> RET
>> - RET on the first file in archive (the one with .txt extension)
>
> Can you please show the backtrace? Without that, the bug report is
> only useful if the crash can be reproduced, and you shouldn't rely on
> that (e.g, I couldn't reproduce it).
Sorry, my fault, I had it but forgot to insert. I see Andrii posted a
similar one.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-05-12 10:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 1:52 bug#41184: 28.0.50; Crash on NS when opening text file in a possibly invalid zip archive Filipp Gunbin
2020-05-11 14:44 ` Eli Zaretskii
2020-05-11 15:57 ` Andrii Kolomoiets
2020-05-11 16:51 ` Eli Zaretskii
2020-05-11 18:46 ` Andrii Kolomoiets
2020-05-11 18:53 ` Eli Zaretskii
2020-05-12 10:44 ` Filipp Gunbin
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).