From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41184: 28.0.50; Crash on NS when opening text file in a possibly invalid zip archive Date: Mon, 11 May 2020 21:53:49 +0300 Message-ID: <83d07a9ubm.fsf@gnu.org> References: <83v9l2bkg5.fsf@gnu.org> <831rnqbeka.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="63474"; mail-complaints-to="usenet@ciao.gmane.io" Cc: fgunbin@fastmail.fm, 41184@debbugs.gnu.org To: Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 11 20:56:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYDb4-000GMg-VF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 May 2020 20:56:14 +0200 Original-Received: from localhost ([::1]:32782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYDb3-0006Jw-VU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 May 2020 14:56:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYDZt-0005K8-W8 for bug-gnu-emacs@gnu.org; Mon, 11 May 2020 14:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41733) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYDZt-0003Wo-LA for bug-gnu-emacs@gnu.org; Mon, 11 May 2020 14:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYDZt-0004A9-KW for bug-gnu-emacs@gnu.org; Mon, 11 May 2020 14:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 May 2020 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41184 X-GNU-PR-Package: emacs Original-Received: via spool by 41184-submit@debbugs.gnu.org id=B41184.158922324315931 (code B ref 41184); Mon, 11 May 2020 18:55:01 +0000 Original-Received: (at 41184) by debbugs.gnu.org; 11 May 2020 18:54:03 +0000 Original-Received: from localhost ([127.0.0.1]:53279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYDYw-00048t-Pc for submit@debbugs.gnu.org; Mon, 11 May 2020 14:54:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYDYv-00048C-HC for 41184@debbugs.gnu.org; Mon, 11 May 2020 14:54:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44151) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYDYq-0003Lo-20; Mon, 11 May 2020 14:53:56 -0400 Original-Received: from [176.228.60.248] (port=2541 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jYDYp-0003sf-AM; Mon, 11 May 2020 14:53:55 -0400 In-Reply-To: (message from Andrii Kolomoiets on Mon, 11 May 2020 21:46:38 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180078 Archived-At: > From: Andrii Kolomoiets > Cc: fgunbin@fastmail.fm, 41184@debbugs.gnu.org > Date: Mon, 11 May 2020 21:46:38 +0300 > > >> 4 AppKit 0x00007fff2fe991c4 -[NSWindow setTitle:] + 185 > >> 5 Emacs-x86_64-10_14 0x000000010b22dfb1 ns_set_name_internal + 161 > >> 6 Emacs-x86_64-10_14 0x000000010b227e8b ns_implicitly_set_name + 475 > >> 7 Emacs-x86_64-10_14 0x000000010b08a531 gui_consider_frame_title + 609 > > > > Looks like some NS-specific issue with showing a strange file name in > > the frame title? > > You are absolutely right. > > Actually crash can be reproduced with single step: > > (set-frame-name "\200") It probably means the APIs used by ns_set_name_internal cannot handle invalid UTF-8 sequences. The code there seems to naïvely encode in UTF-8, but doesn't have any error handling for when that fails. Someone who knows about NS programming should add some simple workaround, like showing a string "\200" instead of a byte \200. Or something.