From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: ccsmile2008@outlook.com, Eli Zaretskii <eliz@gnu.org>,
65908@debbugs.gnu.org, gregory@heytings.org,
stefankangas@gmail.com
Subject: bug#65908: 29.1.50; Emacs 29 regresses on macOS
Date: Thu, 05 Oct 2023 17:11:09 +0200 [thread overview]
Message-ID: <m2v8blcdf6.fsf@Pro.fritz.box> (raw)
In-Reply-To: <ZR7PLvYHHbiejPfp@breton.holly.idiocy.org> (Alan Third's message of "Thu, 5 Oct 2023 15:58:54 +0100")
Alan Third <alan@idiocy.org> writes:
> On Thu, Oct 05, 2023 at 04:09:36PM +0200, Gerd Möllmann wrote:
>> Alan Third <alan@idiocy.org> writes:
>>
>> > Indeed. I'm tempted to say we should revert the change since I now
>> > suspect I misunderstood how setlocale works when I wrote this and I'm
>> > not sure it's actually improving anything.
>>
>> I hadn't checked this before, but with the patch I sent, the slowness is
>> indeed gone. What a bloody mess, this stuff :-).
>
> Yeah.
>
> To answer your question in the other email, I saw the improvement only
> by removing the setlocale in the "if" statement. Your code has
> something similar, but it shows the speed improvement anyway, so I'm
> not sure what's happening differently.
I'm actually no longer sure I want to know :-).
> I've gone over the NSLocale documentation and it appears it explicitly
> supports locales like en_DE, but the "UNIX" side of macOS doesn't. I
> suppose it should be possible to generate your own en_DE locale, but
> that's a bit much, really.
Agree. If someone wants to do this for some reason, more power to them.
They could then set LANG to it. I won't do it for my case because I
don't have TUI appls that require it, AFAIK.
> I also prodded at the fallback "system" locale, but it doesn't even
> provide a locale ID, so it's useless.
>
>
> There's a couple of typos in your commit message.
>
> Handle LANG on macOS differntly (bug#bug#65908)
> ^e ^
Oops, thanks for spotting this.
Remains the question if that should go into emacs-29? I'm for not
rocking the boat too much. Although...
next prev parent reply other threads:[~2023-10-05 15:11 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 6:47 bug#65908: 29.1.50; Emacs 29 regresses on macOS Zhang Haijun
2023-10-04 5:44 ` Gerd Möllmann
2023-10-04 7:38 ` Eli Zaretskii
2023-10-04 7:50 ` Gerd Möllmann
2023-10-04 8:29 ` Stefan Kangas
2023-10-04 8:32 ` Gerd Möllmann
2023-10-04 9:02 ` Gregory Heytings
2023-10-04 9:12 ` Gerd Möllmann
2023-10-04 9:12 ` Stefan Kangas
2023-10-04 10:55 ` Gerd Möllmann
2023-10-04 12:43 ` Gerd Möllmann
2023-10-04 21:16 ` Alan Third
2023-10-05 5:41 ` Eli Zaretskii
2023-10-05 5:55 ` Gerd Möllmann
2023-10-05 6:08 ` Eli Zaretskii
2023-10-05 8:52 ` Gerd Möllmann
2023-10-05 9:48 ` Alan Third
2023-10-05 11:12 ` Gerd Möllmann
2023-10-05 13:18 ` Gerd Möllmann
2023-10-05 16:11 ` Eli Zaretskii
2023-10-05 16:33 ` Alan Third
2023-10-05 16:38 ` Gerd Möllmann
2023-10-05 17:02 ` Eli Zaretskii
2023-10-05 17:15 ` Alan Third
2023-10-05 13:51 ` Alan Third
2023-10-05 14:01 ` Gerd Möllmann
2023-10-05 14:09 ` Gerd Möllmann
2023-10-05 14:58 ` Alan Third
2023-10-05 15:11 ` Gerd Möllmann [this message]
2023-10-05 16:29 ` Eli Zaretskii
2023-10-05 16:39 ` Gerd Möllmann
2023-10-05 17:06 ` Eli Zaretskii
2023-10-05 18:08 ` Stefan Kangas
2023-10-05 13:56 ` Gerd Möllmann
2023-10-05 16:19 ` Eli Zaretskii
2023-10-05 16:26 ` Alan Third
2023-10-05 16:43 ` Gerd Möllmann
2023-10-05 16:36 ` Gerd Möllmann
2023-10-05 17:04 ` Eli Zaretskii
2023-10-05 17:15 ` Gerd Möllmann
2023-10-05 18:25 ` Alan Third
2023-10-05 18:33 ` Gerd Möllmann
2023-10-05 18:46 ` Gerd Möllmann
2023-10-05 8:58 ` Gregory Heytings
2023-10-05 9:03 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2v8blcdf6.fsf@Pro.fritz.box \
--to=gerd.moellmann@gmail.com \
--cc=65908@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=ccsmile2008@outlook.com \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).