From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#65908: 29.1.50; Emacs 29 regresses on macOS Date: Thu, 05 Oct 2023 17:11:09 +0200 Message-ID: References: <83o7hd4n5n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38636"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: ccsmile2008@outlook.com, Eli Zaretskii , 65908@debbugs.gnu.org, gregory@heytings.org, stefankangas@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 05 17:12:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qoQ1O-0009oT-Qd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Oct 2023 17:12:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoQ0v-0000IU-PM; Thu, 05 Oct 2023 11:11:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoQ0u-0000Gr-9H for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 11:11:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoQ0t-0000VE-QB for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 11:11:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qoQ1C-0001F8-28 for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 11:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Oct 2023 15:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65908 X-GNU-PR-Package: emacs Original-Received: via spool by 65908-submit@debbugs.gnu.org id=B65908.16965186964736 (code B ref 65908); Thu, 05 Oct 2023 15:12:02 +0000 Original-Received: (at 65908) by debbugs.gnu.org; 5 Oct 2023 15:11:36 +0000 Original-Received: from localhost ([127.0.0.1]:48205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoQ0m-0001EJ-D4 for submit@debbugs.gnu.org; Thu, 05 Oct 2023 11:11:36 -0400 Original-Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:53359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoQ0l-0001E0-3F for 65908@debbugs.gnu.org; Thu, 05 Oct 2023 11:11:35 -0400 Original-Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-406402933edso9815435e9.2 for <65908@debbugs.gnu.org>; Thu, 05 Oct 2023 08:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696518671; x=1697123471; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2nE5HwhhIJgGs2b1woWndvkghkP5bgeSd/mirm9O3c8=; b=IDHpZ/KkMEZ77o6WT6tRQTj7ryTlnt9JhdzUCmIH+E0Wt3BVXHDBSZ66g7JtUeBPtD iacnNyMFOoHZRcANB4FiHSdFypzqUUzKAdM5LHIZzwooDFeF0BC/wR4aBjeNXvDs41tt CW/5t6GyQH4oTuAa+ti1nxYVtGzyWGVFj/FuysZR8OI+C7FCXq7YgqhzqzOdUsF32f3n XvgwMr+o/74DXQbTduh1V508zyfTepRBvsDzv5tUpdy92dWtlp8bsIkugAXzc9fYx/Ma XSJd/dvgLevI0s04rV1rXaabMZtRliZTXP1EpsV4nIGbGweAue5iMb/ZIWErUv2AXeNX K2Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696518671; x=1697123471; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2nE5HwhhIJgGs2b1woWndvkghkP5bgeSd/mirm9O3c8=; b=BXpvxHlFTXpM4RHIE3IRJ5B4zdu9UoPnB8VgAQQ1GNpLwyc+/oJVBoCdx+7uY2T2FF EbC2HnzAdojjT2xqJebRUMPwJ3bUV4QnxVwI0dv7RV1ZL0pSIaAPkIVJM7WOSEt4y3ae /GFtz6fvhs4Dy413uyGXmXAmNg8J/NVI/aBSZgWWAyqsMGQqHqpq5f5sveM70NYpZxHy NoirZX/3h+m82pENRvmMDE/6tutP3aYRclqWoBFPanG82KY50LsHP/jDv598/SoaLME1 m0+0ZmYgGQ8IiTn5l0BzzWTmVKx5OguA0ydtBWAvv066XmV4ksfZzYyaT5uNXoFKRAjC aQQg== X-Gm-Message-State: AOJu0Yx2+gbgtLIv1zPIspe0GDKo392a7Y2UJMnOrsspzwaGVImEqhM6 QxfWjEYNQ8Pw4QLR79TOJ0A= X-Google-Smtp-Source: AGHT+IFiuWuwws+YGBIA8Tt0HecuS2jvLTRH5JlOimoPHbTPT4HZziP4urFe7be2/1CyKSO0y+bq9w== X-Received: by 2002:a7b:cb8c:0:b0:405:3f19:fc49 with SMTP id m12-20020a7bcb8c000000b004053f19fc49mr5481579wmi.34.1696518670763; Thu, 05 Oct 2023 08:11:10 -0700 (PDT) Original-Received: from Pro.fritz.box (pd9e3618b.dip0.t-ipconnect.de. [217.227.97.139]) by smtp.gmail.com with ESMTPSA id z23-20020a1c4c17000000b00405935b417asm4005747wmf.2.2023.10.05.08.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 08:11:10 -0700 (PDT) In-Reply-To: (Alan Third's message of "Thu, 5 Oct 2023 15:58:54 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271880 Archived-At: Alan Third writes: > On Thu, Oct 05, 2023 at 04:09:36PM +0200, Gerd M=C3=B6llmann wrote: >> Alan Third writes: >>=20 >> > Indeed. I'm tempted to say we should revert the change since I now >> > suspect I misunderstood how setlocale works when I wrote this and I'm >> > not sure it's actually improving anything. >>=20 >> I hadn't checked this before, but with the patch I sent, the slowness is >> indeed gone. What a bloody mess, this stuff :-). > > Yeah. > > To answer your question in the other email, I saw the improvement only > by removing the setlocale in the "if" statement. Your code has > something similar, but it shows the speed improvement anyway, so I'm > not sure what's happening differently. I'm actually no longer sure I want to know :-). > I've gone over the NSLocale documentation and it appears it explicitly > supports locales like en_DE, but the "UNIX" side of macOS doesn't. I > suppose it should be possible to generate your own en_DE locale, but > that's a bit much, really. Agree. If someone wants to do this for some reason, more power to them. They could then set LANG to it. I won't do it for my case because I don't have TUI appls that require it, AFAIK. > I also prodded at the fallback "system" locale, but it doesn't even > provide a locale ID, so it's useless. > > > There's a couple of typos in your commit message. > > Handle LANG on macOS differntly (bug#bug#65908) > ^e ^ Oops, thanks for spotting this. Remains the question if that should go into emacs-29? I'm for not rocking the boat too much. Although...