From: Andrew Hyatt <ahyatt@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 53294@debbugs.gnu.org
Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer
Date: Sun, 16 Jan 2022 16:41:44 -0500 [thread overview]
Message-ID: <m2mtjvbbon.fsf@andrews-mbp.lan> (raw)
In-Reply-To: <837dazy2ah.fsf@gnu.org>
On Sun, Jan 16, 2022 at 08:16 PM Eli Zaretskii <eliz@gnu.org>
wrote:
>> From: Stefan Monnier <monnier@iro.umontreal.ca> Cc: Andrew
>> Hyatt <ahyatt@gmail.com>, 53294@debbugs.gnu.org Date: Sun, 16
>> Jan 2022 12:11:39 -0500 Some ways we can fix this: - In
>> `face-remap.el`, refrain from modifying the
>> `face-remapping-alist`
>> by side-effects (i.e. avoid `delq`, `setcdr`, and friends).
>> - Add a `make-indirect-buffer-hook` and arrange for
>> `face-remap.el` to
>> add a function there that does a deep enough copy of
>> `face-remapping-alist`.
>> - Remember that indirect buffers are an attractive nuisance
>> and should
>> be deprecated (but note that I suspect the same bug affects
>> `clone-buffer` because it doesn't make a deep enough copy of
>> `face-remapping-alist` either).
>
> The last one tells me we are better with leaving this sleeping
> dog lie.
I agree the use of indirect buffers is problematic, but this
problem actually results in user-visible bugs. Anyone who likes
their org-mode buffer to be variable-pitch, and likes their
capture buffer to be in a larger font (both pretty reasonable
things), will run into this problem.
My patch fixes this in a way whose only downside is that it would
be less efficient notably when you have a lot of face-remappings.
But it's not clear to me that face-remapping-alist ever gets so
big or is changed so often that this would be a problem.
The only other option is to fix this in org-mode, but they are
cloning their indirect buffer presumably so that the capture
buffer looks and behaves like the parent buffer, which is
reasonable. I'd have to break that, or maybe just add a hack to
deep copy face-remapping-alist. Both options seem a bit wrong.
next prev parent reply other threads:[~2022-01-16 21:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 5:13 bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Andrew Hyatt
2022-01-16 9:22 ` Eli Zaretskii
2022-01-16 14:43 ` Andrew Hyatt
2022-01-16 15:00 ` Eli Zaretskii
2022-01-16 15:28 ` Andrew Hyatt
2022-01-16 15:41 ` Eli Zaretskii
2022-01-16 17:11 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-16 18:16 ` Eli Zaretskii
2022-01-16 21:41 ` Andrew Hyatt [this message]
2022-01-17 21:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-18 2:24 ` Andrew Hyatt
2022-01-18 2:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-19 2:37 ` Andrew Hyatt
2022-01-19 3:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-20 13:42 ` Lars Ingebrigtsen
2022-02-16 17:41 ` Anders Johansson
2022-02-17 11:41 ` Lars Ingebrigtsen
2022-02-17 13:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mtjvbbon.fsf@andrews-mbp.lan \
--to=ahyatt@gmail.com \
--cc=53294@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).