From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Andrew Hyatt <ahyatt@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 53294@debbugs.gnu.org
Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer
Date: Mon, 17 Jan 2022 21:47:30 -0500 [thread overview]
Message-ID: <jwvo849epeg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m2iluhbx2f.fsf@andrews-mbp.lan> (Andrew Hyatt's message of "Mon, 17 Jan 2022 21:24:24 -0500")
> That sounds reasonable, I can do that. In fact, I just did this based on
> your suggestions, and it does work well. The only weird thing is that I had
> to pull `clone-indirect-buffer-hook' into the c code, because that's where
> `make-indirect-buffer' is.
You could leave the `defvar` in Lisp and only pull the DEFSYM, but
yes, you need to pull at least part of it into C.
> Let me know if that seems wrong.
Nope.
> I've attached the patch, please let me know if there is an issue. I have
> commit access, so I can just commit it myself after your OK (if so, I'll
> wait for a week or so to see if Eli has a comment as well before checkin).
Comments below, thanks,
Stefan
> diff --git a/lisp/face-remap.el b/lisp/face-remap.el
> index 00560f9d2e..fc0edb7119 100644
> --- a/lisp/face-remap.el
> +++ b/lisp/face-remap.el
> @@ -70,6 +70,14 @@ internal-lisp-face-attributes
> :foreground :background :stipple :overline :strike-through :box
> :font :inherit :fontset :distant-foreground :extend :vector])
>
> +(defun face-attrs--make-indirect-safe ()
> + "Do a deep copy of `face-remapping-alist' to keep the original buffer safe."
> + (setq-local face-remapping-alist
> + (copy-tree
> + (buffer-local-value 'face-remapping-alist (buffer-base-buffer)))))
I think `mapcar #'copy-sequence` is slightly more correct than
`copy-tree`, and you shouldn't need
(buffer-local-value 'face-remapping-alist (buffer-base-buffer)) because
that buffer's value should already have been copied to the current buffer.
> @@ -912,6 +912,10 @@ DEFUN ("make-indirect-buffer", Fmake_indirect_buffer, Smake_indirect_buffer,
> Fset (intern ("buffer-save-without-query"), Qnil);
> Fset (intern ("buffer-file-number"), Qnil);
> Fset (intern ("buffer-stale-function"), Qnil);
> + /* Cloned buffers need extra setup, to do things such as deep
> + variable copies for list variables that might be mangled due
> + to destructive operations in the indirect buffer. */
> + safe_run_hooks (Qclone_indirect_buffer_hook);
I think you want to use just `run_hook` here because there's no need to
catch errors.
More importantly, you need to remove the corresponding `run-hook` from
`clone-indirect-buffer`.
Stefan
next prev parent reply other threads:[~2022-01-18 2:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 5:13 bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Andrew Hyatt
2022-01-16 9:22 ` Eli Zaretskii
2022-01-16 14:43 ` Andrew Hyatt
2022-01-16 15:00 ` Eli Zaretskii
2022-01-16 15:28 ` Andrew Hyatt
2022-01-16 15:41 ` Eli Zaretskii
2022-01-16 17:11 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-16 18:16 ` Eli Zaretskii
2022-01-16 21:41 ` Andrew Hyatt
2022-01-17 21:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-18 2:24 ` Andrew Hyatt
2022-01-18 2:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-01-19 2:37 ` Andrew Hyatt
2022-01-19 3:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-20 13:42 ` Lars Ingebrigtsen
2022-02-16 17:41 ` Anders Johansson
2022-02-17 11:41 ` Lars Ingebrigtsen
2022-02-17 13:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvo849epeg.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=53294@debbugs.gnu.org \
--cc=ahyatt@gmail.com \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).