From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Hyatt Newsgroups: gmane.emacs.bugs Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Date: Sun, 16 Jan 2022 16:41:44 -0500 Message-ID: References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> <83ilujy9fi.fsf@gnu.org> <837dazy2ah.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11115"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53294@debbugs.gnu.org To: Eli Zaretskii , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 16 22:42:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9DHv-0002gz-Ax for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jan 2022 22:42:11 +0100 Original-Received: from localhost ([::1]:51858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9DHu-00021l-64 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jan 2022 16:42:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9DHn-00021E-26 for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 16:42:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9DHm-0006hF-P4 for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 16:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n9DHm-0001XW-Nd for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 16:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrew Hyatt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs Original-Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.16423693145889 (code B ref 53294); Sun, 16 Jan 2022 21:42:02 +0000 Original-Received: (at 53294) by debbugs.gnu.org; 16 Jan 2022 21:41:54 +0000 Original-Received: from localhost ([127.0.0.1]:44366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9DHe-0001Wq-9Q for submit@debbugs.gnu.org; Sun, 16 Jan 2022 16:41:54 -0500 Original-Received: from mail-qk1-f175.google.com ([209.85.222.175]:46028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9DHc-0001Wa-08 for 53294@debbugs.gnu.org; Sun, 16 Jan 2022 16:41:52 -0500 Original-Received: by mail-qk1-f175.google.com with SMTP id d11so4197455qkj.12 for <53294@debbugs.gnu.org>; Sun, 16 Jan 2022 13:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=EOPNKa/bf7FIjypBrvvWSP6JndN5+lSbNDfNAuBfVF8=; b=cpjSLD4fPmgYVYS+07L28GhevMgx7eJSH9VmekQ+DFA+rJlskqXKNcvutJlVgF9wWM b/2SNcW/cQ0HkjfWsgZroLveuGEqTks7XvWUC5KCdc7+Scb2888F/YGrc1MPxjOST/F2 WnEcgon/UEYzgx2/7TUdmBe+kLeqJpW00ysTefNa3mvbBYmPX2jLyBzxbh03dpOUaZAj CTXj6YZal3mDvc93tnkEJHTZWg5VmagVb32uVnh58TJHGSRfAamW/YtcOl5VylJiGiNI eyZiHxPj+MQFW+4jm+iRZxCClX4FEgev/L8iGg0yMKjytIKxKbypwI79zrPk7AIMnPHL S5gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=EOPNKa/bf7FIjypBrvvWSP6JndN5+lSbNDfNAuBfVF8=; b=BRmec3p4ykjNBl0kRbT/HchNnUR6pRjq6DG0b9sMxogaGagET5BIQm+OqwstgXT0Y2 Xufjduqu99oqGXxBMN929dwFVYrbXAsXumxpx48yMFP8b3PTtmJMvOyKzNBw/6uo9Jtd 8S/bmupg217yzz2jv2gSMEn+C4cTYenV662e9CkcMw/dr+5vMkJ7hAPOhbB/vbUHo1Kl 7qaq8M0b+0Ov4WDztFVB7i6kJVW+2M3siG4Tv/cOoPWtjcX4FvhHeHn5m0xrFTp2iaWY dIVb94LmOuHqbsUd8Np633qsglakcTwY5CP1Vf0FIrG3NwJjspaXROz1As/+FRsJveIl bO4g== X-Gm-Message-State: AOAM530xQk3JHQFOvdvCxCVEzi16D7zA3kPstzb5bi4djy7S4X52UA+S BJ2UKgQ2C2jaRcve7FjQIVWl0/xcXWg= X-Google-Smtp-Source: ABdhPJzubTVSozb3mmIx/ggMagWU2FRCfodBQ8orYn5kdPdcG5Y50vmGgHkcjg+h5KSYT4tBjCUMlg== X-Received: by 2002:a05:620a:22c4:: with SMTP id o4mr906772qki.534.1642369305985; Sun, 16 Jan 2022 13:41:45 -0800 (PST) Original-Received: from andrews-mbp.lan (pool-173-56-75-166.nycmny.fios.verizon.net. [173.56.75.166]) by smtp.gmail.com with ESMTPSA id j9sm7630763qkp.111.2022.01.16.13.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jan 2022 13:41:45 -0800 (PST) In-Reply-To: <837dazy2ah.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224418 Archived-At: On Sun, Jan 16, 2022 at 08:16 PM Eli Zaretskii wrote: >> From: Stefan Monnier Cc: Andrew >> Hyatt , 53294@debbugs.gnu.org Date: Sun, 16 >> Jan 2022 12:11:39 -0500 Some ways we can fix this: - In >> `face-remap.el`, refrain from modifying the >> `face-remapping-alist` >> by side-effects (i.e. avoid `delq`, `setcdr`, and friends). >> - Add a `make-indirect-buffer-hook` and arrange for >> `face-remap.el` to >> add a function there that does a deep enough copy of >> `face-remapping-alist`. >> - Remember that indirect buffers are an attractive nuisance >> and should >> be deprecated (but note that I suspect the same bug affects >> `clone-buffer` because it doesn't make a deep enough copy of >> `face-remapping-alist` either). > > The last one tells me we are better with leaving this sleeping > dog lie. I agree the use of indirect buffers is problematic, but this problem actually results in user-visible bugs. Anyone who likes their org-mode buffer to be variable-pitch, and likes their capture buffer to be in a larger font (both pretty reasonable things), will run into this problem. My patch fixes this in a way whose only downside is that it would be less efficient notably when you have a lot of face-remappings. But it's not clear to me that face-remapping-alist ever gets so big or is changed so often that this would be a problem. The only other option is to fix this in org-mode, but they are cloning their indirect buffer presumably so that the capture buffer looks and behaves like the parent buffer, which is reasonable. I'd have to break that, or maybe just add a hack to deep copy face-remapping-alist. Both options seem a bit wrong.