From: Roman Rudakov <rrudakov@fastmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "João Távora" <joaotavora@gmail.com>, 66646@debbugs.gnu.org
Subject: bug#66646: 29.1.90; No tsx syntax highlithting in typescript-ts-mode
Date: Fri, 20 Oct 2023 17:56:56 +0200 [thread overview]
Message-ID: <m2h6ml4779.fsf@fastmail.com> (raw)
In-Reply-To: <83pm19s9kk.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Roman Rudakov <rrudakov@fastmail.com>
>> Cc: 66646@debbugs.gnu.org
>> Date: Fri, 20 Oct 2023 15:17:01 +0200
>>
>> > I cannot reproduce this. I used a random *.tsx file on my
>> > system,
>> > and
>> > didn't get any error. So please post the file you used, and also
>> > describe step by step what to do to reproduce the problem
>> > starting
>> > from "emacs -Q".
>> >
>> > Thanks.
>>
>> After some debugging I figured out that it can be only reproduced
>> when
>> `eglot-ensure` is added to `typescript-ts-mode-hook` and
>> `tsx-ts-mode-hook`. So, steps to reproduce are the following:
>> - Optionally install `typescript-language-server` (if it's not
>> installed there will be eglot error, but the original issue will
>> still be reproducible).
>> - `emacs -Q`
>> - evaluate the following:
>>
>> (require 'typescript-ts-mode)
>> (require 'eglot)
>> (add-hook 'typescript-ts-mode-hook #'eglot-ensure)
>> (add-hook 'tsx-ts-mode-hook #'eglot-ensure)
>>
>> - open attached tsx file.
>
> Thanks, but in that case I cannot debug this because I don't have a
> Typescript LSP server installed. Someone else will need to do that.
>
> Adding João in case he has some inputs or suggestions.
As I mentioned, having language server installed is not necessary. I
was able to reproduce the problem without it. Eglot will just print an
error to the *Messages* buffer, but the problem with syntax
highlighting should still be reproducible.
--
Best regards, Roman
next prev parent reply other threads:[~2023-10-20 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 10:13 bug#66646: 29.1.90; No tsx syntax highlithting in typescript-ts-mode Roman Rudakov
2023-10-20 10:33 ` Eli Zaretskii
2023-10-20 13:17 ` Roman Rudakov
2023-10-20 13:32 ` Eli Zaretskii
2023-10-20 15:56 ` Roman Rudakov [this message]
2023-10-20 16:00 ` Dmitry Gutov
2023-10-20 16:26 ` Roman Rudakov
2023-10-20 22:53 ` Dmitry Gutov
2023-10-21 8:18 ` Roman Rudakov
2023-10-21 12:08 ` Dmitry Gutov
2023-10-21 18:20 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2h6ml4779.fsf@fastmail.com \
--to=rrudakov@fastmail.com \
--cc=66646@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).