bug#66646: 29.1.90; No tsx syntax highlithting in typescript-ts-mode

[Roman Rudakov <rrudakov@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]


Eli Zaretskii <eliz@gnu.org> writes:

>> From: Roman Rudakov <rrudakov@fastmail.com>
>> Date: Fri, 20 Oct 2023 12:13:15 +0200
>>
>>
>> - install the latest typescript/tsx grammar.
>> - open a .tsx source file
>>
>> I'm getting the following error in the *Messages* buffer:
>>
>> Error during redisplay: (jit-lock-function 1) signaled
>> (treesit-query-error "Structure error at" 22 "(jsx_opening_element
>> [(nested_identifier (identifier)) (identifier)]
>> @typescript-ts-jsx-tag-face) (jsx_closing_element 
>> [(nested_identifier
>> (identifier)) (identifier)] @typescript-ts-jsx-tag-face)
>> (jsx_self_closing_element [(nested_identifier (identifier))
>> (identifier)] @typescript-ts-jsx-tag-face) (jsx_attribute
>> (property_identifier) @typescript-ts-jsx-attribute-face)" "Debug 
>> the
>> query with `treesit-query-validate'")
>
> I cannot reproduce this.  I used a random *.tsx file on my system, 
> and
> didn't get any error.  So please post the file you used, and also
> describe step by step what to do to reproduce the problem starting
> from "emacs -Q".
>
> Thanks.

After some debugging I figured out that it can be only reproduced when 
`eglot-ensure` is added to `typescript-ts-mode-hook` and 
`tsx-ts-mode-hook`. So, steps to reproduce are the following:
- Optionally install `typescript-language-server` (if it's not 
  installed there will be eglot error, but the original issue will 
  still be reproducible).
- `emacs -Q`
- evaluate the following:

(require 'typescript-ts-mode)
(require 'eglot)
(add-hook 'typescript-ts-mode-hook #'eglot-ensure)
(add-hook 'tsx-ts-mode-hook #'eglot-ensure)

- open attached tsx file.


[-- Attachment #2: Random typescript source file --]
[-- Type: text/plain, Size: 353 bytes --]

import { JSX } from "preact";
import { IS_BROWSER } from "$fresh/runtime.ts";

export function Button(props: JSX.HTMLAttributes<HTMLButtonElement>) {
  return (
    <button
      {...props}
      disabled={!IS_BROWSER || props.disabled}
      class="px-2 py-1 border-gray-500 border-2 rounded bg-white hover:bg-gray-200 transition-colors"
    />
  );
}

[-- Attachment #3: Type: text/plain, Size: 25 bytes --]



--
Best regards, Roman