From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Roman Rudakov Newsgroups: gmane.emacs.bugs Subject: bug#66646: 29.1.90; No tsx syntax highlithting in typescript-ts-mode Date: Fri, 20 Oct 2023 17:56:56 +0200 Message-ID: References: <83r0lpshva.fsf@gnu.org> <83pm19s9kk.fsf@gnu.org> Reply-To: rrudakov@fastmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34051"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.7; emacs 29.1.90 Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 66646@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 20 17:58:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qtrti-0008aY-Tv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Oct 2023 17:58:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtrtU-0004Ik-Dt; Fri, 20 Oct 2023 11:58:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtrtT-0004IT-AM for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 11:58:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtrtT-0008MA-2M for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 11:58:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtrtu-00048k-9n for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 11:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Roman Rudakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Oct 2023 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66646 X-GNU-PR-Package: emacs Original-Received: via spool by 66646-submit@debbugs.gnu.org id=B66646.169781752115886 (code B ref 66646); Fri, 20 Oct 2023 15:59:02 +0000 Original-Received: (at 66646) by debbugs.gnu.org; 20 Oct 2023 15:58:41 +0000 Original-Received: from localhost ([127.0.0.1]:41278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtrtZ-000489-Ax for submit@debbugs.gnu.org; Fri, 20 Oct 2023 11:58:41 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:34963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtrtW-00047v-Mg for 66646@debbugs.gnu.org; Fri, 20 Oct 2023 11:58:39 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id EEABD5C0A02; Fri, 20 Oct 2023 11:58:05 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 20 Oct 2023 11:58:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:sender:subject:subject:to:to; s= fm3; t=1697817485; x=1697903885; bh=v+yFu9kpa71eouazZsUfriBCn/Qd 7iq9iXD+bYUubFo=; b=e/LF0Tf3cNPrvn6QtACZVW+8AYcqSUDZ3fGRfkOH0X0E WzkyfC9tnaWtu1B2rZFZ9ZFSYNW7gZtR0imANh1MuAc+eHUBHGJJOWHOa0zQRoVG avM48gLNuNvq0lVX9UxtPmEU1dD0l7/WUL/fwgNnyNIWLerr9wl2sD8WEye/FRvx a+QPjqFuBsx8ZGv0eU2C5jDqo9k9QlQVdhcBNGC1P8DAffTeg5rvmOM8XVaKEc2B MAFQwTJPGgRrRIW1o7UPpRsyNU/BM0vxeGKOsJmoM1iWgYXgrrp8B7zaY5YFIbuA /Sxfv77miOQs1dwECSvZDkxr9TpWYZkotLBormDtpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1697817485; x=1697903885; bh=v+yFu9kpa71eouazZsUfriBCn/Qd 7iq9iXD+bYUubFo=; b=PYKJXO8v4khiiMgGnRcG5xqMCbSt58ue47ddgZwgomL0 fzY5w/Ri2ha2FVRQ384d6enL/MqIOk2d2xdel6QYDyEwSU59OexdspV4/KQ9Ki4w nSEGoz7lBA0xdfH+DaAZ8E/kMVXEtt6Nslkx0hm0WZZA4aM2mC5TAPqFvcA3COAy RzVs7BJbxFqHk9AD80YL0T83jW4nR4LVgFrI3fwo+bfR5kZIxLQPI10eHaCq9yl3 eGFhIQzn5P8ENeWMNiVSKdPCRkbXIIUwd9DIdjXCzgrzmcxkTeUdg58f0JCaBINh KcdNOqnv+T4qQufCH/Vvvy+Hurk3spCzmBlJHhCYdw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjeekgdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffrhgjkfggtgfgsehtqhertddtreejnecuhfhrohhmpeftohhm rghnucftuhgurghkohhvuceorhhruhgurghkohhvsehfrghsthhmrghilhdrtghomheqne cuggftrfgrthhtvghrnhepffegvdevffelfefgfeeutdeiveduteetuedugffhgeelieef tdfftdetveefteetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomheprhhruhgurghkohhvsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: i1c714620:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Oct 2023 11:58:04 -0400 (EDT) In-reply-to: <83pm19s9kk.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272801 Archived-At: Eli Zaretskii writes: >> From: Roman Rudakov >> Cc: 66646@debbugs.gnu.org >> Date: Fri, 20 Oct 2023 15:17:01 +0200 >> >> > I cannot reproduce this. I used a random *.tsx file on my=20 >> > system, >> > and >> > didn't get any error. So please post the file you used, and also >> > describe step by step what to do to reproduce the problem=20 >> > starting >> > from "emacs -Q". >> > >> > Thanks. >> >> After some debugging I figured out that it can be only reproduced=20 >> when >> `eglot-ensure` is added to `typescript-ts-mode-hook` and >> `tsx-ts-mode-hook`. So, steps to reproduce are the following: >> - Optionally install `typescript-language-server` (if it's not >> installed there will be eglot error, but the original issue will >> still be reproducible). >> - `emacs -Q` >> - evaluate the following: >> >> (require 'typescript-ts-mode) >> (require 'eglot) >> (add-hook 'typescript-ts-mode-hook #'eglot-ensure) >> (add-hook 'tsx-ts-mode-hook #'eglot-ensure) >> >> - open attached tsx file. > > Thanks, but in that case I cannot debug this because I don't have a > Typescript LSP server installed. Someone else will need to do that. > > Adding Jo=C3=A3o in case he has some inputs or suggestions. As I mentioned, having language server installed is not necessary. I=20 was able to reproduce the problem without it. Eglot will just print an=20 error to the *Messages* buffer, but the problem with syntax=20 highlighting should still be reproducible. -- Best regards, Roman