From: Filipp Gunbin <fgunbin@fastmail.fm>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Alan Third <alan@idiocy.org>, 33154@debbugs.gnu.org
Subject: bug#33154: 27.0.50; create_process on Darwin should not invoke setsid() after vfork() [PATCH]
Date: Wed, 07 Nov 2018 11:53:23 +0300 [thread overview]
Message-ID: <m2efbxqnek.fsf@fastmail.fm> (raw)
In-Reply-To: <fc9123bf-e9fb-fa89-73a5-a79db13372f9@cs.ucla.edu> (Paul Eggert's message of "Tue, 6 Nov 2018 23:41:46 -0800")
Yes, dissociate_controlling_tty looks nice. I thought about checking
what setsid() returns too, but thought I'd do this after some testing.
> Also, I think we can call the function from just two places (not
> three).
Are you sure we can remove that 3rd place? It dates back to initial
revision from 1992. And I can't tell why it's there and what it does.
Filipp
next prev parent reply other threads:[~2018-11-07 8:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 19:30 bug#33154: 27.0.50; create_process on Darwin should not invoke setsid() after vfork() [PATCH] Filipp Gunbin
2018-10-26 11:12 ` Alan Third
2018-11-07 1:35 ` Filipp Gunbin
2018-11-05 17:28 ` Paul Eggert
2018-11-06 13:46 ` Filipp Gunbin
2018-11-07 1:23 ` Filipp Gunbin
2018-11-07 7:41 ` Paul Eggert
2018-11-07 8:53 ` Filipp Gunbin [this message]
2018-11-07 15:40 ` Paul Eggert
2018-11-09 0:07 ` Alan Third
2018-11-09 10:29 ` Filipp Gunbin
2018-11-09 11:16 ` Andreas Schwab
2018-11-10 15:24 ` Filipp Gunbin
2018-11-10 17:09 ` Paul Eggert
2018-11-11 17:14 ` Filipp Gunbin
2018-11-10 17:05 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2efbxqnek.fsf@fastmail.fm \
--to=fgunbin@fastmail.fm \
--cc=33154@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).