From: Alan Third <alan@idiocy.org>
To: Filipp Gunbin <fgunbin@fastmail.fm>
Cc: 33154@debbugs.gnu.org
Subject: bug#33154: 27.0.50; create_process on Darwin should not invoke setsid() after vfork() [PATCH]
Date: Fri, 26 Oct 2018 12:12:27 +0100 [thread overview]
Message-ID: <20181026111227.GA48441@breton.holly.idiocy.org> (raw)
In-Reply-To: <m24ld94yez.fsf@fgunbin.playteam.ru>
On Thu, Oct 25, 2018 at 10:30:12PM +0300, Filipp Gunbin wrote:
> This resulted from analysis of bug 33050. To avoid repetition, here's
> the message with explanation:
> http://lists.gnu.org/archive/html/bug-gnu-emacs/2018-10/msg00763.html
Sorry, I didn’t notice the other emails before now.
This looks fine to me, but I’m no expert on this stuff.
Just one point, though:
> /* Make the pty be the controlling terminal of the process. */
> #ifdef HAVE_PTYS
> /* First, disconnect its current controlling terminal.
> Do this even if !PTY_FLAG; see Bug#30762. */
> +#ifdef DARWIN_OS
> + /* Darwin doesn't let us run setsid after a vfork, so use
> + TIOCNOTTY when necessary. */
> + {
> + int j = emacs_open (DEV_TTY, O_RDWR, 0);
> + if (j >= 0)
> + {
> + ioctl (j, TIOCNOTTY, 0);
> + emacs_close (j);
> + }
> + }
> +#else
> setsid ();
> +#endif
The main block of this code looks identical to the BSD specific code
just underneath (#ifdef TIOCNOTTY), is there a reason we can’t reuse
that?
--
Alan Third
next prev parent reply other threads:[~2018-10-26 11:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 19:30 bug#33154: 27.0.50; create_process on Darwin should not invoke setsid() after vfork() [PATCH] Filipp Gunbin
2018-10-26 11:12 ` Alan Third [this message]
2018-11-07 1:35 ` Filipp Gunbin
2018-11-05 17:28 ` Paul Eggert
2018-11-06 13:46 ` Filipp Gunbin
2018-11-07 1:23 ` Filipp Gunbin
2018-11-07 7:41 ` Paul Eggert
2018-11-07 8:53 ` Filipp Gunbin
2018-11-07 15:40 ` Paul Eggert
2018-11-09 0:07 ` Alan Third
2018-11-09 10:29 ` Filipp Gunbin
2018-11-09 11:16 ` Andreas Schwab
2018-11-10 15:24 ` Filipp Gunbin
2018-11-10 17:09 ` Paul Eggert
2018-11-11 17:14 ` Filipp Gunbin
2018-11-10 17:05 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026111227.GA48441@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=33154@debbugs.gnu.org \
--cc=fgunbin@fastmail.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).